A couple commands don't need sys/param.h, but they do need sys/signal.h

Delete tests for P_THREAD that predate the existence of
KERN_PROC_SHOW_THREADS and have been rendered superfluous by it.
Similarly, some P_SYSTEM tests can be deleted or pushed to the
kernel by using

Delete tests for P_THREAD that predate the existence of
KERN_PROC_SHOW_THREADS and have been rendered superfluous by it.
Similarly, some P_SYSTEM tests can be deleted or pushed to the
kernel by using KERN_PROC_ALL instead of KERN_PROC_KTHREAD.

ok visa@ mpi@

show more ...

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Use uid_from_user(3) and gid_from_group(3) in utilities that
do repeated lookups. OK tb@

- mark delim variable as const. it is a literal string;
- no need to declare main() prototype;
- mark all functions as static;
- add __dead marker to usage(), since it doesn't return;
- zap extern *o

- mark delim variable as const. it is a literal string;
- no need to declare main() prototype;
- mark all functions as static;
- add __dead marker to usage(), since it doesn't return;
- zap extern *optarg/optind in main(), It is already done in unistd.h;
- return from main instead of exit(3) that enables stack protector;
- fix err() eval in pledge()s error path.

OK millert@

show more ...

fix a regression spotted by chris@. the -f and -I arguments fetch process
arguments using kvm_getargs, after the pledge() has been made. someone
brave should refactor this, hoisting the argument fe

fix a regression spotted by chris@. the -f and -I arguments fetch process
arguments using kvm_getargs, after the pledge() has been made. someone
brave should refactor this, hoisting the argument fetching to between
kvm_getprocs() and pledge() - storing the argument data as neccessary.
the current situation is also a race -- it fetches the data twice.

show more ...

pkill has to get all the getopt, getpwuid, libkvm stuff out of the way
first. it can pledge to "stdio" (pgrep case) or "stdio proc" (pkill case)
before parsing and matching the expression.
ok doug

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

calloc, from peter malone

simpler prototype repairs

Stop merging the per-thread and per-process flags when reporting
them via sysctl(KERN_PROC). In struct kinfo_proc the per-process
flags move to p_psflags, leaving the per-thread flags in p_flags.
Fl

Stop merging the per-thread and per-process flags when reporting
them via sysctl(KERN_PROC). In struct kinfo_proc the per-process
flags move to p_psflags, leaving the per-thread flags in p_flags.
Flag descriptions in ps(1) updated to be less obtuse.

discussed with matthew@ some time ago; ok jca@, manpage bits ok jmc@

show more ...

-I to confirm pkills. ok many

properly handle the case where a process has disappeared in between grep'ing
and printing it

discussed with and ok millert@

Missing "-q" in usage().

ok espie@

add -q "silent" option similar to grep
okay ajacoutot@, guenther@

make pkill -l print the proper processes also when the invert (-v)
flag is passed

ok lum@

Remove a check made superfluous by the KERN_PROC_SHOW_THREADS flag.
This lets new binaries work (at least w/o the -H option) with old kernels.

ok pirofti@ deraadt@

Add per thread accounting, mainly for usage & friends.

This expands the already bloated FILL_KPROC macro to take an extra
parameter that indicates if the callee is a thread or a process.

The userla

Add per thread accounting, mainly for usage & friends.

This expands the already bloated FILL_KPROC macro to take an extra
parameter that indicates if the callee is a thread or a process.

The userland bits are adjusted accordingly and ps(1) and top(1) now
display per thread usage times when -H is used.

Also pkill(1) had to be adjusted so that duplicates don't pop up.

libkvm does basically the same thing as the kernel bits.

Okay guenther@.

show more ...

Teach pgrep/pkill to only match processes, not threads. ok guenther@

Remove unused variable. Added in 1.20 by me.

exit usage() with STATUS_BADUSAGE rather than STATUS_ERROR, per the man page;

fix proposed by lum actually happened in netbsd -r1.16, some 6 years ago;
ok lum

avoid usage() warping onto the next line;

restrict pkill/pgrep to the routing domain specified by -T; ok henning@, mpf@

Allow pkill to use the -l option. This displays which processes have been
signalled using the "Long" format, like pgrep.

Original diff from FreeBSD, modified somewhat on tech@, with feedback from ni

Allow pkill to use the -l option. This displays which processes have been
signalled using the "Long" format, like pgrep.

Original diff from FreeBSD, modified somewhat on tech@, with feedback from nicm@

Man page input from jmc@

show more ...

Switch back from KERN_PROC2/kinfo_proc2 to KERN_PROC/kinfo_proc now
that we've got name we want for the API we want

"ZAP!" deraadt@