When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

parameter "lines_allocated" is a local pointer and should not be confused
with the global by the same name, so rename it "lines_allocatedp".

Cleanup close(open idioms.
ok krw

creat() -> open equiv; from Frederic Nowak

Remove support for automatically checking files out of RCS. The
behavior is confusing to users and even GNU patch no longer does
it by default. OK krw@ guenther@

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

Fix division by zero for files with long lines (> 1024) in Plan B mode
by supporting arbitrarily long lines just like Plan A does.

ok tedu

Prevent null pointer dereference on empty input files when diff requires
a specific version.

ok millert

Remove SCCS support. For this to work, we would need "get", which we don't
even have in ports. XSI functionality of POSIX, therefore optional.

ok deraadt, schwarze, tedu

Call munmap with the same size argument as mmap.

ok millert, otto

userland reallocarray audit.

Replace malloc() and realloc() calls that may have integer overflow in the
multiplication of the size argument with reallocarray().

ok deraadt@

unsigned char casts for ctype
ok krw

Don't try to mmap a zero length file, from NetBSD.
Needed after the recent mmap(2) change.

ok ariane@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

type police and assorted cleanup. From Lionel Fourquaux; ok ray@

constuct -> construct

spacing

MAP_FILE is the default and MAP_PRIVATE has to be given or produces evil warnings in debug kernel

madvise(sequential) the mmap()ed file and plug an fd leak on mmap() failure; millert@ ok

realloc(3) cleanup.

ok cloder@ tedu@

Add license from patch.c to original source files missing a license.

ok deraadt@

Fix no newline at end of file case for Plan B.

ok millert@ tedu@

Do not add an extra newline at the end if the last line of the input
file contains no newline and the diff does not touch the last line.
Contributions from millert@.

ok millert@ tedu@

Avoid scanning the input file twice.

ok millert@ tedu@