sys/usb: fix ISOCHRONOUS IN transfer offsets

Offsets for ISOCHRONOUS IN frames are now based on a fixed packet size
(xfer->length / xfer->nframes), ensuring accuracy even with shorter frames.

OK: m

sys/usb: fix ISOCHRONOUS IN transfer offsets

Offsets for ISOCHRONOUS IN frames are now based on a fixed packet size
(xfer->length / xfer->nframes), ensuring accuracy even with shorter frames.

OK: mpi@

show more ...

Fix some spelling.

Input and ok jmc@, jsg@

Upon resume, run usb_attach_roothub() in DVACT_WAKEUP rather than DVACT_RESUME.
The usb root hub is a software construct, not actual hardware, and the code
has a potential to reach sleeping points (w

Upon resume, run usb_attach_roothub() in DVACT_WAKEUP rather than DVACT_RESUME.
The usb root hub is a software construct, not actual hardware, and the code
has a potential to reach sleeping points (which won't work because DVACT_RESUME
runs cold).

show more ...

remove unneeded includes; ok mpi@

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

spelling
feedback and ok tb@ jmc@ ok ratchov@

This allows us to disable usb(4) without kernel crash.

ok mpi@

update some usb.org URLs following reorganisation, add a new one for upd
partly from Alessandro Ricci

Don't rely on wTotalLength for usbd_get_cdesc() malloc/free but on the
actual length which has been allocated. We saw cases where the
wTotalLength value is changing on a second read, e.g. when a USB

Don't rely on wTotalLength for usbd_get_cdesc() malloc/free but on the
actual length which has been allocated. We saw cases where the
wTotalLength value is changing on a second read, e.g. when a USB device
was waked up from sleep mode.

ok mpi@

show more ...

Fix a potential panic during free(9) which can be caused by an USB
device which returns a spurious value for wTotalLength on a configuration
descriptor request. Therefore don't relay on wTotalLength

Fix a potential panic during free(9) which can be caused by an USB
device which returns a spurious value for wTotalLength on a configuration
descriptor request. Therefore don't relay on wTotalLength for free(9)
but on the length variable which was used for the malloc(9) before.

The issue was reported by
Mikolaj Kucharski <mikolaj (at) kucharski (dot) name> on bugs@.

Discussed and ok deraadt@

show more ...

tsleep(9) to tsleep_nsec(9) conversions.

ok visa@, kn@, cheloha@

No need to call usbd_fill_deviceinfo() from a task, it doesn't generate I/O.

ok visa@

Use "%s", __func__ in DPRINTF() to reduce grep noise.

free(9) sizes for configuration descriptors, missed in previous.

remove shadow variables for 'error' in usbioctl(); ok mpi@ ratchov@

Simplify/refactor the way vendor/product/serial informations are
gathered from usb devices.

Cache them early in usbd_new_device() instead of querying the device
several times (the content wont chang

Simplify/refactor the way vendor/product/serial informations are
gathered from usb devices.

Cache them early in usbd_new_device() instead of querying the device
several times (the content wont change anyway) and uselessly generating
usb traffic (which could conflict with other access..)

The heuristic stays the same, first look in the device descriptor, then
try to match against usb_known_vendors/usb_known_products, then fallback
to use the idVendor/idProduct codes.

Remove the now useless 'usedev' parameter from usbd_fill_deviceinfo().

Tested from bsd & bsd.rd.

suggested by and ok mpi@

show more ...

Support dumping isochronous frames via bpf(4) using the USBPcap protocol.

ok deraadt@, ratchov@

Add a default case to a usb_tap() switch statement which mpi@ says will
never be called to convince compilers and static analysis tools a path
that uses uninitialised memory does not exist.

ok krw@

Add a default case to a usb_tap() switch statement which mpi@ says will
never be called to convince compilers and static analysis tools a path
that uses uninitialised memory does not exist.

ok krw@ mpi@

show more ...

Remove almost unused `flags' argument of suser().

The account flag `ASU' will no longer be set but that makes suser()
mpsafe since it no longer mess with a per-process field.

No objection from mill

Remove almost unused `flags' argument of suser().

The account flag `ASU' will no longer be set but that makes suser()
mpsafe since it no longer mess with a per-process field.

No objection from millert@, ok tedu@, bluhm@

show more ...

Add support for dumping USB transfers via bpf(4) using USBPcap headers.

ok deraadt@, dlg@

Remove useless conditional before free().

ok mpi@

Do not permit USB ioctl handler malloc(9)'s to block as this interferes
with expected behavior.

OK mpi@ patrick@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Cache vendor, product and serial info for each usb device. This allows
ioctl(USB_DEVICEINFO) not to issue any further requests to gather
information. Thus reducing stress on connected usb devices.

Cache vendor, product and serial info for each usb device. This allows
ioctl(USB_DEVICEINFO) not to issue any further requests to gather
information. Thus reducing stress on connected usb devices.
This fixes an issue where usbdevs called in a loop causes a USB mass
storage device to halt operation.

Adapted from a similar commit in NetBSD.

ok mpi@

show more ...

Convert uiomovei to uiomove. Fixes a few integer truncations along the
way.

ok natano@