Fix display of pdisk partition sizes by casting the 32-bit number
of blocks to (long long) before multiplying by 512 and passing the
value to fmt_scaled().

Discovered and fix tested by rpe@.

ok rpe

Fix display of pdisk partition sizes by casting the 32-bit number
of blocks to (long long) before multiplying by 512 and passing the
value to fmt_scaled().

Discovered and fix tested by rpe@.

ok rpe@ deraadt@

show more ...

Nuke pointless map field 'physical_block' and just use 'sbBlkSize' which is
set to the same value.

Nuke djust_value_and_compute_prefix() and use fmt_scaled() to display
human readable sizes.

Just call contains_driver() when you need to know rather than carrying a
flag around. More obviously current data. Nuke unnecessary variables
when displaying a partition.

Move dump_block() declaration from io.h to io.c since it is not
used anywhere else.

Remove declarations of non-existant kPatchType and init_partition_map().

Apple sets lblock_start and lblocks to 0 in free space entries. Do
the same.

Don't use lblock_start or lblocks in calculation for length@base
display. We no longer display lblock info there.

Move last three lines (#define's) from dpme.h to partition_map.h and
tweak #include's as necessary.

Fold struct dpme into struct entry. Same reasons as for folding
struct block0 into struct partition_map. Easier to read code.

Fold struct block0 into struct partition map. There can be only one
and read/write_block0() can move the data from/to disk to/from
appropriate fields anywhere. Removes a bunch of dereferencing,
mallo

Fold struct block0 into struct partition map. There can be only one
and read/write_block0() can move the data from/to disk to/from
appropriate fields anywhere. Removes a bunch of dereferencing,
malloc'ing and pointer checking.

show more ...

Tweak printing of partitions. Always show the pblock info in the
'p' command output. And always show the lblock info in the 'P'
command. Showing sometimes one and sometimes another with a subtle
extr

Tweak printing of partitions. Always show the pblock info in the
'p' command output. And always show the lblock info in the 'P'
command. Showing sometimes one and sometimes another with a subtle
extra character to indicate which is being shown is error prone.

show more ...

Shorter names means a few whitespace adjustments.

Rename struct partition_map_header to struct partition_map. No change to
.o files.

Rename struct partition_map to struct entry. No change to .o files.

Hand rolled lists suck. First, replace disk_order with an LIST.

Since we don't allow maps to be created or opened with an invalid
block0, there is no point in checking later if block0 has magically
become invalid.

No need to copy dmpe_name to a buffer before printing it.

make sure to check malloc(3) return pointer against NULL.
OK krw@

We do not support logical_block != physical_block. Remove logical_block
field and left over code that checks for logical != physical.

Removes confusion with dmpe fields lblock_start and lblocks, whi

We do not support logical_block != physical_block. Remove logical_block
field and left over code that checks for logical != physical.

Removes confusion with dmpe fields lblock_start and lblocks, which
have nothing to do with block sizes! lblock_start is the block
offset within the partition where the data actually starts. and
lblocks is the number of blocks of data within the partition. Both
are in units of *physical blocks*, a.k.a. disk sectors.

show more ...

Nuke another (and I hope final) batch of superfluous '{}' around single
statements.

dpme_name and dpme_type are NUL-terminated in Apple code, so use
strlcpy() to fill them.

They are also supposed to be NUL-padded so zap previous contents
before copying in possibly shorter new value

dpme_name and dpme_type are NUL-terminated in Apple code, so use
strlcpy() to fill them.

They are also supposed to be NUL-padded so zap previous contents
before copying in possibly shorter new values.

show more ...

Whitespace, line wrapping fixes. Nuke many superfluous '{}' around single
statements. 0 -> NULL for pointer checks.

Whitespace, line wrapping fixes.

Use new read/write_block0 and read/write_dpme which handle any
endian or alignment issues forcefully. Removes need for convert_*
functions so unhook convert.c from build. read/write_block become
stat

Use new read/write_block0 and read/write_dpme which handle any
endian or alignment issues forcefully. Removes need for convert_*
functions so unhook convert.c from build. read/write_block become
static functions inside file_media.c.

Tweak struct block0 to stop trying to handle alignment issues by clever
declaration. Rely on the new functions to accurately translate between
on-disk and in-memory layouts.

Enables pdisk to work on amd64 and likely other architectures if
it's ever desirable. Does bring back DEV_BSIZE to pdisk.c since the
in-memory structure will *not* be 512 bytes on other archs.

show more ...

Tweak fields in struct dpme to be more consistent with Apple's info.

Better comments, make all reserved fields uint8_t arrays, don't
claim uint32_t fields are actually pointers.

remove some uneeded includes
ok krw@