When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

pledge(2) for talkd(8):

rpath: fopen(3) _PATH_UTMP in read mode
wpath/cpath: fopen(3) full_tty in write mode (w), which implies O_CREAT
inet/dns: the intervening hosts in the conversation may be rem

pledge(2) for talkd(8):

rpath: fopen(3) _PATH_UTMP in read mode
wpath/cpath: fopen(3) full_tty in write mode (w), which implies O_CREAT
inet/dns: the intervening hosts in the conversation may be remote, or not, but
since we will never know beforehand then it'll always need inet and dns to
resolve the hostnames

ok jca@ and also discussed with tb@

show more ...

Remove unused headers and sort the remaining

OK tb@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

spacing

simple protos

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

avoid size_t -> int conversion. style nit for sizeof(). David Krause

sa_family on wire is network byteorder. from Alexander Yurchenko <grange@rt.mipt.ru>

- "resposne" is used without initialization, so zero-fill
- sendto(2) performed with osockaddr, so avoid that
- reject anything other than AF_INET

based on patch from xs@kittenz.org. deraadt/miller

- "resposne" is used without initialization, so zero-fill
- sendto(2) performed with osockaddr, so avoid that
- reject anything other than AF_INET

based on patch from xs@kittenz.org. deraadt/millert ok

show more ...

use socklen_t more; henning ok

add a missing newline to an error message.

from Jean-Francois Brousseau <krapht@secureops.com>

ok deraadt@

o Use *_FILENO defines instead of numbers
o Kill sockt global, it is not needed
o Use STDOUT_FILENO as the 1st arg to sendto().

Previously we used sockt in sendto() which only worked because a) glob

o Use *_FILENO defines instead of numbers
o Kill sockt global, it is not needed
o Use STDOUT_FILENO as the 1st arg to sendto().

Previously we used sockt in sendto() which only worked because a) globals
are intialized to 0 and b) inetd sets up fds 0-2 dup'd to the same thing
so it didn't matter that we were sending to stdin, not stdout.

show more ...

KNF

Fix gethostname() usage.

deraadt@ ok

-Wall

save_errno in signal handler

Force NUL termination of strings in request we get from client; okir@monad.swb.de

Patch to catch non-printables in the announce string
(ala the 'flash' hack) from FreeBSD (cleanup of patch
from Dima Ruban <dima@demos.su>).

Also fixes a syslog() message--we use recvfrom now.

param.h

full hostnames; from cstruble@singularity.bevc.blacksburg.va.us

fix time differencies computations (orig from alan@parsys.co.uk, but
don't use difftime(3), it returns double)
use <sys/queue.h> for queue maintanance

Fix the bugs w/ that osockaddr.
minor cleanups.
this was tested w/: OpenBSD, Kleenux, BSDi (in all combinations).