Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by A

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

show more ...

unveil maildir, utmp, /tmp, and /dev. For the vast number of people
using biff.

check return from pread, don't divide -1 for count

use recallocarray() because the array contains data that can be observed

Prefer pread() over lseek()+read()
open() only needs the mode argument if O_CREAT is present

ok beck@ deraadt@

Use open(tty, O_WRONLY) + fdopen() instead of fopen(tty, "w") to
keep stdio from opening with O_CREAT which would require pledge cpath.

Call pledge(2) after initial getsockname(2) to avoid "inet" addition.

From & OK deraadt@

normalize a few more tame request orderings, to help review

With nfs spool (fork + seteuid/setuid balony) support gone, it becomes
possible to pledge "stdio rpath wpath tty proc"
Noone uses this code anymore. This is a demonstration...

remove NFS spool support; it stands in the way of pledge(2)

Trim trailing whitespace from the comsat message before calling
strtonum() to parse the offset since mail.local writes a trailing
newline. Otherwise comsat just discards the message. OK deraadt@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

remove some unnecessary sys/param.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

recv(2) returns a ssize_t, so match cc with it.
st.st_mtime is a time_t, so match utmpmtime with it.
Check for -1 instead of <0 for some system calls.
Remove pointless casts.

OK dhill@ and millert@

the third arg of read() is size_t, not int (cast fix)
use UT_NAMESIZE more consistently
from Andrey Matveev

more signal flag races; ok miod@

ARGSUSED before signal handler with unused signo

free(NULL) allowed

Fix typo in revision 1.29; deraadt@ OK

realloc fixes; ho ok

use fseeko; millert ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.