Remove #error if OPENSSL_NO_FOO is defineddiscussed with jsing
md4/ripemd: remove misplaced semicolons
Neuter the bounded attribute as was done elsewhere for portable
Reverse order of attributesrequested by jsing on review
Remove support for static buffers in HMAC/digestsHMAC() and the one-step digests used to support passing a NULL buffer andwould return the digest in a static buffer. This design is firmly from the
Remove support for static buffers in HMAC/digestsHMAC() and the one-step digests used to support passing a NULL buffer andwould return the digest in a static buffer. This design is firmly from thenineties, not thread safe and it saves callers a single line. The few portsthat used to rely this were fixed with patches sent to non-hostile (andnon-dead) upstreams. It's early enough in the release cycle that remaininguses hidden from the compiler should be caught, at least the ones thatmatter.There won't be that many since BoringSSL removed this feature in 2017.https://boringssl-review.googlesource.com/14528Add non-null attributes to the headers and add a few missing boundedattributes.ok beck jsing
show more ...
Load in the top of the loop, as we do for other hash implementations.
Demacro md4.Use static inline functions instead of macros. Also number rounds as perthe RFC.ok joshua@ tb@
Inline initial values.No functional change.
Rework input and output handling for md4.Use le32toh(), htole32() and crypto_{load,store}_htole32() as appropriate.ok joshua@ tb@
Remove now unnecessary do {} while (0);
Inline HASH_MAKE_STRING.No change to generated assembly.
Reorder functions expanded from md32_common.h.No functional change.
Expand HASH_* defines.No change to generated assembly.
Inline hash functions from md32_common.h.No change to generated assembly.
Reorder functions.No functional change.
Tidy includes.
Remove MD32_REG_T.This is a hack that is only enabled on a handful of 64 bit platforms, asa workaround for poor compiler optimisation. If you're running an archiaccompiler on an archiac architect
Remove MD32_REG_T.This is a hack that is only enabled on a handful of 64 bit platforms, asa workaround for poor compiler optimisation. If you're running an archiaccompiler on an archiac architecture, then you can deal with slightly lowerperformance.ok tb@
Combine md4 into a single C file.
Mop up MD32_XARRAY from md4.MD32_XARRAY was added as a workaround for a broken HP C compiler (circa1999). Clean it up to simplify the code.No change in generated assembly.
Hide symbols in md4 and md5ok tb@
Hit md4 with the style(9) stick.
Inline md4_local.h in md4_dgst.c.md4_local.h is not really a local header, just another layer of indirectionthat cannot be included by anything other than md4_dgst.c. As such, includeit directly
Inline md4_local.h in md4_dgst.c.md4_local.h is not really a local header, just another layer of indirectionthat cannot be included by anything other than md4_dgst.c. As such, includeit directly instead.No change in generated assembly.
Make internal header file names consistentLibcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h namesused for internal headers. Move all these headers we inherited fromOpenSSL to *_l
Make internal header file names consistentLibcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h namesused for internal headers. Move all these headers we inherited fromOpenSSL to *_local.h, reserving the name *_internal.h for our own code.Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.constant_time_locl.h is moved to constant_time.h since it's special.Adjust all .c files in libcrypto, libssl and regress.The diff is mechanical with the exception of tls13_quic.c, where#include <ssl_locl.h> was fixed manually.discussed with jsing,no objection bcook
Explicitly export a list of symbols from libcrypto.Move the "internal" BN functions from bn.h to bn_lcl.h and stop exportingthe bn_* symbols. These are documented as only being intended for intern
Explicitly export a list of symbols from libcrypto.Move the "internal" BN functions from bn.h to bn_lcl.h and stop exportingthe bn_* symbols. These are documented as only being intended for internaluse, so why they were placed in a public header is beyond me...This hides 363 previously exported symbols, most of which exist in headersthat are not installed and were never intended to be public. This alsoremoves a few crusty old things that should have died long ago (like_ossl_old_des_read_pw). But don't worry... there are still 3451 symbolsexported from the library.With input and testing from inoguchi@.ok beck@ inoguchi@
Temporarily revive MD4 for MS CHAP support.
123