#
d1579b2d |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
acc190f4 |
| 04-Nov-2016 |
macallan <macallan@NetBSD.org> |
set BUS_SPACE_MAP_PREFETCHABLE when mapping the SFB32 range now using alpha fonts is actually faster than using bitmap fonts
|
#
fa70cee0 |
| 22-Dec-2011 |
macallan <macallan@NetBSD.org> |
support anti-aliased fonts and let the hardware do the alpha blending
|
#
d436f96f |
| 31-Oct-2011 |
jdc <jdc@NetBSD.org> |
Add support for the WSDISPLAYIO_GET_EDID ioctl (requires passing a device_t to ffb_attach).
|
#
b6584574 |
| 01-Jul-2011 |
dyoung <dyoung@NetBSD.org> |
#include <sys/bus.h> instead of <machine/bus.h>.
|
#
817999e9 |
| 03-Jun-2011 |
christos <christos@NetBSD.org> |
CFATTACH_DECL_NEW
|
#
9912ffbb |
| 21-Sep-2010 |
macallan <macallan@NetBSD.org> |
* implement hw acceleration for putchar() * use VCONS for copycols() * don't map the framebuffer now that we don't access it anymore * make a bunch of drawing engine syncs optional
|
#
95e1ffb1 |
| 11-Dec-2005 |
christos <christos@NetBSD.org> |
merge ktrace-lwp.
|
#
21d2a323 |
| 04-May-2005 |
martin <martin@NetBSD.org> |
Make ffb take part in the /dev/fbN circus.
|
#
d261be07 |
| 04-May-2005 |
martin <martin@NetBSD.org> |
Ansify.
|
#
ae5ea826 |
| 01-Jul-2004 |
heas <heas@NetBSD.org> |
The DAC registers do not need to be mapped linearly and thus should not.
|
#
a60b59cc |
| 21-May-2004 |
heas <heas@NetBSD.org> |
Map the ffb's DAC register space and add support for video "blanking" (aka WSDISPLAYIO_{S,G}VIDEO).
|
#
2f1de3c8 |
| 19-Mar-2004 |
petrov <petrov@NetBSD.org> |
More on fbnode to prom_stdout_node rename.
|
#
ed517291 |
| 15-Jul-2003 |
lukem <lukem@NetBSD.org> |
__KERNEL_RCSID()
|
#
49f3f8cc |
| 23-May-2003 |
petrov <petrov@NetBSD.org> |
Port of OpenBSD ffb driver written by Jason L. Wright.
|