#
d1579b2d |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
c363a9cb |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
bzero -> memset
|
#
53524e44 |
| 04-Mar-2007 |
christos <christos@NetBSD.org> |
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
|
#
95e1ffb1 |
| 11-Dec-2005 |
christos <christos@NetBSD.org> |
merge ktrace-lwp.
|
#
095fcda9 |
| 13-Jun-2005 |
jmc <jmc@NetBSD.org> |
Fix some shadowing of variables
|
#
dc4cc98b |
| 24-Feb-2004 |
wiz <wiz@NetBSD.org> |
becuase -> because. From Peter Postma.
|
#
840aee88 |
| 31-May-2003 |
kristerw <kristerw@NetBSD.org> |
Use __asm instead of asm, to keep lint happy.
|
#
77a6b82b |
| 06-Sep-2002 |
gehenna <gehenna@NetBSD.org> |
Merge the gehenna-devsw branch into the trunk.
This merge changes the device switch tables from static array to dynamically generated by config(8).
- All device switches is defined as a constant st
Merge the gehenna-devsw branch into the trunk.
This merge changes the device switch tables from static array to dynamically generated by config(8).
- All device switches is defined as a constant structure in device drivers.
- The new grammer ``device-major'' is introduced to ``files''.
device-major <prefix> char <num> [block <num>] [<rules>]
- All device major numbers must be listed up in port dependent majors.<arch> by using this grammer.
- Added the new naming convention. The name of the device switch must be <prefix>_[bc]devsw for auto-generation of device switch tables.
- The backward compatibility of loading block/character device switch by LKM framework is broken. This is necessary to convert from block/character device major to device name in runtime and vice versa.
- The restriction to assign device major by LKM is completely removed. We don't need to reserve LKM entries for dynamic loading of device switch.
- In compile time, device major numbers list is packed into the kernel and the LKM framework will refer it to assign device major number dynamically.
show more ...
|
#
31144d99 |
| 17-Mar-2002 |
atatat <atatat@NetBSD.org> |
Convert ioctl code to use EPASSTHROUGH instead of -1 or ENOTTY for indicating an unhandled "command". ERESTART is -1, which can lead to confusion. ERESTART has been moved to -3 and EPASSTHROUGH has
Convert ioctl code to use EPASSTHROUGH instead of -1 or ENOTTY for indicating an unhandled "command". ERESTART is -1, which can lead to confusion. ERESTART has been moved to -3 and EPASSTHROUGH has been placed at -4. No ioctl code should now return -1 anywhere. The ioctl() system call is now properly restartable.
show more ...
|
#
1ea4df81 |
| 28-Jan-2002 |
aymeric <aymeric@NetBSD.org> |
add __KERNEL_RCSID as suggested by Luke Mewburn
|
#
9382c873 |
| 26-Jan-2002 |
aymeric <aymeric@NetBSD.org> |
- ANSIfy - remove some trailing spaces/tabs - minor style nits
|
#
30cef417 |
| 21-Jun-2000 |
is <is@NetBSD.org> |
- auto-USE_C_BFOPS when !defined(__m68k__) - for bold characters, only blit the leftmost ftwidth pixels per character cell row. The rightmost row which used to be printed would have been overwrit
- auto-USE_C_BFOPS when !defined(__m68k__) - for bold characters, only blit the leftmost ftwidth pixels per character cell row. The rightmost row which used to be printed would have been overwritten formerly by the next character on sequential output, so no visible change will result most of the time. This fixes two problems: * USE_C_BFOPS (which only works for 8 pixel wide fonts) blits the same for bold characters now... it used to print the rightmost 8 pixel columns of the bold-smeared characters * we no longer need a reserved 1 pixel column at the right end of the screen. That is, a 640x400 screen will hold 80x50 charactes with the 8x8 font.
show more ...
|
#
ebc6483e |
| 24-May-2000 |
is <is@NetBSD.org> |
missed one line when converting m68k asm() to macro calls.
|
#
6f846139 |
| 20-Sep-1999 |
is <is@NetBSD.org> |
replace inline asm by macro calls, that expand to the original inline asm or to C replacements depending on the USE_C_BFOPS option. The C replacement only works for our 8 bit wide fonts.
|
#
b30a4d19 |
| 25-Mar-1999 |
is <is@NetBSD.org> |
Defopting grf_cc configuration parameters
|
#
974e9f6e |
| 21-Apr-1996 |
veego <veego@NetBSD.org> |
- Cleanup for -Wall and -Wstrict-prototypes - Added support for multiple floppy drives - CyberVision64: - has now a real console mode - another bugfix for boards with the new S3 chip
- Cleanup for -Wall and -Wstrict-prototypes - Added support for multiple floppy drives - CyberVision64: - has now a real console mode - another bugfix for boards with the new S3 chip - Ariadne: - fixed crashes with aeput (mbuf failure)
show more ...
|
#
2ca98c3c |
| 07-May-1995 |
chopps <chopps@NetBSD.org> |
enable pseudo-dma on ivsc, allow no ite/grfcc.
|
#
b87e0d85 |
| 02-Mar-1995 |
chopps <chopps@NetBSD.org> |
allow 8 bit chars in ite.
|
#
e85a3c53 |
| 16-Feb-1995 |
chopps <chopps@NetBSD.org> |
cleanup copyright stuff
|
#
548708dd |
| 01-Dec-1994 |
chopps <chopps@NetBSD.org> |
bring up to current. change sun to sunos. handle changes in device open params and autoconf match function params.
|
#
ec77f0b3 |
| 26-Oct-1994 |
cgd <cgd@NetBSD.org> |
new RCS ID format.
|
#
8c6621ad |
| 15-Jun-1994 |
chopps <chopps@NetBSD.org> |
clock now uses passed in frequency if present protect dma cache flush calls from non 040. don't compile ite_xx if not used.
|
#
6729c03f |
| 13-Jun-1994 |
chopps <chopps@NetBSD.org> |
some cleanup and various fixes for new fs code. plus some general fixes from from osymh@gemini.oscs.montana.edu (Michael L. Hitch)
|
#
11a73d2a |
| 25-May-1994 |
chopps <chopps@NetBSD.org> |
MIN() -> min()
|
#
15d4cf6b |
| 08-May-1994 |
chopps <chopps@NetBSD.org> |
resistance is futile, you will be assimilated. amiga goes: config.new *and* /sys/scsi. clock code coerced into a single .c file adding an accurate usec delay(). disklabel.c updated to DTRT, code to w
resistance is futile, you will be assimilated. amiga goes: config.new *and* /sys/scsi. clock code coerced into a single .c file adding an accurate usec delay(). disklabel.c updated to DTRT, code to write RDB's to be added soon. sbic (old scsi) converted over to new scsi and config this covers about 90% of users. Other drivers soon.
show more ...
|