#
86c30724 |
| 28-May-2022 |
andvar <andvar@NetBSD.org> |
fix various typos, mainly in comments.
|
#
d1579b2d |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
f9228f42 |
| 25-Jul-2014 |
dholland <dholland@NetBSD.org> |
Add d_discard to all struct cdevsw instances I could find.
All have been set to "nodiscard"; some should get a real implementation.
|
#
889cc98c |
| 22-Mar-2014 |
christos <christos@NetBSD.org> |
kill sprintf fix unused variables
|
#
a68f9396 |
| 16-Mar-2014 |
dholland <dholland@NetBSD.org> |
Change (mostly mechanically) every cdevsw/bdevsw I can find to use designated initializers.
I have not built every extant kernel so I have probably broken at least one build; however I've also found
Change (mostly mechanically) every cdevsw/bdevsw I can find to use designated initializers.
I have not built every extant kernel so I have probably broken at least one build; however I've also found and fixed some wrong cdevsw/bdevsw entries so even if so I think we come out ahead.
show more ...
|
#
26a64d43 |
| 22-Jan-2014 |
christos <christos@NetBSD.org> |
gcc-4.8.x unused variable fixes
|
#
cbab9cad |
| 27-Oct-2012 |
chs <chs@NetBSD.org> |
split device_t/softc for all remaining drivers. replace "struct device *" with "device_t". use device_xname(), device_unit(), etc.
|
#
01173747 |
| 15-Dec-2011 |
phx <phx@NetBSD.org> |
Amiga wscons/Xorg support, first phase. Implemented wscons for CV64 and CV64/3D. Other graphics cards drivers are prepared for it, but will not be attempted before Xorg is not running. The wscons sup
Amiga wscons/Xorg support, first phase. Implemented wscons for CV64 and CV64/3D. Other graphics cards drivers are prepared for it, but will not be attempted before Xorg is not running. The wscons support is disabled by default. A GENERIC kernel should behave like always. Use WSCONS to try out a kernel with wscons support. Done by rkujawa@ and phx@.
show more ...
|
#
2626d576 |
| 24-Apr-2011 |
rmind <rmind@NetBSD.org> |
Rename ttymalloc() to tty_alloc(), and ttyfree() to tty_free() for consistency. Remove some unnecessary malloc.h inclusions as well.
|
#
9b6bd2d9 |
| 08-Feb-2011 |
rmind <rmind@NetBSD.org> |
Remove clause 3 (UCB advertising clause) from the University of Utah copyright. Confirmed by Mike Hibler, mike at cs.utah.edu - thanks! Also, merge UCB and Utah copyright texts back into one, as the
Remove clause 3 (UCB advertising clause) from the University of Utah copyright. Confirmed by Mike Hibler, mike at cs.utah.edu - thanks! Also, merge UCB and Utah copyright texts back into one, as they originally were.
Extra verification by snj@.
show more ...
|
#
0f34e84a |
| 30-Jan-2010 |
phx <phx@NetBSD.org> |
Do not crash when ite wasn't configured to be console.
|
#
62cf489d |
| 26-Oct-2009 |
cegger <cegger@NetBSD.org> |
kill extra whitespaces reviewed by tsutsui@
|
#
42b74af3 |
| 19-May-2009 |
phx <phx@NetBSD.org> |
Removed old Amiga-specific "sicallback" software interrupts and replaced them by MI softints. Approved by "is".
|
#
e2cb8590 |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
bcopy -> memcpy
|
#
c363a9cb |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
bzero -> memset
|
#
35fb6474 |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
bcmp -> memcmp
|
#
937f5cd4 |
| 11-Jun-2008 |
tsutsui <tsutsui@NetBSD.org> |
Use device_private() and device_lookup_private() to get softc.
|
#
ae1187f6 |
| 20-May-2008 |
phx <phx@NetBSD.org> |
amiga/amiga/isr.h must not be included for __m68k__ only. At the moment it is required by amigappc as well.
|
#
9d6e1af5 |
| 02-Dec-2007 |
mhitch <mhitch@NetBSD.org> |
Initializing the callout structure while it's in use is bad. Only do it on the first call to iteinit().
|
#
dc26833b |
| 19-Nov-2007 |
ad <ad@NetBSD.org> |
- Factor out too many copies of the same bit of tty code. - Fix another tty signalling/wakeup problem.
|
#
d238692c |
| 18-Oct-2007 |
joerg <joerg@NetBSD.org> |
Initialise the callbacks for tty.t_rstrt_ch in ttymalloc as all drivers but Sun/SPARC's kd.c use the same arguments. Separate callout_reset into callout_schedule and the initial callout_setfunc using
Initialise the callbacks for tty.t_rstrt_ch in ttymalloc as all drivers but Sun/SPARC's kd.c use the same arguments. Separate callout_reset into callout_schedule and the initial callout_setfunc using that.
show more ...
|
#
d974db0a |
| 17-Oct-2007 |
garbled <garbled@NetBSD.org> |
Merge the ppcoea-renovation branch to HEAD.
This branch was a major cleanup and rototill of many of the various OEA cpu based PPC ports that focused on sharing as much code as possible between the v
Merge the ppcoea-renovation branch to HEAD.
This branch was a major cleanup and rototill of many of the various OEA cpu based PPC ports that focused on sharing as much code as possible between the various ports to eliminate near-identical copies of files in every tree. Additionally there is a new PIC system that unifies the interface to interrupt code for all different OEA ppc arches. The work for this branch was done by a variety of people, too long to list here.
TODO: bebox still needs work to complete the transition to -renovation. ofppc still needs a bunch of work, which I will be looking at. ev64260 still needs to be renovated amigappc was not attempted.
NOTES: pmppc was removed as an arch, and moved to a evbppc target.
show more ...
|
#
6cfc4427 |
| 11-Jul-2007 |
he <he@NetBSD.org> |
Move the declaration of repeat_ch up before its first use, so that this builds again.
|
#
88ab7da9 |
| 09-Jul-2007 |
ad <ad@NetBSD.org> |
Merge some of the less invasive changes from the vmlocking branch:
- kthread, callout, devsw API changes - select()/poll() improvements - miscellaneous MT safety improvements
|
#
53524e44 |
| 04-Mar-2007 |
christos <christos@NetBSD.org> |
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
|