net/nfp: add missing period in logs

Unified add period at the end of the sentence in log.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewe

net/nfp: add missing period in logs

Unified add period at the end of the sentence in log.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: reformat abbreviations in logs

Unified do not apply abbreviations in log.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: L

net/nfp: reformat abbreviations in logs

Unified do not apply abbreviations in log.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

common/nfp: move platform module

Move the platform module to the common library.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng

common/nfp: move platform module

Move the platform module to the common library.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: extend usage of BAR from 8 to 24

Sync the logic from kernel driver, adjust the definition of structure,
and extend the usage of nfp BAR from 8 to 24.

This will greatly enhance the scalabil

net/nfp: extend usage of BAR from 8 to 24

Sync the logic from kernel driver, adjust the definition of structure,
and extend the usage of nfp BAR from 8 to 24.

This will greatly enhance the scalability of nfp PMD.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: refactor cppcore and PCIe module

Sync the logic from kernel driver, use the new entry function from the
PCIe module instead of the cppcore module.

Signed-off-by: Chaoyong He <chaoyong.he@c

net/nfp: refactor cppcore and PCIe module

Sync the logic from kernel driver, use the new entry function from the
PCIe module instead of the cppcore module.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: refactor cppcore module

Modify the comment and standard the coding style.
Move the definition of data structure into the implement file to make
the API small.
Also sync the logic from kerne

net/nfp: refactor cppcore module

Modify the comment and standard the coding style.
Move the definition of data structure into the implement file to make
the API small.
Also sync the logic from kernel driver and remove the unneeded header
file include statements.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: add header file for PCIe module

Add a new header file for the PCIe module.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

net/nfp: refactor target module

Move the function declaration into the header file, and sync some
logic from kernel driver.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

net/nfp: rename some parameters and variables

Rename some parameter and variable to make the logic easier to
understand.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

net/nfp: standardize blank character

Use space character to align instead of TAB character.
There should one blank line to split the block of logic, no more no less.

Signed-off-by: Chaoyong He <cha

net/nfp: standardize blank character

Use space character to align instead of TAB character.
There should one blank line to split the block of logic, no more no less.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: standardize comment style

Follow the DPDK coding style, use the kdoc comment style.
Also move the comment of the functions to the implement file and
add some comment to help understand logi

net/nfp: standardize comment style

Follow the DPDK coding style, use the kdoc comment style.
Also move the comment of the functions to the implement file and
add some comment to help understand logic.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: adjust the log statement

Add log statement to the important control logic, which means
more strict check of the return value of function call.
Also remove some verbose info log statement.

net/nfp: adjust the log statement

Add log statement to the important control logic, which means
more strict check of the return value of function call.
Also remove some verbose info log statement.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: standardize local variable coding style

There should only declare one local variable in each line, and the local
variable should be arranged from short to long in the function.

Signed-off-

net/nfp: standardize local variable coding style

There should only declare one local variable in each line, and the local
variable should be arranged from short to long in the function.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: remove the unneeded logic

Remove the unneeded logic.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

net/nfp: unify the type of integer variable

Unify the type of integer variable to the DPDK prefer style.
Also change the return type of 'nfp_eth_speed2rate()' to the
corresponding enum, which make i

net/nfp: unify the type of integer variable

Unify the type of integer variable to the DPDK prefer style.
Also change the return type of 'nfp_eth_speed2rate()' to the
corresponding enum, which make it more readable.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: unify the indent coding style

Each parameter of function should occupy one line, and indent two TAB
character.
All the statement which span multi line should indent two TAB character.

Sign

net/nfp: unify the indent coding style

Each parameter of function should occupy one line, and indent two TAB
character.
All the statement which span multi line should indent two TAB character.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: compare to null and 0 explicitly

To compliance with the coding standard, make the pointer variable
explicitly comparing to 'NULL' and the integer variable explicitly
comparing to '0'.

Sign

net/nfp: compare to null and 0 explicitly

To compliance with the coding standard, make the pointer variable
explicitly comparing to 'NULL' and the integer variable explicitly
comparing to '0'.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: fix offloading flows

The symbol '_abi_flower_extra_features' is in IMEM for NFP4000,
but in EMU_CACHE for NFP3800 because which does not have IMEM.

The original logic can't read symbol fro

net/nfp: fix offloading flows

The symbol '_abi_flower_extra_features' is in IMEM for NFP4000,
but in EMU_CACHE for NFP3800 because which does not have IMEM.

The original logic can't read symbol from EMU_CACHE, so the probe
process will fail when we try to offload flows use NFP3800.

Modify the related data structure and logics to support read symbol
from EMU_CACHE.

Fixes: c7e9729da6b5 ("net/nfp: support CPP")
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

show more ...

net/nfp: use generic macros for array size and to set bits

Instead of using NFP specific macros for array size and to set bits use
the generic ones provided by DPDK.

By moving some include directiv

net/nfp: use generic macros for array size and to set bits

Instead of using NFP specific macros for array size and to set bits use
the generic ones provided by DPDK.

By moving some include directives for system header files directly to
the source files that depend on them, the header file nfp_platform.h
defining the NFP specific macros can be removed.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

show more ...

net/nfp: drop usage of return error helpers

Drop the usage of complex return error helpers. These helpers was used
to return either NULL or -1 from a function while communicating the
error using err

net/nfp: drop usage of return error helpers

Drop the usage of complex return error helpers. These helpers was used
to return either NULL or -1 from a function while communicating the
error using errno. However erron was seldom checked and the error path
was taken only depending on the functions return value.

Remove the macros and convert the few callers that did look at errno to
communicate different errors using the return value instead. Also update
all the related documentation.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

show more ...

net/nfp: move shared target logic to own file

Move the needed logic of nfp_target.h and nfp_cppat.h
to a new source file nfp_target.c, and delete the logic
which are not used at all.

The code is mo

net/nfp: move shared target logic to own file

Move the needed logic of nfp_target.h and nfp_cppat.h
to a new source file nfp_target.c, and delete the logic
which are not used at all.

The code is moved verbatim from the header file to the source
file, no functional change.

This mainly to mimic the source file structure in the kernel
driver, and also gives a nice decrease in driver size.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

show more ...

net/nfp: compare with explicit null and 0

Removal of the '!' character when comparing variables in favour of
explicitly comparing the variable to either 'NULL' or '0', in
compliance with the standar

net/nfp: compare with explicit null and 0

Removal of the '!' character when comparing variables in favour of
explicitly comparing the variable to either 'NULL' or '0', in
compliance with the standard.

Signed-off-by: James Hershaw <james.hershaw@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

show more ...

net/nfp: remove usage of print statements

Removal of the usage of printf() statements from the nfp PMD in favour
of appropriate RTE logging functions in compliance with the standard.

Debug messages

net/nfp: remove usage of print statements

Removal of the usage of printf() statements from the nfp PMD in favour
of appropriate RTE logging functions in compliance with the standard.

Debug messages are now logged using the appropriate RTE_LOG functions so
it is no longer necessary to print specific statements when compiled in
with the DEBUG tag, rather log these messages using the appropriate
functions regardless of whether the DEBUG tag is set or not.

Signed-off-by: James Hershaw <james.hershaw@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

show more ...

fix spelling in comments and strings

The tool comes from https://github.com/jsoref

Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

net/nfp: read chip model from PluDevice register

For newer smartNIC NVRAM versions the chip model should be read from the
PluDevice register as it provides the authoritative chip model/revision.
Thi

net/nfp: read chip model from PluDevice register

For newer smartNIC NVRAM versions the chip model should be read from the
PluDevice register as it provides the authoritative chip model/revision.
This method of reading the chip model is backwards compatible with
legacy NVRAM versions too.

Since the model number is purely used for reporting purposes, follow the
hardware team convention of subtracting 0x10 from the PluDevice register
to obtain the chip model/revision number.

Fixes: c7e9729da6b5 ("net/nfp: support CPP")
Cc: stable@dpdk.org

Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
Reviewed-by: Louis Peens <louis.peens@netronome.com>

show more ...