net/mana: fix uninitialized return value

in case we didn't enter or finished the loop without getting ifname we
ret shouldn't have an arbitrary value.

Coverity issue: 424690
Fixes: 84497839d9ca ("n

net/mana: fix uninitialized return value

in case we didn't enter or finished the loop without getting ifname we
ret shouldn't have an arbitrary value.

Coverity issue: 424690
Fixes: 84497839d9ca ("net/mana: support MTU update")
Cc: stable@dpdk.org

Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Reviewed-by: Long Li <longli@microsoft.com>

show more ...

net/mana: support VLAN tagging

For Tx path, use LONG_PACKET_FORMAT if VLAN tag is present.
For Rx, extract VLAN id from oob, put into mbuf and set the VLAN flags
in mbuf.

Signed-off-by: Wei Hu <weh

net/mana: support VLAN tagging

For Tx path, use LONG_PACKET_FORMAT if VLAN tag is present.
For Rx, extract VLAN id from oob, put into mbuf and set the VLAN flags
in mbuf.

Signed-off-by: Wei Hu <weh@microsoft.com>
Acked-by: Long Li <longli@microsoft.com>

show more ...

net/mana: start secondary process queues by default

Secondary processes are started after primary, and in most cases with
the device already started. Make them being able to process packets as
soon

net/mana: start secondary process queues by default

Secondary processes are started after primary, and in most cases with
the device already started. Make them being able to process packets as
soon as they start.

This also works with the case where the primary process decides to start
the device at a later time after secondary processes have started. The
application should guarantee not to send any packets before the device is
started.

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

drivers/net: return number of supported packet types

Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
Enhance code such that the dev_supported_ptypes_get()
function pointer now returns the

drivers/net: return number of supported packet types

Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
Enhance code such that the dev_supported_ptypes_get()
function pointer now returns the number of elements to
eliminate the need for "RTE_PTYPE_UNKNOWN" as the last item.

Same applied to 'buffer_split_supported_hdr_ptypes_get()' dev_ops too.

Signed-off-by: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

show more ...

net/mana: prevent values overflow returned from RDMA layer

The device capabilities reported from RDMA layer are in int. Those
values can overflow with the data types defined in dev_info_get().

Fix

net/mana: prevent values overflow returned from RDMA layer

The device capabilities reported from RDMA layer are in int. Those
values can overflow with the data types defined in dev_info_get().

Fix this by doing a upper bound before returning those values.

Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: stable@dpdk.org

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

drivers: use function to compare PCI addresses

Some places were not using the function rte_pci_addr_cmp()
to compare 2 PCI addresses.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by:

drivers: use function to compare PCI addresses

Some places were not using the function rte_pci_addr_cmp()
to compare 2 PCI addresses.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Long Li <longli@microsoft.com>

show more ...

net/mana: support MTU update

Add support for updating MTU for MANA. MTU is updated in kernel through
socket interface.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: use %m for fscanf to read MAC address

Use %m through fscanf to allocate mac dynamically is safer than using
mac[20], this guarantees there is no overflow on mac[].

Signed-off-by: Long Li

net/mana: use %m for fscanf to read MAC address

Use %m through fscanf to allocate mac dynamically is safer than using
mac[20], this guarantees there is no overflow on mac[].

Signed-off-by: Long Li <longli@microsoft.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

show more ...

net/mana: enable 32-bit build

Enable 32-bit build on x86 Linux. Fixed build warnings and errors
when building in 32-bit.

With this patch, mana will be able to build into 32-bit. However,
another pa

net/mana: enable 32-bit build

Enable 32-bit build on x86 Linux. Fixed build warnings and errors
when building in 32-bit.

With this patch, mana will be able to build into 32-bit. However,
another patch for mana short doorbell support is needed to make
mana fully functional for 32-bit applications.

Cc: stable@dpdk.org

Signed-off-by: Wei Hu <weh@microsoft.com>
Acked-by: Long Li <longli@microsoft.com>

show more ...

net/mana: return probing failure if no device found

When there is no device found on this PCI device, return probe failure
and release allocated resources for this PCI device.

Fixes: 517ed6e2d590 (

net/mana: return probing failure if no device found

When there is no device found on this PCI device, return probe failure
and release allocated resources for this PCI device.

Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: stable@dpdk.org

Signed-off-by: Long Li <longli@microsoft.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

show more ...

net/mana: optimize completion queue by batch processing

We can poll completion queues in a batch to speed up completion processing.
Also, the completion data doesn't need to be copied out of the har

net/mana: optimize completion queue by batch processing

We can poll completion queues in a batch to speed up completion processing.
Also, the completion data doesn't need to be copied out of the hardware
queue and they can be passed as pointers to be consumed by the RX/TX code.

Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: stable@dpdk.org

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

net/mana: fix stats counters

For per port counters and we should report summed values from all
queues.

Fixes: e350b56889bb ("net/mana: report queue statistics")
Cc: stable@dpdk.org

Signed-off-by:

net/mana: fix stats counters

For per port counters and we should report summed values from all
queues.

Fixes: e350b56889bb ("net/mana: report queue statistics")
Cc: stable@dpdk.org

Signed-off-by: Long Li <longli@microsoft.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

show more ...

net/mana: support Rx interrupts

mana can receive Rx interrupts from kernel through RDMA verbs interface.
Implement Rx interrupts in the driver.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: report queue statistics

Report packet statistics.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: start/stop device

Add support for starting/stopping the device.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: implement memory registration

MANA hardware has iommu built-in, that provides hardware safe access to
user memory through memory registration. Since memory registration is an
expensive ope

net/mana: implement memory registration

MANA hardware has iommu built-in, that provides hardware safe access to
user memory through memory registration. Since memory registration is an
expensive operation, this patch implements a two level memory registration
cache mechanisum for each queue and for each port.

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

net/mana: configure Tx queues

Tx hardware queue is allocated when starting the queue, this is for
pre configuration.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: configure Rx queues

Rx hardware queue is allocated when starting the queue. This function is
for queue configuration pre starting.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: configure RSS

Currently this PMD supports RSS configuration when the device is stopped.
Configuring RSS in running state will be supported in the future.

Signed-off-by: Long Li <longli@mi

net/mana: configure RSS

Currently this PMD supports RSS configuration when the device is stopped.
Configuring RSS in running state will be supported in the future.

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

net/mana: report device info

Add the function to get device info.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: support device removal interrupts

MANA supports PCI hot plug events. Add this interrupt to DPDK core so its
parent PMD can detect device removal during Azure servicing or live
migration.

net/mana: support device removal interrupts

MANA supports PCI hot plug events. Add this interrupt to DPDK core so its
parent PMD can detect device removal during Azure servicing or live
migration.

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

net/mana: support link update

The carrier state is managed by the Azure host. MANA runs as a VF and
always reports "up".

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: report supported packet types

Report supported protocol types.

Signed-off-by: Long Li <longli@microsoft.com>

net/mana: add device configuration and stop

MANA defines its memory allocation functions to override IB layer default
functions to allocate device queues. This patch adds the code for device
configu

net/mana: add device configuration and stop

MANA defines its memory allocation functions to override IB layer default
functions to allocate device queues. This patch adds the code for device
configuration and stop.

Signed-off-by: Long Li <longli@microsoft.com>

show more ...

net/mana: add basic driver with build environment

MANA is a PCI device. It uses IB verbs to access hardware through the
kernel RDMA layer. This patch introduces build environment and basic
device pr

net/mana: add basic driver with build environment

MANA is a PCI device. It uses IB verbs to access hardware through the
kernel RDMA layer. This patch introduces build environment and basic
device probe functions.

Signed-off-by: Long Li <longli@microsoft.com>

show more ...