Revision tags: v24.05, v24.09-pre, v24.05-rc1, LTS, v24.01, v24.05-pre, v24.01-rc1, v23.09, v24.01-pre, v23.09-rc1 |
|
#
ea941cae |
| 28-Jul-2023 |
Konrad Sztyber <konrad.sztyber@intel.com> |
test/unit: use spdk_ut_run_tests()
Replaced direct calls to the CUnit's functions to run the tests with spdk_ut_run_tests(). That way, each test will have the ability to run a specific test case.
test/unit: use spdk_ut_run_tests()
Replaced direct calls to the CUnit's functions to run the tests with spdk_ut_run_tests(). That way, each test will have the ability to run a specific test case.
The blob.c unit test wasn't changed, because it runs all tests multiple times with different parameter combinations, so it cannot be easily converted. In the future, each such combination could be split into a separate test suite, which would make it compatible with spdk_ut_run_tests().
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1d Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
#
ae431e31 |
| 28-Jul-2023 |
Konrad Sztyber <konrad.sztyber@intel.com> |
test/unit: move spdk_cunit.h to include/spdk_internal
It'll make it easier to include this file outside of unit tests.
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I171ddb864
test/unit: move spdk_cunit.h to include/spdk_internal
It'll make it easier to include this file outside of unit tests.
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I171ddb8649f67b5786f08647560e2907603d0574 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
show more ...
|
Revision tags: v23.05, v23.09-pre, v23.01.1, v23.01, v23.05-pre, v23.01-rc1, v22.01.2 |
|
#
a6dbe372 |
| 01-Nov-2022 |
paul luse <paul.e.luse@intel.com> |
update Intel copyright notices
per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices.
git log --follow -C90% --format=%ad --date defa
update Intel copyright notices
per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices.
git log --follow -C90% --format=%ad --date default <file> | tail -1
and then pull just the 4 digit year from the result.
Intel copyrights were not added to files where Intel either had no contribution ot the contribution lacked substance (ie license header updates, formatting changes, etc). Contribution date used "--follow -C95%" to get the most accurate date.
Note that several files in this patch didn't end the license/(c) block with a blank comment line so these were added as the vast majority of files do have this last blank line. Simply there for consistency.
Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Mellanox Build Bot
show more ...
|
Revision tags: v22.09, v23.01-pre, v22.09-rc1 |
|
#
475b86aa |
| 26-Aug-2022 |
Konrad Sztyber <konrad.sztyber@intel.com> |
print better errors when creating mempools from secondary process
Multiprocess is only supported by a few libraries (e.g. NVMe driver). Other libraries that don't support it will often fail on mempo
print better errors when creating mempools from secondary process
Multiprocess is only supported by a few libraries (e.g. NVMe driver). Other libraries that don't support it will often fail on mempool initialization when running as a secondary process, as the mempools are already created by the primary process. But the error messages are vague and don't indicate why this happened. So, this patch adds a check to see if a mempool exists after spdk_mempool_create() fails and prints an error message informing users that multiprocess is unsupported.
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I6f915a94266e64dda380e3b269424cc579372a10 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14234 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com>
show more ...
|
#
8dd1cd21 |
| 22-Jun-2022 |
Ben Walker <benjamin.walker@intel.com> |
check_format: For C files only, fix return type breaks
In SPDK, declarations have the return type on the same line. Definitions have the return type on a separate line. Astyle has an option for enfo
check_format: For C files only, fix return type breaks
In SPDK, declarations have the return type on the same line. Definitions have the return type on a separate line. Astyle has an option for enforcing this. Unfortunately, it seems to have two bugs:
1) It doesn't work correctly at all on C++ files. 2) It often fails on functions that return enums, or long type names
Deal with 1) by adjusting the check_format.sh script to only tell astyle to fix return type line breaks for C files and not C++. Deal with 2) by adding a few typedefs to work around the problem.
Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
show more ...
|
#
488570eb |
| 03-Jun-2022 |
Jim Harris <james.r.harris@intel.com> |
Replace most BSD 3-clause license text with SPDX identifier.
Many open source projects have moved to using SPDX identifiers to specify license information, reducing the amount of boilerplate code in
Replace most BSD 3-clause license text with SPDX identifier.
Many open source projects have moved to using SPDX identifiers to specify license information, reducing the amount of boilerplate code in every source file. This patch replaces the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause identifier.
Almost all of these files share the exact same license text, and this patch only modifies the files that contain the most common license text. There can be slight variations because the third clause contains company names - most say "Intel Corporation", but there are instances for Nvidia, Samsung, Eideticom and even "the copyright holder".
Used a bash script to automate replacement of the license text with SPDX identifier which is checked into scripts/spdx.sh.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: <qun.wan@intel.com>
show more ...
|
Revision tags: v22.05, v22.09-pre, v22.05-rc1, v22.01.1 |
|
#
ba8f1a9e |
| 31-Jan-2022 |
Alexey Marchuk <alexeymar@mellanox.com> |
blob: Add readv/writev ext ops to spdk_bs_dev
Introduce spdk_blob_ext_io_opts structure which is used in the new *_ext functions. Zeroes dev is updated with implementation of readv_ext which uses m
blob: Add readv/writev ext ops to spdk_bs_dev
Introduce spdk_blob_ext_io_opts structure which is used in the new *_ext functions. Zeroes dev is updated with implementation of readv_ext which uses memory domains memzero or regular memset().
Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com> Change-Id: Id94542196eff999827bf00591fd43804256fccb4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11369 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
show more ...
|
Revision tags: v22.01, v22.01-rc1, v21.10, v21.10-rc1, v21.07, v21.07-rc1 |
|
#
5fc0475c |
| 05-Jun-2021 |
Jiewei Ke <jiewei@smartx.com> |
thread: Make the definition of struct spdk_io_channel private
Move the definition of structure spdk_io_channel into lib/thread/thread_internal.h, so we don't have to update SO_VER for other librarie
thread: Make the definition of struct spdk_io_channel private
Move the definition of structure spdk_io_channel into lib/thread/thread_internal.h, so we don't have to update SO_VER for other libraries in future when we need to change the internal details on the structure.
Signed-off-by: Jiewei Ke <jiewei@smartx.com> Change-Id: I3d2ca7a8737972e0b33ce92e464da42c48f89dec Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8189 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
Revision tags: v21.04, v21.04-rc1 |
|
#
db35950a |
| 02-Apr-2021 |
Konrad Sztyber <konrad.sztyber@intel.com> |
mk/unit: link with trace library
Linking each unit test with spdk_trace allows for getting rid of lots of stub definitions for the trace functions. The behavior stays the same, as the trace calls r
mk/unit: link with trace library
Linking each unit test with spdk_trace allows for getting rid of lots of stub definitions for the trace functions. The behavior stays the same, as the trace calls result in no-op anyway because none of the unit test apps enable tracing.
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I904dac92205aadd644100af2c38989bb7979e47c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7231 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com>
show more ...
|
Revision tags: v21.01.1, v21.01, v21.01-rc1, v20.10, v20.10-rc1 |
|
#
b94d358a |
| 15-Oct-2020 |
Jim Harris <james.r.harris@intel.com> |
remove unneeded spdk_internal/thread.h includes
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I488d7c9441302847b170cd3b2a835ecad74cd031 Reviewed-on: https://review.spdk.io/gerrit/c
remove unneeded spdk_internal/thread.h includes
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I488d7c9441302847b170cd3b2a835ecad74cd031 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4718 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
show more ...
|
#
ceea3088 |
| 14-Oct-2020 |
Tomasz Zawadzki <tomasz.zawadzki@intel.com> |
lib/blobfs: remove legacy config support
This patch removes legacy config support in blobfs library. Mostly reverting patch: (97f3104) blobfs: Add conf parse for blobfs.
CacheBufferShift option in
lib/blobfs: remove legacy config support
This patch removes legacy config support in blobfs library. Mostly reverting patch: (97f3104) blobfs: Add conf parse for blobfs.
CacheBufferShift option in legacy config is not tested in CI, and never received corresponding RPC. If required the RPC can always be added later on.
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I54e39f069047a243b2186ae5ea225ed452180488 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4668 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
show more ...
|
Revision tags: v20.07, v20.07-rc1, v20.04.1, v20.01.2, v20.04, v20.04-rc1 |
|
#
87d5d832 |
| 10-Apr-2020 |
Changpeng Liu <changpeng.liu@intel.com> |
blobfs: refactor cache_free_buffers()
cache_free_buffers() was only used in the file deletion and unload, and the file is also freed after that, so here we combine the cache free and file free toget
blobfs: refactor cache_free_buffers()
cache_free_buffers() was only used in the file deletion and unload, and the file is also freed after that, so here we combine the cache free and file free together and do the cache free in the cache thread.
Change-Id: I57e9a27c9a6467bcf6c85cd277db3b57e06c98e5 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1795 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
#
c41c4c2b |
| 10-Apr-2020 |
Changpeng Liu <changpeng.liu@intel.com> |
blobfs: add the file with new cache buffer to cache list in cache thread
Also poll thread in the UT to cover the thread context switch.
Change-Id: I3dc765b66aa707c36eb3913b3e0d2c1c3986e282 Signed-o
blobfs: add the file with new cache buffer to cache list in cache thread
Also poll thread in the UT to cover the thread context switch.
Change-Id: I3dc765b66aa707c36eb3913b3e0d2c1c3986e282 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1793 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
#
e7ead00b |
| 03-Apr-2020 |
Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> |
lib/thread: Wait until thread_is_exited() is true by thread_poll() after thread_exit()
Following patches will require thread termination so that thread_exit() will move thread to exiting, thread_pol
lib/thread: Wait until thread_is_exited() is true by thread_poll() after thread_exit()
Following patches will require thread termination so that thread_exit() will move thread to exiting, thread_poll() will move thread from exiting to exited, thread_is_exited() will detect the threadis exited, and then call thread_destroy().
So change all places as a preparation.
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I6b2e8aee5ed7cd160a88b4c9aaed7d90bd9dac07 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1640 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
Revision tags: v20.01.1 |
|
#
dcf0ca15 |
| 11-Mar-2020 |
Vitaliy Mysak <vitaliy.mysak@intel.com> |
ut: make use of CUnit macro to reduce duplications
CUnit provides a helper macro CU_ADD_TEST() that simplifies usage of CU_add_test() function. Test name no longer needs to be provided, as it will b
ut: make use of CUnit macro to reduce duplications
CUnit provides a helper macro CU_ADD_TEST() that simplifies usage of CU_add_test() function. Test name no longer needs to be provided, as it will be inherited from function name.
This is a follow up to https://review.spdk.io/gerrit/c/spdk/spdk/+/931
Change-Id: I8078f02e08b14f12328ae022d7090ba13fbd64e4 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1239 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
show more ...
|
#
78b696bc |
| 11-Mar-2020 |
Vitaliy Mysak <vitaliy.mysak@intel.com> |
ut: simplify error handling at initialization
This patch changes the way that unittests initialize. The new way is shorter and simpler. It assumes that error during initialization is a fatal error,
ut: simplify error handling at initialization
This patch changes the way that unittests initialize. The new way is shorter and simpler. It assumes that error during initialization is a fatal error, but in our cases it always is.
This patch is a followp up to https://review.spdk.io/gerrit/c/spdk/spdk/+/930
lvol_ut.c is the only test that skipped because it runs same tests multiple times which is not allowed by new method.
Change-Id: I0baf7ad09a35d5fca2dc4a03b4453c12c14f38a7 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1238 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
show more ...
|
#
1914de09 |
| 18-Feb-2020 |
Changpeng Liu <changpeng.liu@intel.com> |
blobfs: start a poller to do cache buffer reclaim regularly
Currently we will free the cache buffers in the file R/W data path, however we can start a thread to do the cache buffer reclaim regulary,
blobfs: start a poller to do cache buffer reclaim regularly
Currently we will free the cache buffers in the file R/W data path, however we can start a thread to do the cache buffer reclaim regulary, so that we don't need to free the cache buffer in the Rocksdb thread context. By doing this, we can also remove the global cache buffer lock in following patches.
Change-Id: Icb0fbc49baecd1e9d86a5fcfe400758dfc3c53a2 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/941 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
Revision tags: v20.01, v20.01-rc1, v19.10.1, v19.10, v19.10-rc1, v19.07.1 |
|
#
678c0261 |
| 05-Aug-2019 |
Changpeng Liu <changpeng.liu@intel.com> |
UT/blobfs: add a append write over blob boundary UT
Change-Id: Ifc50920ae316ba76719c14d40615a23930457fc8 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.
UT/blobfs: add a append write over blob boundary UT
Change-Id: Ifc50920ae316ba76719c14d40615a23930457fc8 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/464083 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
Revision tags: v19.07, v19.04.1 |
|
#
9c48768a |
| 03-Jun-2019 |
Ziye Yang <ziye.yang@intel.com> |
ut/blobfs: fix blobfs_sync_ut hang issue when testing file_length
we use this statement: while (g_file->length_flushed != buf_length) {} in file_length function.
It means that in this test case, le
ut/blobfs: fix blobfs_sync_ut hang issue when testing file_length
we use this statement: while (g_file->length_flushed != buf_length) {} in file_length function.
It means that in this test case, length_flushed are accessed by two different threads, so better to use another new variable length_flused with volatile before the variable definition. Then our ut will not hang.
Change-Id: I6152a4ba3f27f0fad1c8c2baa71324a36a2fb9e8 Signed-off-by: Ziye Yang <ziye.yang@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/456580 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
#
cdd089a8 |
| 24-May-2019 |
Jim Harris <james.r.harris@intel.com> |
blobfs: don't flush a partial buffer with no sync pending
We flush a cache buffer once it's filled. When the write for that cache buffer has completed, we look to see if there's more data to flush.
blobfs: don't flush a partial buffer with no sync pending
We flush a cache buffer once it's filled. When the write for that cache buffer has completed, we look to see if there's more data to flush. Currently if there's *any* more data to flush, we will flush it, even if it's not a full buffer.
That can hurt performance though. Ideally we only want to flush a partial buffer if there's been an explicit sync operation that requires that partial buffer to be flushed. Otherwise we will end up writing the partial buffer to disk, and then come back and write that data again later when the buffer is full.
Add a new unit test to test for this condition. This patch breaks one of the existing unit tests which was designed specifically around a RocksDB failure condition. Change that file_length unit test to now write exactly one CACHE_BUFFER, which still tests the general logic making sure that we don't confuse the amount of data flushed with the value written to the file's length xattr.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I83795fb45afe854b38648d0e0c1a7928219307a2
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455698 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
show more ...
|
#
e967dcd2 |
| 24-May-2019 |
Jim Harris <james.r.harris@intel.com> |
blobfs: ensure length xattr is written even if all data is flushed
Data can get implicitly flushed as cache buffers are filled. But the length xattr is only written in response to a sync or close o
blobfs: ensure length xattr is written even if all data is flushed
Data can get implicitly flushed as cache buffers are filled. But the length xattr is only written in response to a sync or close operation. So we cannot just look at the amount of data flushed, and ignore the sync operation if all of the data written has been flushed - we still need to write the length xattr.
This also adds a unit test which reproduces the original problem.
Fixes issue #297.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Icca6ef4d1544f72e9bc31c4ee77d26b4b7f0cce4
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455692 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
show more ...
|
#
98ef63aa |
| 21-May-2019 |
Changpeng Liu <changpeng.liu@intel.com> |
UT/blobfs: add rename UT to blobfs_sync_ut
Change-Id: I17c34a02cbffce4078ef82cfc191394a7440ba52 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk
UT/blobfs: add rename UT to blobfs_sync_ut
Change-Id: I17c34a02cbffce4078ef82cfc191394a7440ba52 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455151 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
#
6ff6a270 |
| 21-May-2019 |
Changpeng Liu <changpeng.liu@intel.com> |
UT/blobfs: add data verification test to blobfs_sync_ut
Change-Id: If61ea8fcc96b02e9b6af9c2bb5bc703d4e2f46bf Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrit
UT/blobfs: add data verification test to blobfs_sync_ut
Change-Id: If61ea8fcc96b02e9b6af9c2bb5bc703d4e2f46bf Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455145 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
#
e036215f |
| 21-May-2019 |
Ben Walker <benjamin.walker@intel.com> |
thread: Add a mechanism to exit a lightweight thread
Lightweight threads may now be exited by calling spdk_thread_exit() within the thread. The framework polling the thread can release the resources
thread: Add a mechanism to exit a lightweight thread
Lightweight threads may now be exited by calling spdk_thread_exit() within the thread. The framework polling the thread can release the resources associated with that lightweight thread by calling spdk_thread_destroy().
Change-Id: I6586b9d22556b3874fb113ce5402c6b1f371786e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455319 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
show more ...
|
#
78326e72 |
| 02-May-2019 |
Darek Stojaczyk <dariusz.stojaczyk@intel.com> |
blobfs: remove trace short names
They were removed from the trace API and BlobFS doesn't compile right now.
Change-Id: Ie98339f19353e4db901af551c706f57c18b89fc5 Signed-off-by: Darek Stojaczyk <dari
blobfs: remove trace short names
They were removed from the trace API and BlobFS doesn't compile right now.
Change-Id: Ie98339f19353e4db901af551c706f57c18b89fc5 Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/452863 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|