test/nvmf: try to make reactors more busy in interrupt test

This test verifies that reactors are idle when there's no IO and that
they're idle when handling IO. The latter check can be a problem,
b

test/nvmf: try to make reactors more busy in interrupt test

This test verifies that reactors are idle when there's no IO and that
they're idle when handling IO. The latter check can be a problem,
because the business of a core when handling IOs varies and can never
reach the threshold that we use to consider a core to be busy.

To make that second check more reliable, let's do a couple of things:
increase queue depth to 256 and decrease busy threshold to 30. Also,
while here, use double parenthesis for arithmetic comparisons.

Fixes: #3520

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2937b46471d523bb496e7b3878f43c541047adaf
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24827
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test: make reactor_is_busy_or_idle() less restrictive

Extensive interrupt mode testing shows that reactor CPU load as reported
by the top in reactor_is_busy_or_idle during traffic fluctuates between

test: make reactor_is_busy_or_idle() less restrictive

Extensive interrupt mode testing shows that reactor CPU load as reported
by the top in reactor_is_busy_or_idle during traffic fluctuates between
50 and 80%, 66.7% is reported quite often. With 10s time slot it happens
that all readings are 66.7% or less.
To avoid false positives in CI and not make the test any longer than it
already is lower the arbitrary chosen value o 70% to 65% as an
indication that the CPU is indeed busy.

Change-Id: I4946ab2fc0b0704ef6e3d6905cfcae6331e8ec9c
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24596
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test: split interrupt_common.sh

This allows for reuse of truly common part of this file in upcoming
commit that introduce NVMe-of TCP interrupt mode support.

Change-Id: If28935aa21d71a9e97d89517206

test: split interrupt_common.sh

This allows for reuse of truly common part of this file in upcoming
commit that introduce NVMe-of TCP interrupt mode support.

Change-Id: If28935aa21d71a9e97d89517206c0a4f12dc21eb
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22835
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Boris Glimcher <Boris.Glimcher@emc.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test: wait_for_examine and delay in reap_unregistered_poller.sh

We need to give the thread library some time to reap
the unregistered poller - it is a bit of a delayed
process. We have to wait for

test: wait_for_examine and delay in reap_unregistered_poller.sh

We need to give the thread library some time to reap
the unregistered poller - it is a bit of a delayed
process. We have to wait for examine to finish on
the aio bdev, then the poll group gets destroyed and
the pollers unregistered. This marks the pollers as
UNREGISTERED, but they aren't actually reaped until
next time the thread is polled.

Fixes issue #2980.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I1e32c50ea9b28ea2d5560ddc9b2f68fa81e708d9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17575
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Mike Gerdts <mgerdts@nvidia.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

Add SPDX header to various files

They were missed by the initial set of patches which introduced this
header as a mandatory one across different types of files.

Signed-off-by: Michal Berger <michal

Add SPDX header to various files

They were missed by the initial set of patches which introduced this
header as a mandatory one across different types of files.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I3f9b37d41298c843e1648e72fe8593768ccd37e0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15423
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

add (c) and SPDX header to bash files as needed

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --forma

add (c) and SPDX header to bash files as needed

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc)

For intel copyrights added, --follow and -C95% were used.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I2ef86976095b88a9bf5b1003e59f3943cd6bbe4c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15209
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

SC2048: Use "${array[@]}" (with quotes) to prevent whitespace problems.

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Change-Id: I64473e4904c82fa06d41e8a02d56070ebf966adc
Review

SC2048: Use "${array[@]}" (with quotes) to prevent whitespace problems.

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Change-Id: I64473e4904c82fa06d41e8a02d56070ebf966adc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15559
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>

show more ...