lib/fsdev: mount and umount API introduced

This patch introduces SPDK fsdev spdk_fsdev_mount and spdk_fsdev_umount
APIs, the SPDK fsdev analogues of FUSE_INIT and FUSE_DESTROY.

The corresponding fs

lib/fsdev: mount and umount API introduced

This patch introduces SPDK fsdev spdk_fsdev_mount and spdk_fsdev_umount
APIs, the SPDK fsdev analogues of FUSE_INIT and FUSE_DESTROY.

The corresponding fsdev module handlers are optional (as any other),
however failing the INIT handler will fail the FUSE_INIT and therefore
the host's mount.

The spdk_fsdev_open() API doesn't get the open_opts parameter anymore.
It became mount_opts now.

Change-Id: I316a31f6999b9fabe6cee51c87fdd0e6e49ed569
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25009
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

module/fsdev/aio: fsdev_aio_negotiate_opts moved

Code preparation. Trivial: fsdev_aio_negotiate_opts moved.

Change-Id: Iaa0ac0457d043fac054ce485ed3dbbb7e7b74d65
Signed-off-by: Anton Nayshtut <anays

module/fsdev/aio: fsdev_aio_negotiate_opts moved

Code preparation. Trivial: fsdev_aio_negotiate_opts moved.

Change-Id: Iaa0ac0457d043fac054ce485ed3dbbb7e7b74d65
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25203
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

module/fsdev/aio: fsdev_free_leafs moved

Code preparation. Trivial: fsdev_free_leafs moved.

Change-Id: I7324d414d64f4d6b17c339f51bc71614f0197bd0
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>

module/fsdev/aio: fsdev_free_leafs moved

Code preparation. Trivial: fsdev_free_leafs moved.

Change-Id: I7324d414d64f4d6b17c339f51bc71614f0197bd0
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25202
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

fsdev/aio: aio_io_poll: correct return value

Change-Id: If2f0640a3d81f6a117d967c1c22aa028a85fd9e2
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/sp

fsdev/aio: aio_io_poll: correct return value

Change-Id: If2f0640a3d81f6a117d967c1c22aa028a85fd9e2
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25156
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

fsdev/aio: add support for null IOs

This patch adds support for null IOs in the AIO fsdev by introducing
a new RPC flag (--enable-skip-rw) during fsdev creation.

When enabled, the AIO fsdev will sk

fsdev/aio: add support for null IOs

This patch adds support for null IOs in the AIO fsdev by introducing
a new RPC flag (--enable-skip-rw) during fsdev creation.

When enabled, the AIO fsdev will skip read/write operations, similar
to how the null bdev operates in the bdev module.

This feature facilitates performance testing across the entire stack
without actual data read/write operations. Implementing this within
the fsdev/aio module, rather than creating a separate fsdev/null module,
avoids unnecessary code duplication and keeps the AIO fsdev focused as a
comprehensive example demonstrating various features, including null IO
capability.

Change-Id: Id7e84711628f23e6faa9128f9e428f759e0032c9
Signed-off-by: Yoray Zack <yorayz@nvidia.com>
Signed-off-by: Vishwanath Venkatesan <vvenkatesan@nvidia.com>
Signed-off-by: Ben Walker <ben@nvidia.com>
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24563
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

module/fsdev/aio: unused dep removed

Fixes #3529

Change-Id: I3a1406f7f12cad421e767e444a6ee7ba5158c1b9
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit

module/fsdev/aio: unused dep removed

Fixes #3529

Change-Id: I3a1406f7f12cad421e767e444a6ee7ba5158c1b9
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24945
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

module/fsdev/aio: fixed couple of errors

Fixed issues detected by Coverity.
1) close(fd) could be called for already closed fd. Now it is not
possible
2) A file descriptor was checked instead of f

module/fsdev/aio: fixed couple of errors

Fixed issues detected by Coverity.
1) close(fd) could be called for already closed fd. Now it is not
possible
2) A file descriptor was checked instead of fhandle that was
returned from file_handle_create(fobject, fd)
3) A fsdev_io was checked instead of fsdev_io->u_in.symlink.target
when checking if strdup() succeeded

Change-Id: Ic679629bb6a6e63f4a087c826ed3ec73fe57bdb7
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24646
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

module/fsdev/aio: fixed 'use after free' error

Fixed issues detected by Coverity.

The file_handle_delete(fhandle) function, which frees memory
pointed by 'fhandle', was called before the 'fhandle'

module/fsdev/aio: fixed 'use after free' error

Fixed issues detected by Coverity.

The file_handle_delete(fhandle) function, which frees memory
pointed by 'fhandle', was called before the 'fhandle' was
printed by SPDK_DEBUGLOG(). This caused that Coverity scan
detected 'use after free' error. Now file_handle_delete(fhandle)
is called after the pointer value is printed, so this shall
remove the error. Changing the order of calls will not change
anything in this case, but shall keep the Coverity happy.

BTW, printing the pointer value after the memory pointed by it
is freed shall be harmless, but let's keep the code clean and try
to avoid future error/warnings generated by scan tools.

Change-Id: Ie0c407befe77984704bf7d3533271297d70bf259
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24632
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot

show more ...

fsdev/aio: Add aio fsdev implementation

Change-Id: I5add43886241803eb3a65d64beae58ddd91d335d
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/sp

fsdev/aio: Add aio fsdev implementation

Change-Id: I5add43886241803eb3a65d64beae58ddd91d335d
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22534
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...