bdev/malloc: Support accel sequence when DIF is enabled

malloc bdev module did not support accel sequence if DIF was enabled.
Remove the limitation by utilizing spdk_bdev_io_hide_metadata().

If DIF

bdev/malloc: Support accel sequence when DIF is enabled

malloc bdev module did not support accel sequence if DIF was enabled.
Remove the limitation by utilizing spdk_bdev_io_hide_metadata().

If DIF insert/strip is done by accel sequence, it is not possible to
verify DIF of I/O buffer. Hence, verify DIF of malloc buffer instead.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Idb088b6fc3cc045028c33649c84218c708fd601b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25326
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/malloc: Extract internal of verify_pi() for code reuse

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib4f3f9e038d824ac5a8e4c65a2cff1a3e365a432
Reviewed-on: https://review.s

bdev/malloc: Extract internal of verify_pi() for code reuse

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib4f3f9e038d824ac5a8e4c65a2cff1a3e365a432
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25418
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

bdev/malloc: malloc_done() uses switch-case for clean up

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ibe8956b54ec5d2bf50f5261f04d0f61a783a5cc2
Reviewed-on: https://review.spdk

bdev/malloc: malloc_done() uses switch-case for clean up

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ibe8956b54ec5d2bf50f5261f04d0f61a783a5cc2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22988
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

bdev/malloc: Fix unexpected DIF verification error for initial read

The patch
https://github.com/spdk/spdk/commit/e1f15ba5418b38056fdb6d67186075aa1fada9e7
set reference tag to 0xFFFFFFFF and set app

bdev/malloc: Fix unexpected DIF verification error for initial read

The patch
https://github.com/spdk/spdk/commit/e1f15ba5418b38056fdb6d67186075aa1fada9e7
set reference tag to 0xFFFFFFFF and set application tag to 0xFFFF.

However, these are actually written to DIF fields only if their checks
are enabled. Usually, reference tag check is enabled but application tag
check is disabled.

For DIF type 1 or 2, DIF check is disabled only if application tag is
0xFFFF.

Hence, the value of 0xFFFFFFFF in the reference tag caused verification
error for any read.

The previous patch fixed DIF library to set application tag to 0 if its
check is disabled.
This patch fixes another problem, to set application tag to 0xFFFF as
source code comment says even if application tag check is disabled.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I1d444eb6cc6de2e36abc7b0b85364c11dbe1df67
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25324
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

bdev/malloc: Make DIF PI format configurable at bdev creation

Make bdev's PI format configurable via the bdev_malloc_create RPC.
The PI format check is done by spdk_dif_ctx_init() as same as other
p

bdev/malloc: Make DIF PI format configurable at bdev creation

Make bdev's PI format configurable via the bdev_malloc_create RPC.
The PI format check is done by spdk_dif_ctx_init() as same as other
parameters.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I28afca948916e36987d82e86f1a343203b83127d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24108
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/malloc Add missing DIF parameters into write_json_config()

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I2dbb47e249ba261ea7c51cd07e28ff4e02a5636a
Reviewed-on: https://revi

bdev/malloc Add missing DIF parameters into write_json_config()

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I2dbb47e249ba261ea7c51cd07e28ff4e02a5636a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24206
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/malloc: Delegate DIF config check to spdk_dif_ctx_init()

spdk_dif_ctx_init() now has all necessary checks for DIF configuration.
The following patches will make the PI format configurable. Then

bdev/malloc: Delegate DIF config check to spdk_dif_ctx_init()

spdk_dif_ctx_init() now has all necessary checks for DIF configuration.
The following patches will make the PI format configurable. Then, we
will be able to delegate the PI format check to spdk_dif_ctx_init() too.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I6d3328d51dd4fc478edc3b041a2b24b82969e7e2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24205
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

module/bdev: Initialize bdev->dif_pi_format

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I5393205a7a29eca2577b4c0772ec08526fd8a8c0
Reviewed-on: https://review.spdk.io/gerrit/c/

module/bdev: Initialize bdev->dif_pi_format

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I5393205a7a29eca2577b4c0772ec08526fd8a8c0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23626
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22950
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/malloc: Enable DIF check flags per-IO override

Enable DIF check flags per-IO override for read requests.

Change-Id: I8814134e0f88be7997220d80faaacd7138953ece
Signed-off-by: Slawomir Ptak <slaw

bdev/malloc: Enable DIF check flags per-IO override

Enable DIF check flags per-IO override for read requests.

Change-Id: I8814134e0f88be7997220d80faaacd7138953ece
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21482
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/malloc: improve debug log for writes

Wrote suggest operation was completed whereas it is not yet finished
in the place the message is logged.

Change-Id: I4238c89d256d284000d057f0d99a95513f0470

bdev/malloc: improve debug log for writes

Wrote suggest operation was completed whereas it is not yet finished
in the place the message is logged.

Change-Id: I4238c89d256d284000d057f0d99a95513f047086
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21928
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/malloc: fix reads with separate metadata buffers

If the bdev was configured to use a separate buffers for metadata and
the user submitted a read with buffers=NULL, the metadata pointer would
no

bdev/malloc: fix reads with separate metadata buffers

If the bdev was configured to use a separate buffers for metadata and
the user submitted a read with buffers=NULL, the metadata pointer would
not get set.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: If19d5450edba7caf144a5795913212d8e0af682d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21858
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>

show more ...

bdev/malloc: add helpers for getting separate metadata

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia727dadf09aabbdfed4c32efb3e861300cf7c155
Reviewed-on: https://review.spdk.

bdev/malloc: add helpers for getting separate metadata

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia727dadf09aabbdfed4c32efb3e861300cf7c155
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21857
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>

show more ...

bdev/malloc: don't do verify when separate metadata buffer is null

The `bdev_gpt` module will examine Malloc device without passing separate
metadata buffer, then the Malloc driver will report error

bdev/malloc: don't do verify when separate metadata buffer is null

The `bdev_gpt` module will examine Malloc device without passing separate
metadata buffer, then the Malloc driver will report error logs for
Malloc device created with separate metadata, here we skip doing verify
if the input metadata buffer is NULL.

Fix #3191.

Change-Id: Ia6a160dca238534a7b534f05e0646123c7870d1e
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20632
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/malloc: generate Protection Information for deallocated ranges

Malloc bdev will zeroout all data buffer include the metadata after
UNMAP and WRITE ZEROES, but for the protection information we

bdev/malloc: generate Protection Information for deallocated ranges

Malloc bdev will zeroout all data buffer include the metadata after
UNMAP and WRITE ZEROES, but for the protection information we should
fill `SPDK_DIF_APPTAG_IGNORE` and `SPDK_DIF_REFTAG_IGNORE` for
Application Tag and Reference Tag in protection information.

Here, after UNMAP and WRITE ZEORES done, we fill the protection
information fields with above values, then when reading to the
deallocated ranges, the verify API will skip checking the
protection information.

Fix issue #3156.

Change-Id: I403a1c7f5da54146db6e760081d93f6346b0b2d7
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20493
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

lib, module: use spdk_json_write_named_uuid

Use spdk_json_write_named_uuid everywhere possible, instead of the older
spdk_uuid_fmt_lower+spdk_json_write_named_string approach.

Signed-off-by: Jim Ha

lib, module: use spdk_json_write_named_uuid

Use spdk_json_write_named_uuid everywhere possible, instead of the older
spdk_uuid_fmt_lower+spdk_json_write_named_string approach.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I75f97efb6e88fdb032f7ae94f11039457ba70f2a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20562
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

dif: remove packed attribute from spdk_dif_ctx_init_ext_opts

Following the recommendation introduced in 1d77eec82, the packed
attribute was removed from spdk_dif_ctx_init_ext_opts and the way its
si

dif: remove packed attribute from spdk_dif_ctx_init_ext_opts

Following the recommendation introduced in 1d77eec82, the packed
attribute was removed from spdk_dif_ctx_init_ext_opts and the way its
size is calculated was changed to use SPDK_SIZEOF().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I8dab3ee5afcd2afe803dacc563bee9b029c7cbf6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18597
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

lib/util/dif: Wrappers for DIF fields access

Introduced wrappers for the DIF structure
fields access, in order to prepare for
extending the DIF structure with
additional formats.

Change-Id: I5592f5

lib/util/dif: Wrappers for DIF fields access

Introduced wrappers for the DIF structure
fields access, in order to prepare for
extending the DIF structure with
additional formats.

Change-Id: I5592f59d05a4bfecbfb88a5fad2815a38d965ea0
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18174
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The first
extended parameter is the DIF Protection Information
format (CRC-16).

Change-Id: I6a32e8570676265d757fc7251441e5547bbb475d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18146
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

util/uuid: add API to test/set null uuid

Refactor the code to use these new functions.

Change-Id: I21ee7e9a96f30fbd60106add5e8b071e86bf93c9
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel

util/uuid: add API to test/set null uuid

Refactor the code to use these new functions.

Change-Id: I21ee7e9a96f30fbd60106add5e8b071e86bf93c9
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16156
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/malloc: report accel sequence support

This actually allows malloc bdev to chain multiple accel operations
together. And, since the last operation will always be a copy, accel
should remove tha

bdev/malloc: report accel sequence support

This actually allows malloc bdev to chain multiple accel operations
together. And, since the last operation will always be a copy, accel
should remove that copy by modifying previous operation's dst/src.

On my system, it improved bdevperf performance (single core, qd=4,
bs=128k, bdev_crypto on top of bdev_malloc, crypto_sw):

randread: 5668M/s -> 8201M/s
randwrite: 5148M/s -> 7856M/s

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5b9173fa70a42ee56f56c496a34037d46d2f420f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17202
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/malloc: report memory domain support

Because the copying is handled by accel, which will do push/pull when
necessary, we can report support for each registered memory domain.

Also, since verif

bdev/malloc: report memory domain support

Because the copying is handled by accel, which will do push/pull when
necessary, we can report support for each registered memory domain.

Also, since verifying PI information would require doing a push/pull, we
don't report support for memory domains if bdev has DIF enabled.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id80f82aaac68e9dec2a6cae81d96a460105161d6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17201
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

bdev/malloc: use appends for write requests

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ief6c873a5f65274a25b67bc3f2811d8f3e4a33b3
Reviewed-on: https://review.spdk.io/gerrit/c

bdev/malloc: use appends for write requests

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ief6c873a5f65274a25b67bc3f2811d8f3e4a33b3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17200
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

bdev/malloc: pass bdev_io to bdev_malloc_writev()

Same reason for the change as in bdev_malloc_readv().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id52d8639df6a488342346283

bdev/malloc: pass bdev_io to bdev_malloc_writev()

Same reason for the change as in bdev_malloc_readv().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id52d8639df6a488342346283c90f12a2ba6f5736
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17199
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

bdev/malloc: use appends for read requests

This only changes the interface bdev_malloc uses for scheduling the copy
to appends, but it won't chain those copies to an existing sequence, as
bdev_mallo

bdev/malloc: use appends for read requests

This only changes the interface bdev_malloc uses for scheduling the copy
to appends, but it won't chain those copies to an existing sequence, as
bdev_malloc doesn't report support for accel sequences yet. That will
be changed in one of the subsequent patches.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I6db2c79b15cb96a1b07c6cf5514004c76b9d2e92
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17198
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...