accel/error: fix callback type for tasks in a sequence

Tasks which are part of a sequence use step_cb_fn instead of cb_fn, so
we have to override the correct field and use a correct callback type.

accel/error: fix callback type for tasks in a sequence

Tasks which are part of a sequence use step_cb_fn instead of cb_fn, so
we have to override the correct field and use a correct callback type.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ie4588e5c7fcdab6d33aaa2c848726cf7bd3b1644
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25285
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel/error: don't submit tasks intended to fail

There's no point in executing a task if it's going to be reported as
failed. Instead, such tasks are kept on a list and are completed in
poller.

Si

accel/error: don't submit tasks intended to fail

There's no point in executing a task if it's going to be reported as
failed. Instead, such tasks are kept on a list and are completed in
poller.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ifbd296d3524ce1c9ba112b4c7d8a383f52cc91cf
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25284
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

accel/error: move interval check to a function

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I1595ffbd884d78f3568a3e09b95d593af38226c4
Reviewed-on: https://review.spdk.io/gerri

accel/error: move interval check to a function

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I1595ffbd884d78f3568a3e09b95d593af38226c4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25283
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

accel/error: check interval before submission

It's prep for the next patch which will make it so that tasks with
FAILURE errors injected aren't submitted to the accel_sw module.

Signed-off-by: Konr

accel/error: check interval before submission

It's prep for the next patch which will make it so that tasks with
FAILURE errors injected aren't submitted to the accel_sw module.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ice504f857d62391eec3a6d880a956b24cfccb442
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25282
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

lib/accel: fallback when no devices during module_init()

Related to #3266

During discussion in issue above, it came up that if
dpdk_compressdev and dpdk_cryptodev detects no devices
they are still

lib/accel: fallback when no devices during module_init()

Related to #3266

During discussion in issue above, it came up that if
dpdk_compressdev and dpdk_cryptodev detects no devices
they are still assigned to the relevant accel ops.

Rather than explicitly failing just due to lack of
the devices, each accel module can report -ENODEV.
In such case the module will not be used, but that
error is not propagated to accel framework init.

As a result accel ops assignment will not use such module,
and fallback to available modules.

Reported-by: liuqinfei <lucas.liuqinfei@huawei.com>
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ib52dfcb6dc6a1a93b8493b98ffb028f9d9419d6d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22026
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel/error: add an option to specify injection interval

With this option, an error is only injected after executing a number of
operations specified by its value.

Signed-off-by: Konrad Sztyber <ko

accel/error: add an option to specify injection interval

With this option, an error is only injected after executing a number of
operations specified by its value.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I02c3f7d8685222d43d34fa59005327ef5467c8ce
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20442
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

accel/error: add an option to inject failures

In this mode, the error module will complete the tasks with an status
defined by the user simulating an error during operation execution.

Signed-off-by

accel/error: add an option to inject failures

In this mode, the error module will complete the tasks with an status
defined by the user simulating an error during operation execution.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I30e1da33d6e1e1ccc37b8b6382977333643bdd36
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20441
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

accel/error: add support for crc32c

It is now possible to corrupt the result of crc32c operations.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5ac8779aff605debabdc549e23b5d

accel/error: add support for crc32c

It is now possible to corrupt the result of crc32c operations.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5ac8779aff605debabdc549e23b5d8ae2d883b0a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20440
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

accel/error: add support for write_config_json

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I838fffd89a6302eb09850b697b10a04feac088db
Reviewed-on: https://review.spdk.io/gerri

accel/error: add support for write_config_json

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I838fffd89a6302eb09850b697b10a04feac088db
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20439
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel/error: add accel_error_inject RPC

This RPC will allow users to configure error injections for a given
operation. To disable error injection, either type=disable or count=0
needs be specified.

accel/error: add accel_error_inject RPC

This RPC will allow users to configure error injections for a given
operation. To disable error injection, either type=disable or count=0
needs be specified.

Of course, in order for the error injection to actually take place, the
error module needs to be assigned to a given operation via
spdk_accel_assign_opc().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4935adf305eb202d8db89ac07743ff321bab8df2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20438
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel: add error module

This module will allow users to inject errors to selected accel
operations, similarly to how bdev_error allows user to inject errors on
the bdev layer.

Since the errors won'

accel: add error module

This module will allow users to inject errors to selected accel
operations, similarly to how bdev_error allows user to inject errors on
the bdev layer.

Since the errors won't necessarily be injected to each submitted
operation, the module needs to be able to actually execute some of them
correctly. To avoid duplicating the code, it forwards the execution of
the tasks to the software module.

This patch only defines the basic module structures, but doesn't inject
any errors. That will be done in the following patches.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I708e2429cf7ce5373beaf991ccd0be8fc45b9fc0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20436
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...