util: add method for setting fd_group's wrapper

A wrapper is a function that is executed when an event is triggered
prior to executing the callback associated with that event. It can be
used to per

util: add method for setting fd_group's wrapper

A wrapper is a function that is executed when an event is triggered
prior to executing the callback associated with that event. It can be
used to perform tasks common to all fds in an fd_group, without having
to control the code that adds the fds.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia6e29d430dad220497aa2858529662a3934c6c52
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25464
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

util: multi-level fd_group nesting

This patch adds the ability to nest multiple fd_groups into one another.
This builds a tree with fds from all fd_groups being registered at root
fd_group's epfd. F

util: multi-level fd_group nesting

This patch adds the ability to nest multiple fd_groups into one another.
This builds a tree with fds from all fd_groups being registered at root
fd_group's epfd. For instance, in the following configuration:

fgrp0
|
fgrp1----+----fgrp2
|
fgrp3

fds from all fd_groups will be registered to epfd of fgrp0. After
unnesting fgrp1, fgrp1 and fgrp3 fds will be removed from frgp0's epfd
and added to fgrp1 epfd.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4f586c21fe3db1739bf2010578b20606c53e5e84
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25463
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

util: keep track of nested child fd_groups

We'll need this information in the next patch, which will allow for
multi level nesting.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-I

util: keep track of nested child fd_groups

We'll need this information in the next patch, which will allow for
multi level nesting.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I1c11b35d96d7926ff176ffd577db6b08aec2323a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25462
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

dif: Add spdk_dif_pi_format_get_size() to use for NVMe PRACT

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I991e419645f269a614fad44e3b02939c68767250
Reviewed-on: https://review.

dif: Add spdk_dif_pi_format_get_size() to use for NVMe PRACT

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I991e419645f269a614fad44e3b02939c68767250
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25436
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

dif: Set DIF field to 0 explicitly if its check is disabled

Each DIF generation/verification function has two modes, non-split and
split. For split mode, DIF fields are copied. However, for non-spli

dif: Set DIF field to 0 explicitly if its check is disabled

Each DIF generation/verification function has two modes, non-split and
split. For split mode, DIF fields are copied. However, for non-split
mode, DIF fields are updated directly. If check is disabled, the DIF
field is not touched for non-split case.

This is inconsistent.

Not only inconsistency but also this caused a real problem for the
malloc bdev module.

The patch
https://github.com/spdk/spdk/commit/e1f15ba5418b38056fdb6d67186075aa1fada9e7
caused the problem.

When malloc bdev is created, its reference tags are initialized to
0xFFFFFFFF. This means reference tag should be ignored. However, this
makes sense only if application tags are initialized to 0xFFFF for DIF
type 1. However, in SPDK, usually application tag check is disabled.
If application tag is not 0xFFFF, verification always detects reference
tag error.

Hence, in the following patches, we will change the malloc bdev module
to set application tags to 0xFFFF by enabling check only at disk
creation.

However, after that, we have no way to enable DIF check if application
tag check is not enabled.

If any valid meaningfull value is written to guard tag or reference tag,
DIF check should not be disabled.

This patch can resolve the problem.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ic21cd7c1c4d082f431382f561167cf7d75808008
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25323
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

dif: dif_generate/verify_copy() supports NVMe PRACT = 1 and MD size > PI size

In the NVMe spec, if PRACT is 1 and metadata size is larger than
PI size, PI is just overwritten for write and PI is jus

dif: dif_generate/verify_copy() supports NVMe PRACT = 1 and MD size > PI size

In the NVMe spec, if PRACT is 1 and metadata size is larger than
PI size, PI is just overwritten for write and PI is just verified for
read. spdk_dif_generate_copy() and spdk_dif_verify_copy() simulate this
behavior.

Update unit test cases for verification.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I0e26a0c2675af416d9d181e3cb4ecb084939c6a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23688
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

dif: Add SPDK_DIF_FLAGS_NVME_PRACT for dif_generate/verify_copy()

Add a macro constant SPDK_DIF_FLAGS_NVME_PRACT which is the same value
as the PRACT bit in the NVMe specification.

spdk_dif_generat

dif: Add SPDK_DIF_FLAGS_NVME_PRACT for dif_generate/verify_copy()

Add a macro constant SPDK_DIF_FLAGS_NVME_PRACT which is the same value
as the PRACT bit in the NVMe specification.

spdk_dif_generate/verify_copy() works if NVME_PRACT is not set or
metadata size is equal with PI size, or return -ENOTSUP otherwise.

The following patch will support the ENOTSUP cases.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ie0113521572aa405f26c8c197f5ffb14ca0503ff
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23687
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

dif: Insert abstraction into dif_generate/verify_copy() for NVMe PRACT

This will simplify the following changes.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ia3b8ffb38dd6858a

dif: Insert abstraction into dif_generate/verify_copy() for NVMe PRACT

This will simplify the following changes.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ia3b8ffb38dd6858a0f16b6da52a993da47c6ca4b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23686
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

dif: Rename internal generate/verify_copy() by insert/strip_copy()

We want to add NVMe PRACT handling into the DIF library.
If metadata size is equal with PI size, NVMe PRACT and insert/strip
are sa

dif: Rename internal generate/verify_copy() by insert/strip_copy()

We want to add NVMe PRACT handling into the DIF library.
If metadata size is equal with PI size, NVMe PRACT and insert/strip
are same. But, if metadata size is larger than PI size, NVMe PRACT
is overwrite/verify. Current generate/verify_copy() support only
insert/strip.

Hence, as a preparation, rename internal dif_generate/verify_copy()
by dif_insert/strip_copy().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ic309d8bc41e5d92ad87cacf69909f15303c2cea1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23685
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

stdinc.h: move epoll header over here

Change-Id: Iaee83f78f3586548ded3c54af862011c380d0d75
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk

stdinc.h: move epoll header over here

Change-Id: Iaee83f78f3586548ded3c54af862011c380d0d75
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25395
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

util: handle events for fd type eventfd

To clear interrupt events on file descriptors that are eventfds we have
to read them. This commit introduces a new fd type SPDK_FD_TYPE_EVENTFD
which does tha

util: handle events for fd type eventfd

To clear interrupt events on file descriptors that are eventfds we have
to read them. This commit introduces a new fd type SPDK_FD_TYPE_EVENTFD
which does that.

Change-Id: Ida78e1a037097984fbdfac170478c41520822f93
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25171
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

util: Extended options for spdk_fd_group_add

Added a new API spdk_fd_group_add_ext(), which accepts extended
options for event handler i.e. spdk_event_handler_opts.
The spdk_event_handler_opts has e

util: Extended options for spdk_fd_group_add

Added a new API spdk_fd_group_add_ext(), which accepts extended
options for event handler i.e. spdk_event_handler_opts.
The spdk_event_handler_opts has events and fd_type. This provides
flexibility in handling different types of fds, which may require
specific operations to be performed when an event is generated.

Change-Id: I8ce36e5ed72e9ca616c9bdb38e45df6541873b1a
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25170
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

util: fix total fds to wait for

Change num_fds type from signed to unsigned int.

The epoll file descriptor for a fd group waits for interrupt event on
the fds from its interrupt sources list as wel

util: fix total fds to wait for

Change num_fds type from signed to unsigned int.

The epoll file descriptor for a fd group waits for interrupt event on
the fds from its interrupt sources list as well as from all its children
fd group interrupt sources list. Update add, remove, nest and unnest APIs
to track the correct number of fds registered in a fd group.
Add a check to verify that interrupt sources list is empty before
destroying the fd group.

Change-Id: Ib06de08e1083579540f9d0d0ee5fb8db23caad11
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25077
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

util/fd_group: improve logs and documentation

Change-Id: If71c64f88fdc79411e425f5538094704ec2c0753
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/s

util/fd_group: improve logs and documentation

Change-Id: If71c64f88fdc79411e425f5538094704ec2c0753
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25213
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

dif: Do copy data + insert/strip metadata if DIF is disabled

Previously, spdk_dif_generate/verify_copy() did nothing and returned
0 if DIF was disabled.

However, this was wrong.

spdk_dif_generate_

dif: Do copy data + insert/strip metadata if DIF is disabled

Previously, spdk_dif_generate/verify_copy() did nothing and returned
0 if DIF was disabled.

However, this was wrong.

spdk_dif_generate_copy() should copy data and insert metadata field.
spdk_dif_verify_copy() should copy data and strip metadata field.

Add such change and verify it by adding unit test cases.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I8408e360376a607864bb7f0a187abb73bb7b6e0d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23684
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib/util: Make md5 API public

Make md5 realted functions in iscsi lib public.
Interface remained unchaged except of spdk_ prefix
added to func names. Implementation slightly updated
with unlikely()

lib/util: Make md5 API public

Make md5 realted functions in iscsi lib public.
Interface remained unchaged except of spdk_ prefix
added to func names. Implementation slightly updated
with unlikely() hints.

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I8bff008aad0c44b639b9249e1b48f3a6f9421f74
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23133
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

dif: Remove alignment requirement from spdk_dif_verify_copy()

As mentioned in the last patch in the patch series,
spdk_dif_verify_copy() required each iovec of bounce buffer to be
multiple of block

dif: Remove alignment requirement from spdk_dif_verify_copy()

As mentioned in the last patch in the patch series,
spdk_dif_verify_copy() required each iovec of bounce buffer to be
multiple of block size length. This was too strong.

The last patch removed the limitation for spdk_dif_generate_copy().
This patch removes the limitation for spdk_dif_verify_copy().

Add unit test cases for verification.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib32e9f4b3ca27e4ed7d9c95626aec562b9384198
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23683
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

dif: Remove alignment requirement from spdk_dif_generate_copy()

spdk_dif_generate_copy() required each iovec of bounce buffer to be
multiple of block size length. This was too strong.

Software impl

dif: Remove alignment requirement from spdk_dif_generate_copy()

spdk_dif_generate_copy() required each iovec of bounce buffer to be
multiple of block size length. This was too strong.

Software implementation should not have strong limitation on
configuration.

Remove the limitation in this patch.

Modify the functional test of the DIF feature of the accel framework
slightly. The total length of the iovec still should be larger than
payload length.

spdk_dif_verify_copy() have the same strong limitation. However, in unit
tests, spdk_dif_generate_copy() and spdk_dif_verify_copy() are a pair
and share the same bounce buffer.

If we add bugs to both of spdk_dif_generate_copy() and
spdk_dif_verify_copy(), it is likely that the bugs are not found in
unit tests. Hence, this patch changes only spdk_dif_generate_copy().
The next patch will change spdk_dif_verify_copy().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib50299a8b337a4825708891f9739e72a862fbf49
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23846
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

dif: Refactor spdk_dif_verify_copy()

The previous patch refactored spdk_dif_generate_copy(). This patch
refactors the opposite spdk_dif_verify_copy().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nv

dif: Refactor spdk_dif_verify_copy()

The previous patch refactored spdk_dif_generate_copy(). This patch
refactors the opposite spdk_dif_verify_copy().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib719f1745df496e61209c4d1f65f94ce3e799e13
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23845
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

dif: Refactor spdk_dif_generate_copy()

This patch changes only generate_copy funciton. The existing verify
function can check if this change is correct.

The next patch will change the corresponding

dif: Refactor spdk_dif_generate_copy()

This patch changes only generate_copy funciton. The existing verify
function can check if this change is correct.

The next patch will change the corresponding verify_copy function.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ia7f3d159c2db917dc74b45d349affd880597edc9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23844
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

dif: Refactor spdk_dif_verify()

The previous patch refactored spdk_dif_generate(). This patch refactors
the opposite spdk_dif_verify().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Chang

dif: Refactor spdk_dif_verify()

The previous patch refactored spdk_dif_generate(). This patch refactors
the opposite spdk_dif_verify().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I6746c84ce37d4a9cbd56727731542b576baaba55
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23843
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

dif: Refactor spdk_dif_generate()

Code was not easy to read and understand for buffer split cases.
Refactor spdk_dif_generate() to improve readability and to make
us easier to change.

This patch ch

dif: Refactor spdk_dif_generate()

Code was not easy to read and understand for buffer split cases.
Refactor spdk_dif_generate() to improve readability and to make
us easier to change.

This patch changes only generate function. The existing verify
function can check if this change is correct.

The next patch will change the corresponding verify function.

Similar refactoring will follow in the patch series.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Iefc6a54b81bff1282c1149bcc8efb81eaf129a1d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23842
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

util: copy errno before calling stdlib's functions

Functions are allowed to change the value of errno, even when they're
successful. So, save it before calling other functions to ensure it's
not ov

util: copy errno before calling stdlib's functions

Functions are allowed to change the value of errno, even when they're
successful. So, save it before calling other functions to ensure it's
not overwritten.

Additionally, scan-build complains that these errnos can still be zero,
even though the manual says that they're always set if an error is
encountered. To keep it quiet, added a couple of assertions that check
it.

Fixes: #3453

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I76209bc1970f42cc8d52446fa651d5a9fee3d70f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24298
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Bypass-Merge-Requirements: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

dif: Fix metadata config check of dif_ctx_init() and add unit test cases

For 32b Guard PI format and 64b Guard PI format, data block size should
be equal or greater than 4KiB. However, the check was

dif: Fix metadata config check of dif_ctx_init() and add unit test cases

For 32b Guard PI format and 64b Guard PI format, data block size should
be equal or greater than 4KiB. However, the check was done only for
separate metadata. This was wrong. Move the check to the common part to
be available both for interleaved metadata and separate metadata.

Unit test was not enough for such checks. Add more cases.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ibb3b0c4bf3c56ffc70a6e16eacbe8ca390e36ebb
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24204
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...