nvme: Add transport interface to enable interrupts

The following commit will enable interrupts for pcie transport.
So add a new interface for the same.

Change-Id: I5cd87b0bb4ec95d6a9b862b659405cf56

nvme: Add transport interface to enable interrupts

The following commit will enable interrupts for pcie transport.
So add a new interface for the same.

Change-Id: I5cd87b0bb4ec95d6a9b862b659405cf56d8f864a
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24904
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

nvme: Add spdk_nvme_ctrlr_get_id() for multipath identification

ctrlr->cntlid is easy to get. However, there was no public API to
return ctrlr->cntlid yet.

As the following comment in lib/nvme/nvme

nvme: Add spdk_nvme_ctrlr_get_id() for multipath identification

ctrlr->cntlid is easy to get. However, there was no public API to
return ctrlr->cntlid yet.

As the following comment in lib/nvme/nvme_ctrlr.c,

Fabrics controllers should already have CNTLID from the Connect command.

If CNTLID from Connect doesn't match CNTLID in the Identify Controller data,
trust the one from Connect.

ctrlr->cntlid is sufficiently reliable.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Iad7f1d8defcc427b7656e1b5f4f8104439bcfd51
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25297
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvme: add methods for forcing (re)authentication

These two functions can be used to force IO and admin qpairs to
authenticate. They can be called at any time while a qpair is active.
If it has alre

nvme: add methods for forcing (re)authentication

These two functions can be used to force IO and admin qpairs to
authenticate. They can be called at any time while a qpair is active.
If it has already been connected and authenticated, it'll be forced to
reauthenticate. If the connection is still being established, these
functions will only register the callback and let the regular
authentication flow proceed.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I830fbe7d775c0997f24689fab2b2fc3cd875b15a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24233
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

nvme: Get NVM Identify Namespace Data for Extended LBA Format

If ns->csi is NVM and ctrlr->cdata.ctratt.bits.elbas is 1,
get NVM identify namespace data to handle extended LBA format.

Additionally,

nvme: Get NVM Identify Namespace Data for Extended LBA Format

If ns->csi is NVM and ctrlr->cdata.ctratt.bits.elbas is 1,
get NVM identify namespace data to handle extended LBA format.

Additionally, add a public API spdk_nvme_nvm_ns_get_data() for the
upper layer to the identify data.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Icea8127b8a4834c4efb137369f3a8bfb388cb01b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23621
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvme/auth: make get_{digest,dhgroup}_name() functions public

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I63da019d2d53e76a7533a74a824623faa4b4edba
Reviewed-on: https://review

nvme/auth: make get_{digest,dhgroup}_name() functions public

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I63da019d2d53e76a7533a74a824623faa4b4edba
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22018
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: initial in-band authentication code

This patch adds structures that will be used to implement NVMe in-band
authentication using the DH-HMAC-CHAP protocol. They're mostly empty for
now, the fo

nvme: initial in-band authentication code

This patch adds structures that will be used to implement NVMe in-band
authentication using the DH-HMAC-CHAP protocol. They're mostly empty for
now, the following patches will implement each step of this process.

The authentication is executed by exchanging several messages using the
AUTHENTICATION_SEND and AUTHENTICATION_RECEIVE commands from the Fabrics
Command Set. The messages sent by the host map to the SEND commands,
while those sent by the controller map to the RECEIVE commands.

The flow roughly consists of 5 steps:
1. The host sends a AUTH_negotiate message to listing the hash function
and Diffie-Hellman group it supports.
2. The controller responds with a DH-HMAC-CHAP_challenge message
selecting one of the hash functions and DH groups from those sent by
the host along with a challenge value and an optional DH public key.
3. The host calculates an HMAC of the challenge (optionally augmented
with a DH secret) and sends it back to the controller using a
DH-HMAC-CHAP_reply message along with its DH public key. If
bidirectional authentication is requested, it includes its own
challenge value in that message.
4. The controller verifies the response to the challenge received from
the host comparing it to its HMAC calculation. If successful, it
sends a DH-HMAC-CHAP_success1 message with an optional response to
the host challenge.
5. If bidirectional authentication wasn't requested, the authentication
process is finished at this point. Otherwise the host verifies
controller's response to the host's challenge and, if successful,
sends a DH-HMAC-CHAP_success2 message.

Any errors during this process are reported by sending either an
AUTH_failure1 message (sent by the controller) or AUTH_failure2 (sent by
the host).

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I84cc1574e15884e1e3d3d03e517cb38f05e12ef6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21981
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: keep stubbed function in a single place

It gets rid of a few #ifdefs from source files with actual code.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I62af47ba3c5cac0e0

nvme: keep stubbed function in a single place

It gets rid of a few #ifdefs from source files with actual code.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I62af47ba3c5cac0e00becb979b27df98ff05bfe6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22112
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

nvme: Don't build vfio-user transport if the user disabled it

Change-Id: Ibc169dff3e418df266c3b3ae3072616e04bb2b25
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerr

nvme: Don't build vfio-user transport if the user disabled it

Change-Id: Ibc169dff3e418df266c3b3ae3072616e04bb2b25
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21960
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: add fuse3 to LOCAL_SYS_LIBS

Library makefiles are required to add dependent libraries
to LOCAL_SYS_LIBS, although it seems at least some systems
have linkers which are able to workaround missi

nvme: add fuse3 to LOCAL_SYS_LIBS

Library makefiles are required to add dependent libraries
to LOCAL_SYS_LIBS, although it seems at least some systems
have linkers which are able to workaround missing ones at
some times. Upcoming patches to make CONFIG_NVME_CUSE=y
by default discovered external_code tests failed without this.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I6fe702014e28a730e43e39bfa281984614953a8a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21125
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvme_rdma: Add option to limit indefinite growth of CQ size

CQ size had grown indefinitely every when an I/O qpair was added to a
poller. This was not desirable. To limit the CQ size, add a transpor

nvme_rdma: Add option to limit indefinite growth of CQ size

CQ size had grown indefinitely every when an I/O qpair was added to a
poller. This was not desirable. To limit the CQ size, add a transport
option, rdma_max_cq_size. It is zero, which means unlimited, by default.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I8867ad4600ce85cc13c3c8b7129e39563e2cbfc9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18840
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: add iovec passthru

This is used for sending big passthru commands, like Report Zones, over nvmf.

Change-Id: I83188367e0266e093faadd49cdb2e051eae71829
Signed-off-by: Karl Bonde Torp <k.torp@sa

nvme: add iovec passthru

This is used for sending big passthru commands, like Report Zones, over nvmf.

Change-Id: I83188367e0266e093faadd49cdb2e051eae71829
Signed-off-by: Karl Bonde Torp <k.torp@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20498
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvme: remove remaining __attribute__((packed))

These strucutres had the packed attribute to make sure their size
changed whenever a new field was added at the end for ABI compatibility.
However, all

nvme: remove remaining __attribute__((packed))

These strucutres had the packed attribute to make sure their size
changed whenever a new field was added at the end for ABI compatibility.
However, all of them have a corresponding *_get_opts() function, which
will will out the new fields, even if the code using it was unaware of
them when it was compiled. For the same reason, their size can be
obtained with a regular sizeof(), and not SPDK_SIZEOF().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I658ce6619ed92015b6c61d8460abd192be368496
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18532
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

build: enable Wpointer-arith in selected libraries

There's an organization, called Timerland SIG [1], that uses SPDK's NVMe
driver to implement NVMe Boot Specification under UEFI. The UEFI EDK2
bui

build: enable Wpointer-arith in selected libraries

There's an organization, called Timerland SIG [1], that uses SPDK's NVMe
driver to implement NVMe Boot Specification under UEFI. The UEFI EDK2
build environment uses both gcc and msvc. While SPDK can be built
without any issues with gcc, msvc complains about a few things, one of
which is void pointer arithmetic. So, to make Timberland's effort
easier, Wpointer-arith is enabled in the libraries they're using.

[1] https://github.com/timberland-sig

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ic90330baa4e69ee72f7e040de91893093b96f476
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18529
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

nvme: Add spdk_nvme_qpair_is_connected() to check connection state

The upper layer wants to know when the qpair is actually connected
and can start processing I/Os. Add a new API
spdk_nvme_qpair_is_

nvme: Add spdk_nvme_qpair_is_connected() to check connection state

The upper layer wants to know when the qpair is actually connected
and can start processing I/Os. Add a new API
spdk_nvme_qpair_is_connected() for the purpose.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib15305aa7b08000c5a88baad5595ce99b1251506
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18242
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: Add a helper function to return status type string

Add spdk_nvme_cpl_get_status_type_string() to return ASCII
string for the type of an error.

Append a dummy entry to return "RESERVED" for un

nvme: Add a helper function to return status type string

Add spdk_nvme_cpl_get_status_type_string() to return ASCII
string for the type of an error.

Append a dummy entry to return "RESERVED" for unknown types.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ibc07132ee067f146ac149884c6344f313bfcbfff
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15835
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

build: compile API functions with missing deps

We should always build all function that are part of the API, even if
some of the libraries they depend on are missing. In that case, they
can return

build: compile API functions with missing deps

We should always build all function that are part of the API, even if
some of the libraries they depend on are missing. In that case, they
can return an error instead.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I72b450b3a1d62e222bd843e45be547d926414775
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15414
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...

vfio_user: remove CONFIG_VFIO_USER flag for client library

The client vfio_user library doesn't require this flag as
it is totally owned in SPDK, so remove it.

Change-Id: I8f7b1df18017ceac24dbb8a04

vfio_user: remove CONFIG_VFIO_USER flag for client library

The client vfio_user library doesn't require this flag as
it is totally owned in SPDK, so remove it.

Change-Id: I8f7b1df18017ceac24dbb8a0417871f25f6bee0d
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13895
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

nvme: Increase major SO version

An earlier commit added ctrlr_ready into struct
spdk_nvme_transport_ops. However, the major SO
version was not increased.

Fixes: 3dd0bc9e (nvme: Add transport contro

nvme: Increase major SO version

An earlier commit added ctrlr_ready into struct
spdk_nvme_transport_ops. However, the major SO
version was not increased.

Fixes: 3dd0bc9e (nvme: Add transport controller ready step)
Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Id903634f9aaf5bdaa62fd30e92a4fb39a985b86f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13981
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in every source file. This patch replaces
the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause
identifier.

Almost all of these files share the exact same license text,
and this patch only modifies the files that contain the
most common license text. There can be slight variations
because the third clause contains company names - most say
"Intel Corporation", but there are instances for Nvidia,
Samsung, Eideticom and even "the copyright holder".

Used a bash script to automate replacement of the license text
with SPDX identifier which is checked into scripts/spdx.sh.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: <qun.wan@intel.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 22.05
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Id1a5358882dc496faa5b0b5c9a63b326c378c551
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11361
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

nvme: add spdk_nvme_ctrlr_get_discovery_log_page API

This API is a helper for getting the full discovery
log page from a discovery controller. It will read the
log page header to get the total numb

nvme: add spdk_nvme_ctrlr_get_discovery_log_page API

This API is a helper for getting the full discovery
log page from a discovery controller. It will read the
log page header to get the total number of entries,
allocate a buffer for all of the entries, and then
issue a series of get_log_page commands to read each
4KiB worth of entries.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I02666ef5adcb9fc8825a221655811ace708f97b8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10564
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: Add three APIs for disconnect, start re-enable, and poll re-enable ctrlr

The NVMe bdev module will support two features, delayed reconnect and
delete after multiple failures of reconnect to im

nvme: Add three APIs for disconnect, start re-enable, and poll re-enable ctrlr

The NVMe bdev module will support two features, delayed reconnect and
delete after multiple failures of reconnect to improve error recovery.

The recently added two APIs, spdk_nvme_ctrlr_reset_async() and
spdk_nvme_ctrlr_reset_poll_async(), were not good enough.

spdk_nvme_ctrlr_reset_ctx was not necessary. It had only a pointer to ctrlr.
Using a pointer to ctrlr directly saves us from undesirable malloc error
processing.

Separate spdk_nvme_ctrlr_reset_async() into spdk_nvme_ctrlr_disconnect()
and spdk_nvme_ctrlr_reconnect_async(). spdk_nvme_ctrlr_disconnect()
disconnects ctrlr including disconnecting adminq.
spdk_nvme_ctrlr_reconnect_async() moves the ctrlr state to INIT.

Then rename spdk_nvme_ctrlr_reset_poll_async() by
spdk_nvme_ctrlr_reconnect_poll_async().

Finally deprecate spdk_nvme_ctrlr_reset_async() and
spdk_nvme_ctrlr_reset_poll_async().

The following patches will change the NVMe bdev module to use these new APIs.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Id1d6858dcdc5fc2e9db0a6ebf3f79cab4f9bbcb7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10091
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...