scripts: switch from go fmt to gofmtNeither "go fmt" nor "gofmt" return a status code when the format checkfails. We can only rely on their stdout. "go fmt" invokes "gofmt -w -l"on every file in
scripts: switch from go fmt to gofmtNeither "go fmt" nor "gofmt" return a status code when the format checkfails. We can only rely on their stdout. "go fmt" invokes "gofmt -w -l"on every file in the target package and pulls in dependencies. Thesedependencies are not verified, but they pollute stdout and increaseformat check time.Therefore, we switch to "gofmt", which only checks files within thetarget package.It turns out that not all files from the target package were checked.Compare "go fmt -n ." to "go fmt -n ./...". Switching to "gofmt ."addresses this issue, and we've added fixes to client.go accordingly.Finally, instead of fixing the formatting, we print out the diff byswitching from "-w" to "-d".Change-Id: Ifb1c339bdd1703c7d9e1b0cfa0b0ad0df7cff683Signed-off-by: Emilia Haligowska <emilia.haligowska@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22832Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Community-CI: Mellanox Build Bot
show more ...
examples: Example app for using go-rpcBuild example app using go-rpc.Change-Id: Id978a39fdb0f33a6d403e395daa17ad595a11862Signed-off-by: Emilia Haligowska <emilia.haligowska@intel.com>Signed-off
examples: Example app for using go-rpcBuild example app using go-rpc.Change-Id: Id978a39fdb0f33a6d403e395daa17ad595a11862Signed-off-by: Emilia Haligowska <emilia.haligowska@intel.com>Signed-off-by: Maciej Mis <maciej.mis@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19815Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>