examples/accel_perf: Fix double free

If memory allocation in _init_thread failed, we free
worker->task_base. We also free it in unregister_worker
which is part of normal shutdown process. To prevent

examples/accel_perf: Fix double free

If memory allocation in _init_thread failed, we free
worker->task_base. We also free it in unregister_worker
which is part of normal shutdown process. To prevent
double free, set task_base to NULL after free in
_init_thread

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I878205adea7e7f0eda31ef7a72884ee1ce242a1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23139
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

accel_perf: add support for DIX Generate/Verify

Add support for DIX Generate and Verify operations to accel_perf
example application.
Additionally, include these operations in accel.sh tests.

Chang

accel_perf: add support for DIX Generate/Verify

Add support for DIX Generate and Verify operations to accel_perf
example application.
Additionally, include these operations in accel.sh tests.

Change-Id: I1a5e6c0bdc2b6a99027b1fb2a504e79926e4688b
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24093
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

Examples/Perf: correct the calculation of total bandwidth

For bigger IO, the IO could be split into small ones, so use the
original size of configured IO is incorrect.

Change-Id: I049aca21b82567c75

Examples/Perf: correct the calculation of total bandwidth

For bigger IO, the IO could be split into small ones, so use the
original size of configured IO is incorrect.

Change-Id: I049aca21b82567c750f6a6845346c1f5fad65a39
Signed-off-by: Gang Cao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24127
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel: Fixed minor issues in comments and output formatting

Modified function descriptions and output formatting in case of errors.

Change-Id: Ia4cb86b088ab5ca15faaaadb75b5b2c4f6ed370b
Signed-off-b

accel: Fixed minor issues in comments and output formatting

Modified function descriptions and output formatting in case of errors.

Change-Id: Ia4cb86b088ab5ca15faaaadb75b5b2c4f6ed370b
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23065
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

examples/accel: DIF verify copy accel perf tests

Extend the Accel performance example application with
DIF verify copy operation support.

Change-Id: Ib7abd31d00e5554454547a7a234e0e1f03b3afd8
Signed

examples/accel: DIF verify copy accel perf tests

Extend the Accel performance example application with
DIF verify copy operation support.

Change-Id: Ib7abd31d00e5554454547a7a234e0e1f03b3afd8
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21719
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22950
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test di

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test directories.

Some of the tests now require that we explicitly set RPC address,
because some apps no longer use the default SPDK address.

Change-Id: I417a3a756581f44c711257e6d2408d933b40386a
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22634
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

accel_perf.c: allocate ap_task->crc_dst dynamically using spdk_dma_zmalloc

- allocating ap_task->crc_dst using spdk_dma_zmalloc to enable passing crc_dst's address to DMA

Fixes issue #3230

Change-

accel_perf.c: allocate ap_task->crc_dst dynamically using spdk_dma_zmalloc

- allocating ap_task->crc_dst using spdk_dma_zmalloc to enable passing crc_dst's address to DMA

Fixes issue #3230

Change-Id: I56beb2b0b5158f1b4ac921ef3f2c6aa153dcc7c4
Signed-off-by: Moshe Shahar <mooshons@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22151
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

examples/accel: DIF generate accel perf tests

Extend the Accel performance example application with DIF Generate
operation support.

Change-Id: Ia8b4673b26aa926806b02fca1e6ad3ef9e3d12d7
Signed-off-b

examples/accel: DIF generate accel perf tests

Extend the Accel performance example application with DIF Generate
operation support.

Change-Id: Ia8b4673b26aa926806b02fca1e6ad3ef9e3d12d7
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20707
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

examples/accel: DIF generate-copy accel perf tests

Extend the Accel performance example application with DIF Generate-copy
operation support.

Change-Id: I7c143ba4ad52b3b3ebe80a6c5aff23ffa115a196
Si

examples/accel: DIF generate-copy accel perf tests

Extend the Accel performance example application with DIF Generate-copy
operation support.

Change-Id: I7c143ba4ad52b3b3ebe80a6c5aff23ffa115a196
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20281
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

examples/accel: DIF verify accel perf tests

Extend the Accel performance example application with
DIF Verify operation support.

Change-Id: I781367a063f2ead0ebd57c3d37ce3f05209178ba
Signed-off-by: K

examples/accel: DIF verify accel perf tests

Extend the Accel performance example application with
DIF Verify operation support.

Change-Id: I781367a063f2ead0ebd57c3d37ce3f05209178ba
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20280
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

example/accel_perf: add parameter to select accel module

Using JSON RPC (config or rpc.py) it is possible to select
which accel module will be used for selected operation.

Unfortunately when manual

example/accel_perf: add parameter to select accel module

Using JSON RPC (config or rpc.py) it is possible to select
which accel module will be used for selected operation.

Unfortunately when manually testing various modules or
for simple script testing, this adds unnecessary complexity.

To ease that, new parameter -M was added that assigns
module to the operation selected for the test.
Rather than ignoring overwrite from RPC, flat out
exit the application if -M conflicts with RPC.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Iaea7d294fee6d2749489293a2c0849ee484e89d1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21185
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Slawomir Ptak <slawomir.ptak@intel.com>

show more ...

example/accel_perf: remove unused -n option from help

(8875435) lib/accel: Add the real chained crc32 support with the example.

Patch above mistakenly introduced -n option to help,
without any actu

example/accel_perf: remove unused -n option from help

(8875435) lib/accel: Add the real chained crc32 support with the example.

Patch above mistakenly introduced -n option to help,
without any actual use to back it up.
Passing it to the application didn't result in any
errors due to event library having the -n option too.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Iaebd43134294067aae6009823f5e8d578b20b329
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21183
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

example/accel_perf: cleanup worker on init errors

There are multiple paths where worker initialization can fail
in _init_thread(). Multiple spdk_threads should not call spdk_app_stop(),
instead each

example/accel_perf: cleanup worker on init errors

There are multiple paths where worker initialization can fail
in _init_thread(). Multiple spdk_threads should not call spdk_app_stop(),
instead each one should call exit on itself and only the last one calls
the spdk_app_stop().

This patch fixes this by removing spdk_app_stop() from _init_thread().
Instead consolidate that through unregister_worker() that is called
at the end of shutdown_cb().

When worker cannot be allocated, thread_exit can be called immediately.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ia6d2d409e51c859e24cd02b0799769be535db3f7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21064
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

example/accel_perf: return when no workload is specified

If no workload is specified via arguments, then parse_args
does not execute for -w that sets g_workload_selection.

Resulting in taking the d

example/accel_perf: return when no workload is specified

If no workload is specified via arguments, then parse_args
does not execute for -w that sets g_workload_selection.

Resulting in taking the default of COPY enum (equals 0).
This patch initializes g_workload_selection to value that
will never be used for a valid operation (SPDK_ACCEL_OPC_LAST)
and double checks it after parsing the arguments.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I4b2a4a5d3665e3d3703fa688fed961d5f8e2d42d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20971
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

example/accel_perf: return immediately on incorrect params

No need to go through the cleanup label since nothing is allocated
until spdk_app_start().

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki

example/accel_perf: return immediately on incorrect params

No need to go through the cleanup label since nothing is allocated
until spdk_app_start().

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I3d31157dceed356c3164a0f8cd96e7a4b42026e9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20970
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

accel_perf: fix the alignment when dumping results

The values in the total summary were misaligned with the values of
individual threads.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Ch

accel_perf: fix the alignment when dumping results

The values in the total summary were misaligned with the values of
individual threads.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id837fc32e01e8b7d5aaaf5971cd67ed06c9ab8a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20443
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

accel_perf: use -S for specifying crc32 seed

The help said that the seed can be specified using the -s option, but it
wasn't part of the optstring. And it cannot be part of the opstring,
because -s

accel_perf: use -S for specifying crc32 seed

The help said that the seed can be specified using the -s option, but it
wasn't part of the optstring. And it cannot be part of the opstring,
because -s is already reserved by the --mem-size option. So, use -S
instead.

Additionally, this patch renames argc,argv -> ch,arg in parse_args(), as
these variables describe a single command-line parameter, not the whole
vector.

Fixes #3164.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I234377e0eef7f4a4ddcd55a3baeb6dda20b573cb
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20449
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

accel_perf: exit with zero status after --help

This option shouldn't result in the app exiting with an error.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I1eb8792e91246dde09

accel_perf: exit with zero status after --help

This option shouldn't result in the app exiting with an error.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I1eb8792e91246dde095537c90bcc5a07c9bd6a6e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20418
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

accel_perf: stop immediately when no workers are registered

This can happen when the app is started with the --wait-for-rpc option
and user tries to kill it.

Signed-off-by: Konrad Sztyber <konrad.s

accel_perf: stop immediately when no workers are registered

This can happen when the app is started with the --wait-for-rpc option
and user tries to kill it.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5dfde3495c456c0ee1fd3856f04d5be932e2796f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20256
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

accel: add the spdk_ prefix to accel_opcode

This enum is part of the public interface, so it should have the spdk_
prefix.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ie1d4a

accel: add the spdk_ prefix to accel_opcode

This enum is part of the public interface, so it should have the spdk_
prefix.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ie1d4aee707ede70c7f181561e1002ce443628ca4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19685
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

accel_perf: add shutdown callback

Otherwise, it's impossible to stop the app before its run time expires,
because the accel library waits until its IO channels are released which
would only happen a

accel_perf: add shutdown callback

Otherwise, it's impossible to stop the app before its run time expires,
because the accel library waits until its IO channels are released which
would only happen at the end.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I7438b474f4f6d6bcb4bf6aad02ccae9f511f1b51
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17768
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

accel_perf: use accel stats when dumping results

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iae1128ce01c16731bced8f97c08f44e1b0bc83f2
Reviewed-on: https://review.spdk.io/ger

accel_perf: use accel stats when dumping results

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iae1128ce01c16731bced8f97c08f44e1b0bc83f2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17626
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

examples/accel/perf: add support for xor

Change-Id: I0a9216945f5877af80d911b46f988a440e855fd4
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerri

examples/accel/perf: add support for xor

Change-Id: I0a9216945f5877af80d911b46f988a440e855fd4
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16395
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...