nvme: drop support for submit_accel_crc32

It was deprecated, and the TCP transport no longer uses it for data
digest calculations.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id

nvme: drop support for submit_accel_crc32

It was deprecated, and the TCP transport no longer uses it for data
digest calculations.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ic9d5be8972b73325a35bcaff7ed4998fd34f7b8b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25160
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/nvme: controller failover/multipath doc change

Added information about implemented change of the default controller
mode, now multipath is a new default.
The consistency of configuration of con

bdev/nvme: controller failover/multipath doc change

Added information about implemented change of the default controller
mode, now multipath is a new default.
The consistency of configuration of controllers with the same name is
now verified - all must be configured either for multipath or failover,
it is not possible to configure e.g one for multipath and second for
failover mode.
Added information about spdk_bdev_nvme_create() API function parameter
list change.

Change-Id: I76e95c19a5b97eb5dd74485964d00d6705c0c559
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25030
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/nvme: deprecation notice - inconsistent ctrl config

All controllers created with the same name shall be configured either
for multipath or for failover. Otherwise we have configuration mismatch

bdev/nvme: deprecation notice - inconsistent ctrl config

All controllers created with the same name shall be configured either
for multipath or for failover. Otherwise we have configuration mismatch.
Support for configuration, where some controllers with the same name
are configured for multipath while others for failover, will be
deprecated in 25.01.
There is also planned default mode change in SPDK release 25.01:
if no '-x' option will be specified in bdev_nvme_attach_controller
RPC call, the multipath mode will be assigned as a default.

Change-Id: I01035a1989f18a995d620c6463101196f293e638
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24899
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

nvme: deprecate spdk_nvme_accel_fn_table.submit_accel_crc32c

This callback only makes the TCP transport code a lot more complicated,
as it requires us to support three ways to calculate data digest:

nvme: deprecate spdk_nvme_accel_fn_table.submit_accel_crc32c

This callback only makes the TCP transport code a lot more complicated,
as it requires us to support three ways to calculate data digest: append
API, software fallback, and submit_accel_crc32c. The append API is the
way forward, as it allows for offloading the crc32 calculation *and*
chaining it with other accel operations.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I7217be9bfc728e6021a5a4e592271e5c0b92ba1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24811
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: require TLS PSKs to be specified via keyring

It's no longer possible to pass the key directly in spdk_nvme_ctrl_opts.
This method was deprecated and was supposed to be removed in the
upcoming

nvme: require TLS PSKs to be specified via keyring

It's no longer possible to pass the key directly in spdk_nvme_ctrl_opts.
This method was deprecated and was supposed to be removed in the
upcoming release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: If06e087abb83da6b2f22c4a9f7129720f26e6f0d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24810
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf/tcp: require TLS PSKs to be specified via keyring

It's no longer possible to set TLS PSKs by specifying a path to the file
containing the key. This method was deprecated and was supposed to be

nvmf/tcp: require TLS PSKs to be specified via keyring

It's no longer possible to set TLS PSKs by specifying a path to the file
containing the key. This method was deprecated and was supposed to be
removed in the upcoming release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Idfa4c935bd97f20c020779d90b186607f24bb525
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24805
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: remove spdk_nvmf_request_exec_fabrics()

It was deprecated and was supposed to be removed in the upcoming
release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I6fdd9416

nvmf: remove spdk_nvmf_request_exec_fabrics()

It was deprecated and was supposed to be removed in the upcoming
release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I6fdd94160fade6b0a5820304bce5c24f69641e3a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24804
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf: remove listen_address.transport decoders

This field was deprecated in favor of "trtype" and was supposed to be
removed in the upcoming release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@i

nvmf: remove listen_address.transport decoders

This field was deprecated in favor of "trtype" and was supposed to be
removed in the upcoming release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I62ecbf3f801e05635937a4d940e2170676d1b205
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24803
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

init: remove spdk_subsystem_init_from_json_config

This was deprecated and marked for removal in v24.09 release, so it
is time to remove it.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change

init: remove spdk_subsystem_init_from_json_config

This was deprecated and marked for removal in v24.09 release, so it
is time to remove it.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ib76e7acd61c4067711be1a7c22aa0b43aba04f4f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24664
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

env: add spdk_pci_device_get_numa_id()

This effectively replaces spdk_pci_device_get_socket_id(), which is
marked obsolete in this patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-I

env: add spdk_pci_device_get_numa_id()

This effectively replaces spdk_pci_device_get_socket_id(), which is
marked obsolete in this patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I1b32adf4f357221e6ae4b98c234ac70a2192b9bc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24609
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

env: add spdk_env_get_numa_id()

This will effectively replace spdk_env_get_socket_id(), which is
marked obsolete as part of this patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id:

env: add spdk_env_get_numa_id()

This will effectively replace spdk_env_get_socket_id(), which is
marked obsolete as part of this patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I5d39e5e1b98e07f709b14c86382e59ea76584def
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24608
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

doc: fix deprecation.md typo

Registration is done with SPDK_LOG_DEPRECATION_REGISTER(), not
SPDK_DEPRECATION_REGISTER().

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I47681673c1081

doc: fix deprecation.md typo

Registration is done with SPDK_LOG_DEPRECATION_REGISTER(), not
SPDK_DEPRECATION_REGISTER().

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I47681673c108177e8045c798b6dba5fff62717b8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23962
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

nvmf: deprecate [listen_]address.transport

trtype should be use instead.

Change-Id: I45d75eb0dbbc60c882490f54b5f7904cb49bdad1
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https

nvmf: deprecate [listen_]address.transport

trtype should be use instead.

Change-Id: I45d75eb0dbbc60c882490f54b5f7904cb49bdad1
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23358
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvmf: remove transport usage from nvmf_get_subsystems

It was deprecated and scheduled for removal in v24.05.

Change-Id: Ic902af6cbdec1656f3046c68e2f203e4d46455c8
Signed-off-by: Jacek Kalwas <jacek.

nvmf: remove transport usage from nvmf_get_subsystems

It was deprecated and scheduled for removal in v24.05.

Change-Id: Ic902af6cbdec1656f3046c68e2f203e4d46455c8
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23357
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

lvol: remove size parameter from bedv_lvol_{create,resize}

This parameter was replaced with size_in_mib and was deprecated for a
long time, so it's finally time to remove it.

Signed-off-by: Konrad

lvol: remove size parameter from bedv_lvol_{create,resize}

This parameter was replaced with size_in_mib and was deprecated for a
long time, so it's finally time to remove it.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I0c753c535418b43c8a4759d9dac5825da88c8adf
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22951
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22950
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

util: remove spdk_iov_one()

It was deprecated and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I92863b51fcc1d5bc6c646c6eff043b0c34890264
Revi

util: remove spdk_iov_one()

It was deprecated and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I92863b51fcc1d5bc6c646c6eff043b0c34890264
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22949
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: remove spdk_nvmf_subsytem_any_listener_allowed()

It was deprecated and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2184f5521aff8580ca

nvmf: remove spdk_nvmf_subsytem_any_listener_allowed()

It was deprecated and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2184f5521aff8580cac6b7d26ae7bb0fec490851
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22948
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf: remove cb_fn/cb_arg from spdk_nvmf_qpair_disconnect()

These were deprecated for a long time, so it's finally time to remove
them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Chan

nvmf: remove cb_fn/cb_arg from spdk_nvmf_qpair_disconnect()

These were deprecated for a long time, so it's finally time to remove
them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia10242b36c3560df4dae8f6bd9fd4ff931179e22
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22945
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf: deprecate spdk_nvmf_request_exec_fabrics()

This function served two purposes:

1) It allowed non-fabrics transports to execute fabrics commands, as
spdk_nvmf_request_exec() did not allow

nvmf: deprecate spdk_nvmf_request_exec_fabrics()

This function served two purposes:

1) It allowed non-fabrics transports to execute fabrics commands, as
spdk_nvmf_request_exec() did not allow it.
2) It didn't do the checks performed by nvmf_check_subsystem_active(),
which allowed transports to execute commands before qpair's state
was set to ACTIVE.

1) is no longer true, as spdk_nvmf_request_exec() was recently changed
to allow non-fabrics transports to execute fabrics commands and 2) can
be worked around in other ways, e.g. by a spdk_thread_send_msg(), which
is what the vfio-user transport will now do to send the CONNECT command.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I712a006296e661a1c3de5dfd003cde9503209bf5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22130
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf/tcp: use keyring for retrieving PSKs

It is now possible to retrieve TLS PSKs from the keyring. The previous
method of specifying a path to a file containing the key is still
functional, but it

nvmf/tcp: use keyring for retrieving PSKs

It is now possible to retrieve TLS PSKs from the keyring. The previous
method of specifying a path to a file containing the key is still
functional, but it's deprecated and will be removed in the future.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iea1ff6918056f910f0fc3e030886cdba1e24b7e9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21757
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme/tcp: use keyring to pass TLS PSKs

The previous method using spdk_nvme_ctrlr_opts.psk is still functional,
but is deprecated and will be removed in the future.

Signed-off-by: Konrad Sztyber <ko

nvme/tcp: use keyring to pass TLS PSKs

The previous method using spdk_nvme_ctrlr_opts.psk is still functional,
but is deprecated and will be removed in the future.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ief3531801639d34f6b0a4e09c8eb09882a84e58d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21745
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

lib/init: deprecate spdk_subsystem_init_from_json_config

Change-Id: If03fe50ad45a923c129e8113c753fbe5b3a4db82
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.s

lib/init: deprecate spdk_subsystem_init_from_json_config

Change-Id: If03fe50ad45a923c129e8113c753fbe5b3a4db82
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21322
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

lib/rpc: deprecate server related functions

Mark spdk_rpc_accept, spdk_rpc_listen and spdk_rpc_close as deprecated.

Skip adding deprecated log to spdk_rpc_accept to avoid cluttering SPDK
logs, beca

lib/rpc: deprecate server related functions

Mark spdk_rpc_accept, spdk_rpc_listen and spdk_rpc_close as deprecated.

Skip adding deprecated log to spdk_rpc_accept to avoid cluttering SPDK
logs, because this function is called multiple times during
application lifetime.

Change-Id: Ida731112261b1304a98ae38e5cd58f860f8d6f00
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21319
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

deprecation: push any 24.01 entries to 24.05

Some of the removals were not followed through
for SPDK 24.01 release.

Move the notices one release forward to match the
actual state of the APIs.

Whil

deprecation: push any 24.01 entries to 24.05

Some of the removals were not followed through
for SPDK 24.01 release.

Move the notices one release forward to match the
actual state of the APIs.

While here fixed minor formatting issue and
made sure that level 4 headers match tags from
the deprecation function.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ia99d0980f31df854aaf2fc1b9c5f8a5737d62290
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21572
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...