autorun_post: aggregate asan and ubsan tables using any

Use "any" to aggregate "With ASAN" and "With UBSAN" tables
for test completions by agent and by test documents.
This makes reporting result in

autorun_post: aggregate asan and ubsan tables using any

Use "any" to aggregate "With ASAN" and "With UBSAN" tables
for test completions by agent and by test documents.
This makes reporting result in boolean (True/False) format
instead of 1/0 values.

Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Change-Id: I64d3c4a170ca69e058e253f6ba4c9b1d6bbf7fa9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21976
Reviewed-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Marek Chomnicki <marek.chomnicki@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>

show more ...

autorun_post: Adjust .check_call() arguments

Don't set std{out,err} to a PIPE to make sure a child process
(lcov and/or genhtml) doesn't block indefinitely as per subprocess
doc:

"Note: Do not us

autorun_post: Adjust .check_call() arguments

Don't set std{out,err} to a PIPE to make sure a child process
(lcov and/or genhtml) doesn't block indefinitely as per subprocess
doc:

"Note: Do not use stdout=PIPE or stderr=PIPE with this function.
The child process will block if it generates enough output to a
pipe to fill up the OS pipe buffer as the pipes are not being
read from."

The above scenario may happen even when genhtml is not failing,
but still reporting warnings to stderr.

To avoid that, keep std{out,err} connected to the active tty - this
way we also won't miss any warnings lcov, genhtml might report.

Also, drop the shell=True - there's simply no need to execute lcov,
genhtml under an extra sh process.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I01372c2d7d8b70c90639419859fa76ad2b7ebd5c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16772
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

Add SPDX header to various files

They were missed by the initial set of patches which introduced this
header as a mandatory one across different types of files.

Signed-off-by: Michal Berger <michal

Add SPDX header to various files

They were missed by the initial set of patches which introduced this
header as a mandatory one across different types of files.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I3f9b37d41298c843e1648e72fe8593768ccd37e0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15423
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

post_process: fix pylint W1732,W1705,W1722

Fix pylint findings:
- R1732 consider-using-with
- R1705 no-else-return
- R1722 consider-using-sys-exit

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.c

post_process: fix pylint W1732,W1705,W1722

Fix pylint findings:
- R1732 consider-using-with
- R1705 no-else-return
- R1722 consider-using-sys-exit

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.com>
Change-Id: If409c34f2ab8712e3fb1ac25b1c297d7e75c38fb
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12139
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

post_process: add summary to completion table

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.com>
Change-Id: I8aaae248840151607675ca61441d0a091c16a25c
Reviewed-on: https://review.spdk.io/gerrit/c/

post_process: add summary to completion table

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.com>
Change-Id: I8aaae248840151607675ca61441d0a091c16a25c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11801
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

post_process: simplify highest value function

This logic is just what "any" does.

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.com>
Change-Id: Id6384e7e284dfabb73f9ecfbc10c40643c3c5177
Reviewed

post_process: simplify highest value function

This logic is just what "any" does.

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.com>
Change-Id: Id6384e7e284dfabb73f9ecfbc10c40643c3c5177
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11490
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

post_process: clearly delineate the beginning os script output.

This is a companion change to
https://review.spdk.io/gerrit/c/build_pool/jenkins_build_pool/+/1810
and the two should be merged togeth

post_process: clearly delineate the beginning os script output.

This is a companion change to
https://review.spdk.io/gerrit/c/build_pool/jenkins_build_pool/+/1810
and the two should be merged together to make sure the entire output
of the post process script is included in one file when output from
the CI.

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: Ia6506208881f5d745ff63a356d3965426449ecc7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1811
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

test/post_process.py: Don't print coverage info to separate file.

We already have the post process log readily available. Put the
info there to avoid hiding the coverage errors in an obscure second

test/post_process.py: Don't print coverage info to separate file.

We already have the post process log readily available. Put the
info there to avoid hiding the coverage errors in an obscure second
file.

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: I2fe9f79403ca1accccc207155f8d0dafd4c24f8e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1790
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

autorun_post: skip confirming executed tests

Allow to skip confirmPerPatchTests if needed.

Change-Id: I8741d80de5cac9954e3429b951a71dc065c40bb5
Signed-off-by: Karol Latecki <karol.latecki@intel.com

autorun_post: skip confirming executed tests

Allow to skip confirmPerPatchTests if needed.

Change-Id: I8741d80de5cac9954e3429b951a71dc065c40bb5
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/483016
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Seth Howell <seth.howell@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

autorun_post: fail if not all per-patch tests ran.

This will keep us honest with our testing strategy and help prevent us
from unintentionally skipping tests.

Change-Id: Ie9dda265b48814c5e8aafe0504

autorun_post: fail if not all per-patch tests ran.

This will keep us honest with our testing strategy and help prevent us
from unintentionally skipping tests.

Change-Id: Ie9dda265b48814c5e8aafe0504205310b886eea9
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477981
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>

show more ...

autorun_post: add a file for tests we don't run.

Change-Id: I8beac9959d08026ee984833d0e90ec17381a66e5
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/sp

autorun_post: add a file for tests we don't run.

Change-Id: I8beac9959d08026ee984833d0e90ec17381a66e5
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478240
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

test: report test domains for tests.

This will allow us to run test cases under multiple suites without
clogging up the logs too much, but it will also preserve information
about which test suites w

test: report test domains for tests.

This will allow us to run test cases under multiple suites without
clogging up the logs too much, but it will also preserve information
about which test suites were run or (more importantly) not run.

Change-Id: I2434a54a0877ae36b9f84bfab8a62653ac1172f8
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477367
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>

show more ...

autorun_post: rewrite the aggregateCompletedTests function.

This whole function was just written poorly. Variables weren't named
correctly, little effort was made to use proper python programming
co

autorun_post: rewrite the aggregateCompletedTests function.

This whole function was just written poorly. Variables weren't named
correctly, little effort was made to use proper python programming
constructs, and there was a lot of redundant code in the function that
didn't do any good.

And I can say that because I wrote it.

Change-Id: I08576698d99c35c43348b61762791415f79eebf2
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477979
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

test/autorun_post: fix ubsan reporting.

Change-Id: I7bfe785b355ec925d28d8c306395733945a7b5d0
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+

test/autorun_post: fix ubsan reporting.

Change-Id: I7bfe785b355ec925d28d8c306395733945a7b5d0
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477366
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>

show more ...

Check file permissions in the check_format script

Change-Id: I572b24b2f4f149333f2e4b04f6f4961de9c23373
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/

Check file permissions in the check_format script

Change-Id: I572b24b2f4f149333f2e4b04f6f4961de9c23373
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/427539
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>

show more ...

post_process: print coverage tables in a new directory

Change-Id: I2d9a53456f5ca1da5607a4f7bd47017026e8f996
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.i

post_process: print coverage tables in a new directory

Change-Id: I2d9a53456f5ca1da5607a4f7bd47017026e8f996
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/422850
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

test: add output tables to autotest_post.py

These output tables will help show graphically which tests are being run
where, and which ones are being tested with ASAN and UBSAN enabled.

Change-Id: I

test: add output tables to autotest_post.py

These output tables will help show graphically which tests are being run
where, and which ones are being tested with ASAN and UBSAN enabled.

Change-Id: Ia11657d4468f1ed41ab13b3241893ce09e949668
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/421556
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

autorun_post: save aggregated test completion list to file

First save the list of run / not run tests to file for
easier re-use later and then print to screen.

Change-Id: I1cb4ea057a75f08cac4385329

autorun_post: save aggregated test completion list to file

First save the list of run / not run tests to file for
easier re-use later and then print to screen.

Change-Id: I1cb4ea057a75f08cac43853299f509d03b299709
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/405222
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

autorun_post: clean up cov_total.info files

These aren't needed after the combined coverage information is
generated.

Change-Id: I4769cdf471b2b7a6502c3466ffb317c8435f1e3d
Signed-off-by: Daniel Verk

autorun_post: clean up cov_total.info files

These aren't needed after the combined coverage information is
generated.

Change-Id: I4769cdf471b2b7a6502c3466ffb317c8435f1e3d
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/403748
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

autorun_post: collect one instance of ut_coverage

Change-Id: I10c8b17cb160d8ae70a6f1042218aa24f009ceab
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.

autorun_post: collect one instance of ut_coverage

Change-Id: I10c8b17cb160d8ae70a6f1042218aa24f009ceab
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/403740
Reviewed-by: Seth Howell <seth.howell5141@gmail.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

autorun_post: refactor doc collection function

This will be useful for other directories where we only want to keep one
copy.

Change-Id: Iac3cf964936e03c1164ffd961cf8c35a24db5f31
Signed-off-by: Dan

autorun_post: refactor doc collection function

This will be useful for other directories where we only want to keep one
copy.

Change-Id: Iac3cf964936e03c1164ffd961cf8c35a24db5f31
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/403739
Reviewed-by: Seth Howell <seth.howell5141@gmail.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

autorun_post: use absolute paths for lcov

Ubuntu LTS 16.04 has lcov 1.12 which is bugged: when
using relative paths for -a and -o lcov parameters command the
result is "error: cannot write / read fi

autorun_post: use absolute paths for lcov

Ubuntu LTS 16.04 has lcov 1.12 which is bugged: when
using relative paths for -a and -o lcov parameters command the
result is "error: cannot write / read file X".
Using absolute paths solves this issue.

Change-Id: If73a62335b75381ce944969723cfdca84aaff7bf
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/403679
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

test/autorun_post: list tests that ran

In addition to listing the tests that did not run, add a list of the
tests that did run.

Change-Id: Idf8b3583214a5e05c2d7f1a89a2ea60a2ef68432
Signed-off-by: D

test/autorun_post: list tests that ran

In addition to listing the tests that did not run, add a list of the
tests that did run.

Change-Id: Idf8b3583214a5e05c2d7f1a89a2ea60a2ef68432
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/402389
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Seth Howell <seth.howell5141@gmail.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

autotest: add test completion tracking

Change-Id: I1ca0578a010db2ff8535505bfd981cd1c368e403
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/392240
Tested-

autotest: add test completion tracking

Change-Id: I1ca0578a010db2ff8535505bfd981cd1c368e403
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/392240
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

pep8: re-enable E302 (2 blank lines between functions)

This isn't a significant effort to fix, so let's just enable it to move
closer to the official Python PEP 8 guidelines.

Fix up the existing in

pep8: re-enable E302 (2 blank lines between functions)

This isn't a significant effort to fix, so let's just enable it to move
closer to the official Python PEP 8 guidelines.

Fix up the existing instances where we didn't already have two lines
between functions, and re-enable the pep8 warning.

Change-Id: I9cf5e7e32b9c6dfedbd1b0f9bc92951cbb2c8a0d
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/399949
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

show more ...