app/trace: emit owner descriptions

Now that we have a real description for an event's owner, print those
descriptions instead of the old owner_type prefix + poller_id.

Note that we need to take the

app/trace: emit owner descriptions

Now that we have a real description for an event's owner, print those
descriptions instead of the old owner_type prefix + poller_id.

Note that we need to take the event's tsc into account, if it is older than
when the associated owner was registered we should not print the description
because it is for an owner that was unregistered after the event was
generated.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I9257306b5fe9fd7273abcb9b14e4fc136c417742
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22648
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: rename trace_event's poller_id to owner_id

"poller_id" was sort of a very early and crude attempt at associating
trace events with who generated them. The new "owner" concept is replacing
tha

trace: rename trace_event's poller_id to owner_id

"poller_id" was sort of a very early and crude attempt at associating
trace events with who generated them. The new "owner" concept is replacing
that, so just rename the existing "poller_id" to "owner_id".

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Icd61e39c5225030690ef0238cd0b3a90846fcc6b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22647
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

app/trace: fix for trace_print()

This patch fixes issue introduced in patch 22642.

If lcore is defined in trace_print() and initialized with
SPDK_TRACE_MAX_LCORE, the 'if' statement inside 'for'
lo

app/trace: fix for trace_print()

This patch fixes issue introduced in patch 22642.

If lcore is defined in trace_print() and initialized with
SPDK_TRACE_MAX_LCORE, the 'if' statement inside 'for'
loop is always true and trace size is printed for
every lcore. This is not intended use of this
function - if the user passes the lcore number
as a command line parameter, only this lcore shall
be printed. We need to propagate lcore number from
main(), where it is parsed and assigned, to the
trace_print().

Change-Id: I5c84da7da7df39c88ac52ba4ffaea8a518de77c6
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22829
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

spdk_trace: refactor output format handling

Fix inappropriate output when json option is given.
For further flexibility, refactors output formatting process to switch
statement.
This would simplify

spdk_trace: refactor output format handling

Fix inappropriate output when json option is given.
For further flexibility, refactors output formatting process to switch
statement.
This would simplify adding new output format, such as Jaeger.

Fixes issue #3326.

Change-Id: Ibcf3e1821d16f20550a970f701b32ab79fc501a0
Signed-off-by: Yongjin Lee <yong7.lee@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22642
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: rename owner to owner_type

We will be adding the real concept of an "owner" in upcoming patches. So change
the existing "owner" to "owner_type" which more accurate reflects its meaning.
For e

trace: rename owner to owner_type

We will be adding the real concept of an "owner" in upcoming patches. So change
the existing "owner" to "owner_type" which more accurate reflects its meaning.
For example, an "owner_type" can be OWNER_BDEV, but an actual "owner" would
be some specific bdev identified by its name.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ieb25eb5a574a88b3812291f2345796e5bb66a54f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22645
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

spdk_trace: default on Linux to newest trace file in /dev/shm

It is kind of a pain to have to *always* have to specify the filename
or app parameters to spdk_trace, especially when you have the app

spdk_trace: default on Linux to newest trace file in /dev/shm

It is kind of a pain to have to *always* have to specify the filename
or app parameters to spdk_trace, especially when you have the app currently
running or the app just exited.

So use ntfw() to walk the files in /dev/shm when -f and -s are not specified,
and use the newest file (assuming one is found).

A few caveats:
1) This only works on Linux, mainly because FreeBSD does not have a /dev/shm
mount for shm files.
2) Search /dev/shm is not foolproof, since we don't know for sure whether a
file there is an SPDK trace file. But looking for the "_trace." substring
should be enough. It should guard against trying to use other non-trace
files.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: If130e6f5918a228b6f9d4576e16d37e05bfc4995
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22104
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

trace_parser: add flag for arguments used for related objects

Some tracepoints have an argument that is a context pointer for some other
object type. The trace app already decode this information, s

trace_parser: add flag for arguments used for related objects

Some tracepoints have an argument that is a context pointer for some other
object type. The trace app already decode this information, showing the ID for
that related object.

Since the ID is already shown, the context pointer itself isn't useful, so
add a flag to note those arguments, so we can omit printing the context
pointer.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I3f6521ff5594cdc4c635c23a612c8f0d2f3717dd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22102
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

trace_parser: put argument union into a struct

A future patch will add a per-argument field separate from the argument types,
so put that argument union into a struct now to prepare for that future

trace_parser: put argument union into a struct

A future patch will add a per-argument field separate from the argument types,
so put that argument union into a struct now to prepare for that future
patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ia2aaa5b53332c2c04d731358a07ea99bd7e9ec44
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22101
Community-CI: Mellanox Build Bot
Reviewed-by: Seung yeon Shin <syeon.shin@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: merge spdk_trace_flags into spdk_trace_file

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8a070f986825de2470d5873eaeed3849d36bf1af
Reviewed-on: https://review.spdk.io/gerrit/

trace: merge spdk_trace_flags into spdk_trace_file

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8a070f986825de2470d5873eaeed3849d36bf1af
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21790
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

lib/trace : Display names for user created threads

Names for the user created threads are displayed in the
trace logs.

Change-Id: I0030df05276ab8c3583d10effdfb54bed6d3c28a
Signed-off-by: Krishna Ka

lib/trace : Display names for user created threads

Names for the user created threads are displayed in the
trace logs.

Change-Id: I0030df05276ab8c3583d10effdfb54bed6d3c28a
Signed-off-by: Krishna Kanth Reddy <krish.reddy@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21713
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

spdk_trace: align "N/A" similar to valid IDs

Without this change, output for trace points with
an unknown ID something like this (truncated to reduce
overall width):

TCP_REQ_RDY_TO_EXECUTE

spdk_trace: align "N/A" similar to valid IDs

Without this change, output for trace points with
an unknown ID something like this (truncated to reduce
overall width):

TCP_REQ_RDY_TO_EXECUTE id: N/Aqpair: 0xaaaaed7c1770

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Id4962e2caf35fb838604d5290359637f2bebdfd5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18867
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...

check_format: For C files only, fix return type breaks

In SPDK, declarations have the return type on the same line. Definitions
have the return type on a separate line. Astyle has an option for
enfo

check_format: For C files only, fix return type breaks

In SPDK, declarations have the return type on the same line. Definitions
have the return type on a separate line. Astyle has an option for
enforcing this. Unfortunately, it seems to have two bugs:

1) It doesn't work correctly at all on C++ files.
2) It often fails on functions that return enums, or long type names

Deal with 1) by adjusting the check_format.sh script to only tell astyle
to fix return type line breaks for C files and not C++. Deal with 2) by
adding a few typedefs to work around the problem.

Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in every source file. This patch replaces
the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause
identifier.

Almost all of these files share the exact same license text,
and this patch only modifies the files that contain the
most common license text. There can be slight variations
because the third clause contains company names - most say
"Intel Corporation", but there are instances for Nvidia,
Samsung, Eideticom and even "the copyright holder".

Used a bash script to automate replacement of the license text
with SPDX identifier which is checked into scripts/spdx.sh.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: <qun.wan@intel.com>

show more ...

add USDT tracepoints for interrupt wakeups

With these we can write a simple bpftrace script to identify work being done,
and in particular what woke us up from sleeping.

Signed-off-by: John Levon <

add USDT tracepoints for interrupt wakeups

With these we can write a simple bpftrace script to identify work being done,
and in particular what woke us up from sleeping.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I8997d847625ee4558092dbd753e6fc1b17beca92
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9424
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

app/trace: include relation information while printing json

Add relation information to printed json traces to later read them
in trace.py.

Change-Id: I090b7ffa2b85da00b6ad57825c7208dd5cfc396a
Sign

app/trace: include relation information while printing json

Add relation information to printed json traces to later read them
in trace.py.

Change-Id: I090b7ffa2b85da00b6ad57825c7208dd5cfc396a
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9637
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@gmail.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

trace: enable adding relations between traces

Currently we do not have any way to connect traces from different
modules in SPDK. This change modifies our trace library
and app/trace to handle adding

trace: enable adding relations between traces

Currently we do not have any way to connect traces from different
modules in SPDK. This change modifies our trace library
and app/trace to handle adding relations between trace points
and a trace object.

Additionally this patch adds classes and fields to structs
inside trace.py to prepare it for future patches implementing
printing relation information.

Change-Id: Ia09d01244d923957d589fd37e6d4c98f9f7bbd07
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9620
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@gmail.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

app/trace: use trace_parse library to process traces

Removed code that was copied to the trace_parse library and replaced
with calls to that library. This significantly reduces the size of the
appl

app/trace: use trace_parse library to process traces

Removed code that was copied to the trace_parse library and replaced
with calls to that library. This significantly reduces the size of the
application (LOC), as it's only responsible for formatting the traces
and pretty-printing them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib9f4e65f9f0072fb00bfa60cece1ce0627f109a0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9436
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

app/trace: assert history ptr

This is just assert to assure the Klocwork
static analizer that ptr is not NULL.

Change-Id: I458af194991fb1874fb7d32db55513a1f66408c0
Signed-off-by: Liu Xiaodong <xiao

app/trace: assert history ptr

This is just assert to assure the Klocwork
static analizer that ptr is not NULL.

Change-Id: I458af194991fb1874fb7d32db55513a1f66408c0
Signed-off-by: Liu Xiaodong <xiaodong.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8745
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: <dongx.yi@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot

show more ...

app/trace: Use PRIu64 for portability

POSIX defines PRId64/PRIu64/PRIx64 for printing 64-bit values in a
portable way. Replace a reference to %lu to remove the assumption
about the size of a long.

app/trace: Use PRIu64 for portability

POSIX defines PRId64/PRIu64/PRIx64 for printing 64-bit values in a
portable way. Replace a reference to %lu to remove the assumption
about the size of a long.

Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
Change-Id: I5696bcdb3add3d8b9d5ea91d9bc50b1dad1fbc95
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8685
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>

show more ...

app/trace: print arguments from chained entries

The trace app has been extended to parse chained entries when printing
arguments that exceed the size of a single trace entry.

Signed-off-by: Konrad

app/trace: print arguments from chained entries

The trace app has been extended to parse chained entries when printing
arguments that exceed the size of a single trace entry.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib9705fd08da998bea39f14eaa83305a8e9d0d5a8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8406
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

app/trace: added an option to print traces as JSON

Added an option, `-j`, which will cause the spdk_trace to print traces
in JSON format. The JSON output's structure is similar to the binary
SPDK t

app/trace: added an option to print traces as JSON

Added an option, `-j`, which will cause the spdk_trace to print traces
in JSON format. The JSON output's structure is similar to the binary
SPDK trace format, i.e. tracepoint definitions are printed at the
beginning, followed by trace entries. This allows us to reduce the size
of the output a bit, as we don't need to print all tracepoint properties
for each entry.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I22fd4bee72c0d214a3444ce62d0651fabd489f5a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8104
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

app/trace: remove the -q (quiet) option

The application doesn't do anything useful when started with this
option, so there's no point in keeping it.

Signed-off-by: Konrad Sztyber <konrad.sztyber@in

app/trace: remove the -q (quiet) option

The application doesn't do anything useful when started with this
option, so there's no point in keeping it.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2fca31fc7ccca11fc44a7f9a7a7b83d7634048d7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8103
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>

show more ...

app/trace: move stats update out of print_event

It'll make it a bit easier to support printing traces in different
formats.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I33d4

app/trace: move stats update out of print_event

It'll make it a bit easier to support printing traces in different
formats.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I33d454868fe7975ce81046823e3a3b9b6f587b0f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8102
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

app/trace: print tpoint arguments at the end of a line

Now that each tracepoint can have more than one argument, we cannot pad
the missing ones, as it would take too much space. Therefore, we put
t

app/trace: print tpoint arguments at the end of a line

Now that each tracepoint can have more than one argument, we cannot pad
the missing ones, as it would take too much space. Therefore, we put
them at the end of a line and simply skip the missing ones.

Additionally, since empty arguments are no longer padded, this patch
stops recording arguments with names consisting of an empty string
(containing just '\0').

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5199a3219a31d6afd3178324a4f48563b84e6149
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7958
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...