include stdio.h for sscanf() snprintf()

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

Add --contimeout functionality.

Input from deraadt@

OK claudio@

Replace Id: tags with OpenBSD: tags
OK deraadt@

Error out on memory failures in fargs_cmdline() and addargs() in both
cases it was impossible to start the remote rsync anyway. Also now
fargs_cmdline() can no longer fail. Add missing err(ERR_IPC, "

Error out on memory failures in fargs_cmdline() and addargs() in both
cases it was impossible to start the remote rsync anyway. Also now
fargs_cmdline() can no longer fail. Add missing err(ERR_IPC, "pldege")
for the cases in socket.c
OK benno@

show more ...

Add option to suppress the Message of the Day

Fine deraadt@

Handle EADDRNOAVAIL from connect(2) gracefully

The server's DNS name may yield multiple addresses of different address
families; in case the local client has no suitable address, i.e. connect(2)
fa

Handle EADDRNOAVAIL from connect(2) gracefully

The server's DNS name may yield multiple addresses of different address
families; in case the local client has no suitable address, i.e. connect(2)
fails with EADDRNOTAVAIL, do not fail hard but try the next address instead.

Report (IPv6 only client with dualstack server) and diff from Sasha Romijn.

OK job

show more ...

Only print the message of the day in the rsyncd header if rsync is
started with -v. In normal operation rsync should only print errors.
OK benno@ deraadt@

Add --address argument to openrsync to bind to the specified address
when connecting to a rsync daemon.
OK deraadt@ benno@ naddy@ sthen@

Don't close the socket in rsync_socket() itself but after calling it.
Fixes a corner case where the socket was closed twice, reported by
Hiltjo Posthuma.
ok deraadt@

remove sess argument from all functions that only used it for logging
functions.
ok deraadt@

remove sess argument from log functions. ok deraadt@

Add ability to combine rsync:// and -e by splitting rsync_socket()
into two functions, rsync_connect() to establish a TCP connection
to the remote daemon, and rsync_socket() to run the actual protoco

Add ability to combine rsync:// and -e by splitting rsync_socket()
into two functions, rsync_connect() to establish a TCP connection
to the remote daemon, and rsync_socket() to run the actual protocol.

E.g.:
rsync -av --del -e 'ssh -W localhost:rsync -lanoncvs' \
rsync://anoncvs.spacehopper.org/OpenBSD-CVS/ /cvs

ok deraadt@

show more ...

indents and reflows around ERR*() and LOG*(); ok benno

repair exit codes, slightly broken after last commit (please do not go
to an enum, that's just alien). Documents the return values in each
function and unifies the protocol incompatibility error mes

repair exit codes, slightly broken after last commit (please do not go
to an enum, that's just alien). Documents the return values in each
function and unifies the protocol incompatibility error message.
from kristaps

show more ...

Simplify startup code, various phases are heading straight towards exit
so they don't need to be constructed to return errors.
ok benno florian

new attempt to sync with kristaps up to Sun Feb 17 2019

339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.

baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all argument

new attempt to sync with kristaps up to Sun Feb 17 2019

339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.

baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
common -av usage. Remove bits about not supporting anything but
files/dirs.

821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@

6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string

4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM. From deraadt@. Tweaked for lowercase messages.

f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller. Also keep the original line lengths. While in mktemp.c, make
some defines into an enum.

e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function. Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.

c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking. This frees us of deadlocking the protocol because
the sender will always be able to pull down data.

93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD. Most found by deraadt@.

show more ...

revert previous

sync with kristaps up to Sun Feb 17 2019

339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.

baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
commo

sync with kristaps up to Sun Feb 17 2019

339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.

baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
common -av usage. Remove bits about not supporting anything but
files/dirs.

821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@

6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string

4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM. From deraadt@. Tweaked for lowercase messages.

f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller. Also keep the original line lengths. While in mktemp.c, make
some defines into an enum.

e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function. Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.

c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking. This frees us of deadlocking the protocol because
the sender will always be able to pull down data.

93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD. Most found by deraadt@.

show more ...

Add support for --port=PORT and ":port" in the rsync:// URL.
real rsync only supports numbers, but this supports service names also
ok florian benno

more yoda repairs

percolate exit code from deeper code, so that values other than 1 are
possible on failure.
looked at by florian

Has to be SOCK_STREAM obviously

use service "rsync" rather than "873"

getaddrinfo doesn't imply "DNS", borrow terminology from ssh
ok benno