History log of /openbsd-src/sys/ntfs/ntfs_vfsops.c (Results 1 – 25 of 66)
Revision Date Author Comments
# 9593dc34 04-Sep-2024 mglocker <mglocker@openbsd.org>

Fix some spelling.

Input and ok jmc@, jsg@


# 0d297f47 11-Jan-2022 jsg <jsg@openbsd.org>

spelling
ok jmc@


# db7aa982 27-Feb-2020 mpi <mpi@openbsd.org>

Remove unused "struct proc *" argument from the following functions:

- ufs_chown() & ufs_chmod()
- ufs_reclaim()
- ext2fs_chown() & ext2fs_chmod()
- ntfs_ntget() & ntfs_ntput()
- ntfs_vgetex(), ntfs

Remove unused "struct proc *" argument from the following functions:

- ufs_chown() & ufs_chmod()
- ufs_reclaim()
- ext2fs_chown() & ext2fs_chmod()
- ntfs_ntget() & ntfs_ntput()
- ntfs_vgetex(), ntfs_ntlookup() & ntfs_ntlookupfile()

While here use `ap->a_p' directly when it is only required to re-enter
the VFS layer in order to help reducing the loop.

ok visa@

show more ...


# 41f642fc 26-Dec-2019 bluhm <bluhm@openbsd.org>

Convert struct vfsops initializer to C99 style.
OK visa@


# a8d7c3be 25-Jul-2019 cheloha <cheloha@openbsd.org>

vinvalbuf(9): tlseep -> tsleep_nsec(9); ok millert@


# 08107a0b 27-May-2018 visa <visa@openbsd.org>

Drop unnecessary `p' parameter from vget(9).

OK mpi@


# 6e880534 02-May-2018 visa <visa@openbsd.org>

Remove proc from the parameters of vn_lock(). The parameter is
unnecessary because curproc always does the locking.

OK mpi@


# 36bb23f1 28-Apr-2018 visa <visa@openbsd.org>

Clean up the parameters of VOP_LOCK() and VOP_UNLOCK(). It is always
curproc that does the locking or unlocking, so the proc parameter
is pointless and can be dropped.

OK mpi@, deraadt@


# 976e9839 10-Feb-2018 deraadt <deraadt@openbsd.org>

Syncronize filesystems to disk when suspending. Each mountpoint's vnodes
are pushed to disk. Dangling vnodes (unlinked files still in use) and
vnodes undergoing change by long-running syscalls are

Syncronize filesystems to disk when suspending. Each mountpoint's vnodes
are pushed to disk. Dangling vnodes (unlinked files still in use) and
vnodes undergoing change by long-running syscalls are identified -- and
such filesystems are marked dirty on-disk while we are suspended (in case
power is lost, a fsck will be required). Filesystems without dangling or
busy vnodes are marked clean, resulting in faster boots following
"battery died" circumstances.
Tested by numerous developers, thanks for the feedback.

show more ...


# 7efda1a1 11-Dec-2017 deraadt <deraadt@openbsd.org>

In uvm Chuck decided backing store would not be allocated proactively
for blocks re-fetchable from the filesystem. However at reboot time,
filesystems are unmounted, and since processes lack backing

In uvm Chuck decided backing store would not be allocated proactively
for blocks re-fetchable from the filesystem. However at reboot time,
filesystems are unmounted, and since processes lack backing store they
are killed. Since the scheduler is still running, in some cases init is
killed... which drops us to ddb [noted by bluhm]. Solution is to convert
filesystems to read-only [proposed by kettenis]. The tale follows:
sys_reboot() should pass proc * to MD boot() to vfs_shutdown() which
completes current IO with vfs_busy VB_WRITE|VB_WAIT, then calls VFS_MOUNT()
with MNT_UPDATE | MNT_RDONLY, soon teaching us that *fs_mount() calls a
copyin() late... so store the sizes in vfsconflist[] and move the copyin()
to sys_mount()... and notice nfs_mount copyin() is size-variant, so kill
legacy struct nfs_args3. Next we learn ffs_mount()'s MNT_UPDATE code is
sharp and rusty especially wrt softdep, so fix some bugs adn add
~MNT_SOFTDEP to the downgrade. Some vnodes need a little more help,
so tie them to &dead_vnops.

ffs_mount calling DIOCCACHESYNC is causing a bit of grief still but
this issue is seperate and will be dealt with in time.
couple hundred reboots by bluhm and myself, advice from guenther and
others at the hut

show more ...


# 9414ecb5 20-Mar-2017 jca <jca@openbsd.org>

Read the free clusters bitmap in 1MB chunks

instead of trying to read it in one go and panic in malloc(9) with large
NTFS filesystems. panic reported and fix tested by landry@


# 685efd6e 07-Sep-2016 natano <natano@openbsd.org>

Remove usermount remnants. ok tedu


# 288c69e0 01-Sep-2016 natano <natano@openbsd.org>

Remove the unused ntfs write code. ok benno beck


# 41e0c475 13-Aug-2016 guenther <guenther@openbsd.org>

Eliminate pointless casts to qaddr_t of a value being assigned to a void*

ok kettenis@ krw@ natano@ dlg@ espie@


# 26b8ec94 19-Jun-2016 natano <natano@openbsd.org>

Remove the lockmgr() API. It is only used by filesystems, where it is a
trivial change to use rrw locks instead. All it needs is LK_* defines
for the RW_* flags.

tested by naddy and sthen on package

Remove the lockmgr() API. It is only used by filesystems, where it is a
trivial change to use rrw locks instead. All it needs is LK_* defines
for the RW_* flags.

tested by naddy and sthen on package building infrastructure
input and ok jmc mpi tedu

show more ...


# 9ee302b8 22-May-2016 bluhm <bluhm@openbsd.org>

When pulling an msdos formated umass stick during mount while the
usb stack was busy, the kernel could trigger an uvm fault. There
is a race between vop_generic_revoke() and sys_mount() where vgonel

When pulling an msdos formated umass stick during mount while the
usb stack was busy, the kernel could trigger an uvm fault. There
is a race between vop_generic_revoke() and sys_mount() where vgonel()
could reset v_specinfo. Then v_specmountpoint is no longer valid.
So after sleeping, msdosfs_mountfs() could crash in the error path.
The code in the different *_mountfs() functions was inconsistent,
implement the same check everywhere.
OK krw@ natano@

show more ...


# f28dec03 26-Apr-2016 natano <natano@openbsd.org>

Populate all necessary statfs members in .vfs_statfs. cd9660, udf,
msdosfs and nfsv2 don't set f_namemax. ntfs and ext2fs don't set
f_namemeax and f_favail. fusefs doesn't set f_mntfromspec, f_favail

Populate all necessary statfs members in .vfs_statfs. cd9660, udf,
msdosfs and nfsv2 don't set f_namemax. ntfs and ext2fs don't set
f_namemeax and f_favail. fusefs doesn't set f_mntfromspec, f_favail and
f_iosize. Also, make all filesystems use copy_statfs_info(), so that all
statfs information is filled in correctly for the (sb != &mp->mnt-stat)
case.

ok stefan

show more ...


# 4b1ae25e 27-Mar-2016 bluhm <bluhm@openbsd.org>

When pulling and unmounting an umass USB stick, the file system
could end up in an inconsistent state. The fstype dependent
mp->mnt_data was NULL, but the general mp was still listed as a
valid moun

When pulling and unmounting an umass USB stick, the file system
could end up in an inconsistent state. The fstype dependent
mp->mnt_data was NULL, but the general mp was still listed as a
valid mount point. Next access to the file system would crash with
a NULL pointer dereference.
If closing the device fails, the mount point must go away anyway.
There is nothing we can do about it. Remove the workaround for the
EIO error in the general unmount code, but do not generate any error
in the file system specific unmount functions.
OK natano@ beck@

show more ...


# 937fcae7 19-Mar-2016 natano <natano@openbsd.org>

Remove the unused flags argument from VOP_UNLOCK().

torture tested on amd64, i386 and macppc
ok beck mpi stefan
"the change looks right" deraadt


# 200e77f4 17-Mar-2016 bluhm <bluhm@openbsd.org>

Set mnt_data to NULL after freeing the file system specific mount point.
OK krw@ natano@ as part of a larger diff


# a34f9cb7 05-Mar-2016 natano <natano@openbsd.org>

ntfs populates ntfs_args, not msdosfs_args; ok espie@


# 3484f39e 27-Feb-2016 natano <natano@openbsd.org>

Move mnt_maxsymlink from struct mount to struct ufsmount.

The concept of differentiating between "short" and "long" symlinks is
specific to ufs/, so it shouldn't creep into the generic fs layer.
Ins

Move mnt_maxsymlink from struct mount to struct ufsmount.

The concept of differentiating between "short" and "long" symlinks is
specific to ufs/, so it shouldn't creep into the generic fs layer.
Inspired by a similar commit to NetBSD.

While there replace all references to mnt_maxsymlinklen in ufs/ext2fs
with EXT2_MAXSYMLINKLEN, which is the constant max short symlink len for
ext2fs. This allows to get rid of some (mnt_maxsymlinklen == 0) checks
there, which is always false for ext2fs.

input and ok stefan@
ok millert@

show more ...


# 21dab745 14-Mar-2015 jsg <jsg@openbsd.org>

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@


# 0ae9dfea 16-Dec-2014 tedu <tedu@openbsd.org>

must include lock.h if you want to play with locks


# 540e394a 09-Dec-2014 doug <doug@openbsd.org>

Sprinkle in a little more mallocarray().

ok deraadt@ tedu@


123