Relax DMA restrictions on ehci(4) and xhci(4) controllers that can do
64-bit DMA.

ok mpi@, mlarkin@

remove unneeded includes; ok mpi@

Instead of passing the flags as part of a struct that's supposed to be
filled by the callee, change the usb_allocmem() API to take another
argument for the flags.

ok mpi@

Switch USB to use non-coherent buffers for data transfers. Since
the import in '99 all buffers allocated using usb_allocmem() have
been mapped COHERENT. On some ARM SoCs, where the USB controller
i

Switch USB to use non-coherent buffers for data transfers. Since
the import in '99 all buffers allocated using usb_allocmem() have
been mapped COHERENT. On some ARM SoCs, where the USB controller
is not coherent with the caches, this means the buffers were mapped
uncached. This drastically reduces the performance, especially on
reads.

We already added cache syncs before and after USB transfers, but so
far those have essentially been no-ops. Since other drivers make
use of the same allocation code, and those haven't been proven to
have correct syncs, we can't just remove the COHERENT flag.

This splits the allocation into coherent and non-coherent blocks.
All drivers who call usb_allocmem() themselves now pass a flag to
show they require coherent blocks. Onced verified that they also
work fine without coherent, or once they have been refactored, we
can remove this again.

On a ure(4) connected to an i.MX8MQ, the receive performance is
10x as fast as before. The Raspberry Pi's ethernet receive speed
doubled.

Debugged using dt(4)
Original diff from Marius Strobl
Feedback from kettenis@
Tested on an i.MX8MQ (arm64) by patrick@
Tested on a Raspberry Pi (arm64) by tobhe@
Tested on an ERL (octeon) by Janne Johansson
ok mpi@ gerhard@ tobhe@

show more ...

usb_block_allocmem() won't sleep.

ok mpi@

Use "%s", __func__ in DPRINTF() to reduce grep noise.

Replace non-functioning checks for use of the usb memory block allocator in
interrupt context with assertwaitok(), which does work.

ok dlg@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Do not overlay DMA fragment decriptors with free list handling.

This "cleverness" increase the risk of races due to caching and/or
prefetching between the HC and DMA engine. Many of the bug reports

Do not overlay DMA fragment decriptors with free list handling.

This "cleverness" increase the risk of races due to caching and/or
prefetching between the HC and DMA engine. Many of the bug reports
on bugs@ involving memory corruptions in usb_allocmem() should be
easier to diagnose when not avoided with this change.

From Marius Strobl, ok kettenis@

show more ...

Even in interrupt context curproc is not NULL.

ok miod@

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

show more ...

proc.h is way too much header for usb to handle.

- use nitems() no binary change on amd64

"reads OK" claudio@

Add DMA sync operations. Fixes problems on macppc with gcc4 because
apparently it reorders stores in a bad way. Mostly from NetBSD.

earlier diff tested by landry@ (who noticed the problems on macp

Add DMA sync operations. Fixes problems on macppc with gcc4 because
apparently it reorders stores in a bad way. Mostly from NetBSD.

earlier diff tested by landry@ (who noticed the problems on macppc)
ok deraadt@

show more ...

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code t

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

show more ...

more (*&@#$ timeout.h fallout

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

d

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

show more ...

Last part of FreeBSD/NetBSD sepcific code removal.

ok jsg@

Remove logprintf macro

put "do { } while (0)" wrappers on all the debug maroc functions

Fix a memleak on error in usb_block_allocmem(); Patrick Latifi
deraadt@ OK

Sync USB code with NetBSD.
This includes numerous fixes and paves the way for usb 2.0 support.

get rid of trailing whitespace

Use correct $NetBSD$