fix WEP on athn(4) USB hostap

Deferring installation of software crypto keys to a task context is
not needed and results in race conditions that trigger the infamous
"key not installed for sw crypto

fix WEP on athn(4) USB hostap

Deferring installation of software crypto keys to a task context is
not needed and results in race conditions that trigger the infamous
"key not installed for sw crypto" panic.

show more ...

remove unneeded includes; ok mpi@

Add _cb suffix to callback fields in struct ifmedia. Makes code
easier to read and grep as ifm_status was used in both structs
ifmediareq and ifmedia with different meaning.
OK mvs@

Use memset() to initialize struct ieee80211_rxinfo properly.

Sven Wolf noticed that scans on ral(4) are buggy ever since I added a new
field to this struct. Turns out a lot of drivers were initializ

Use memset() to initialize struct ieee80211_rxinfo properly.

Sven Wolf noticed that scans on ral(4) are buggy ever since I added a new
field to this struct. Turns out a lot of drivers were initializing fields
one-by-one, leaving any newly added fields uninitialized by default.

Affected drivers may report wrong channel numbers for received beacons.
The net80211 stack will discard such beacons, assuming they were received
on the wrong channel due to signal leakage. Scanning is broken as result.

ok miod@

show more ...

Align memory allocation for USB device drivers and USB HC drivers:

* USB device drivers use M_USBDEV instead of M_DEVBUF.
* USB HC drivers use M_USBHC instead of M_DEVBUF.

In a vanilla setup, this

Align memory allocation for USB device drivers and USB HC drivers:

* USB device drivers use M_USBDEV instead of M_DEVBUF.
* USB HC drivers use M_USBHC instead of M_DEVBUF.

In a vanilla setup, this enlarges the USB memory pool.

ok anton@

show more ...

Make athn(4) attach to the Sony UWA-BR100. Patch by martingot@protonmail

Switch athn(4) 802.11n Tx rate adaptation from MiRA to RA.

Tests:
AR5418: Uwe Werler
AR9280: kn, jmatthew, Lauri Tirkkonen, Scott Bennett, Mikolaj Kucharski
AR9285: kevlo, trondd, myself

ok deraadt@

we don't have to cast to caddr_t when calling m_copydata anymore.

the first cut of this diff was made with coccinelle using this spatch:

@rule@
type caddr_t;
expression m, off, len, cp;
@@
-m_copyd

we don't have to cast to caddr_t when calling m_copydata anymore.

the first cut of this diff was made with coccinelle using this spatch:

@rule@
type caddr_t;
expression m, off, len, cp;
@@
-m_copydata(m, off, len, (caddr_t)cp)
+m_copydata(m, off, len, cp)

i had fix it's opinionated idea of formatting by hand though, so
i'm not sure it was worth it.

ok deraadt@ bluhm@

show more ...

Fix deferred key tasks along the same lines as urtwn(4) and run(4).

athn(4) tested by stsp@, who points out that otus(4) and rsu(4) don't yet invoke
the code path to do their own key setting.

ok st

Fix deferred key tasks along the same lines as urtwn(4) and run(4).

athn(4) tested by stsp@, who points out that otus(4) and rsu(4) don't yet invoke
the code path to do their own key setting.

ok stsp@

show more ...

When athn(4) is deciding how to decrypt an incoming frame, look into the
ieee80211_node data structure to find the WPA group cipher which was
negotiated with the peer, rather than checking the wirele

When athn(4) is deciding how to decrypt an incoming frame, look into the
ieee80211_node data structure to find the WPA group cipher which was
negotiated with the peer, rather than checking the wireless interface's
configuration data.

Found while investigating a problem where WPA2+TKIP wasn't working with athn.
Problem reported by Tim Chase.

show more ...

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

Offload CCMP (WPA2) encryption and decryption to athn(4) hardware.

This reduces CPU load during traffic bursts, which is especially noticeable
on boards with relatively slow CPUs such as Alix and AP

Offload CCMP (WPA2) encryption and decryption to athn(4) hardware.

This reduces CPU load during traffic bursts, which is especially noticeable
on boards with relatively slow CPUs such as Alix and APU. For reference,
my rcc-ve boards (Intel Atom C2558) now forward ~2000pps between Ethernet
and wifi with <= 1% CPU interrupt time according to systat. Beforehand, these
boards became noticeably less responsive with fairly high interrupt and spin %.

CCMP offload is used on both PCI and USB devices (thanks kevlo@ for catching
my omission of USB devices in the first iteration of this change!)

Tested by (at least) Kevin Chadwick, tracey@, kevlo@, kili@, Ted Patterson,
David Dahlberg, and Scott Bennett.

ok tracey@ kevlo@

show more ...

Convert to tsleep_nsec(9) and use the correct timeout period in msec.

Tested by kevlo@, ok stsp@

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Make wireless drivers call if_input() only once per interrupt.

This reduces drops caused by the ifq pressure drop mechanism and hence
increases throughput. Such drops are visible with e.g. 'netstat

Make wireless drivers call if_input() only once per interrupt.

This reduces drops caused by the ifq pressure drop mechanism and hence
increases throughput. Such drops are visible with e.g. 'netstat -dnI iwm0'.

Not all affected drivers have been tested yet but these changes are largely
mechanical and should be safe. As usual, please report any regressions.

With help from dlg@ and mpi@

Problem found by robert@
Tested by robert, jmc, Tracey Emer, Matthias Schmidt, florian, Björn Ketelaars
ok mpi@

show more ...

Avoid unnecessary dynamic memory allocation in athn_usb_newauth().
Patch by Benjamin Baier
ok ratchov@ mpi@

fix whitespace

claim copyright

Move athn(4) USB devices to the open source atk9k HTC firmware.

Also fix support for AR7010 devices, fix mode hostap by properly
managing the firmware station table, and fix Tx rate reporting.

Test

Move athn(4) USB devices to the open source atk9k HTC firmware.

Also fix support for AR7010 devices, fix mode hostap by properly
managing the firmware station table, and fix Tx rate reporting.

Tested on AR7010 and AR9271 devices.

ok kevlo@

show more ...

Move common code to add/remove multicast filters to ieee80211_ioctl(9).

ok jsg@, stsp@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Add sizes to various free(9) calls. Fixing the simpler ones first.
ok natano visa

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

show more ...

Finish initial 11n support for athn(4).

The heavy lifting was done by damien@ years ago. I didn't even have
to figure out what the hardware expects, the code was already there.

This driver now supp

Finish initial 11n support for athn(4).

The heavy lifting was done by damien@ years ago. I didn't even have
to figure out what the hardware expects, the code was already there.

This driver now supports MCS 0-15 in client and hostap mode.
No Tx aggregation and no 40 MHz channels yet.

tested by vgross@, bmercer@, tb@, jmc@, Vadim Vygonets, Peter Kay
ok bmercer@ tb@ phessler@

show more ...

m_free() and m_freem() test for NULL. Simplify callers which had their own
NULL tests.

ok mpi@