userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

show more ...

reduce verbosity of usage(); keep it the same as SYNOPSIS, wrapped at 80w.
lowercase for "usage", and add -e, which was missing;

ok kettenis

per trending style, add continue to emtpy loop bodies.
ok mglocker

remove sys/file.h includes in favor of fcntl.h where needed.
ok deraadt guenther

add a variety of missing prototypes

- resolve unchecked malloc()'s; prompted by rustyBSD.
- first pass at fixing err() and exit() usage.
- document that scsi(8) returns 0 or >0.

ok krw@ otto@ (noting this code is barely worth the effo

- resolve unchecked malloc()'s; prompted by rustyBSD.
- first pass at fixing err() and exit() usage.
- document that scsi(8) returns 0 or >0.

ok krw@ otto@ (noting this code is barely worth the effort...)

show more ...

fix some leaks
ok miod@

SIGCHLD is not an errno value.

Spotted by deraadt.

Copy sendbug's editit().

OK deraadt@.

Fix another potentially unsafe instance of foo[strlen(foo) - 1] = '\0'.
OK krw

fgets(3) returns NULL on error, not 0. No functional change, but it makes
the code easier to read.
OK deraadt

remove some scsi ioctls, most importantly the ones that can reprobe the
bus. supporting these complicates the midlayer unnecessarily.

ok krw@

missing fclose(); dhill@mindcry.org

use STD{IN,OUT,ERR}_FILENO

Use absolute path for vi. OK deraadt

Check for asprintf failure. From Bruno Rohee (thank you).

Compile with -ansi by killing an inline

Fix printf format string. ok deraadt@

move junk (bad code, terrible APIs) to the only program that uses it;
millert ok

protos

use err.h

ansification

more strlcpy; most from Hans-Joerg.Hoexer@yerbouti.franken.de, a bit from me

Use STDOUT_FILENO; David at phobia dot ms

major -Wall cleanup, almost complete