Use printf("%s",prompt) rather than printf(prompt) just for paranoia's
sake.

Move last three lines (#define's) from dpme.h to partition_map.h and
tweak #include's as necessary.

Base 10 should be enough for anybody! Allowing hex and octal number
input for partition id's, partition starting points and partition
sizes is silly, especially since we never display anything but b

Base 10 should be enough for anybody! Allowing hex and octal number
input for partition id's, partition starting points and partition
sizes is silly, especially since we never display anything but base
10 numbers.

Also ensure that numbers end with a space, tab or newline.

show more ...

Use consistent 'return' idiom -- no parenthesis since that was the style
of the existing code.

On-disk partition name/types/processorid may or may not be NUL
terminated after all. So add an extra byte for a NUL in the in-memory
struct's.

Nope. Missed a couple of '{}' that could go.

Nuke another (and I hope final) batch of superfluous '{}' around single
statements.

Rework and simplify string argument parsing. All string arguments are at
most DPISTRLEN (32) characters so there is no need for fancy dynamic
growing strings. Use a DPISTRLEN long buffer and bail if

Rework and simplify string argument parsing. All string arguments are at
most DPISTRLEN (32) characters so there is no need for fancy dynamic
growing strings. Use a DPISTRLEN long buffer and bail if it fills up.

Rename get_string() to get_dpistr() and get_string_argument() to
get_dpstr_argument() to emphasize they will return strings that fit
in DPISTRLEN.

Rework & simplify a pair of their consumers - do_rename_partition() and
do_change_type() - to be more obviously identitical to each other bar
the displayed verbiage.

show more ...

Whitespace, line wrapping fixes. Nuke many superfluous '{}' around single
statements. 0 -> NULL for pointer checks.

Whitespace fixes.

No need for 'default_value' parameter for get_number_argument() since we
always pass kDefault. a.k.a. -1. Nuke kDefault since it is now unused.

Nuke unused #define MAXIOSIZE in passing.

No need for get_string_argument() parameter 'reprompt' since we
always pass it '1'.

Hoist all file opening and ioctl calls into main(), passing a pointer to
a valid map to edit(). Should enable pledging a la fdisk at some point.

Since edit() always gets a valid map (and maintains i

Hoist all file opening and ioctl calls into main(), passing a pointer to
a valid map to edit(). Should enable pledging a la fdisk at some point.

Since edit() always gets a valid map (and maintains its validity even when
'I'nitializing a new one) many checks for (map == NULL) are junked.

Remove some dances around block sizes by using DEV_BSIZE everywhere
since we don't support non-DEV_BSIZE (a.k.a. 512-byte) sectors.

Remove many superfluous #include statements.

show more ...

Remove unused global 'io_buffer'.

Run indent(1) over it and tweak the results a bit manually to look more
KNF'ish.

Change "//" comments to "/**/". Nuke really stupid ones.

Reduce namespace pollution by eliminating parameter names from forward
declarations.

Kill leading, imbedded, trailing whitespace.

Remove a bunch of ridiculous and uninformative comments like "// Defines".

#define LOFF_T off_t
#define llseek lseek
#define LOFF_T_MAX LLONG_MAX

I mean, really? Nuke'em and use off_t, lseek and LLONG_MAX.

Also make a couple of checks for overflow of off_t value more like

#define LOFF_T off_t
#define llseek lseek
#define LOFF_T_MAX LLONG_MAX

I mean, really? Nuke'em and use off_t, lseek and LLONG_MAX.

Also make a couple of checks for overflow of off_t value more likely
to work.

ok millert@

show more ...

Use normal err/errx/warn/warnx rather than handrolling new ones. Move
usage() to pdisk.c and nuke do_help() and '-h'.

ok jasper@ deraadt@

trailing whitespace

add rcs ids

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

remove a bunch of linux and NeXT defines and, in turn, -D__unix__