userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

show more ...

Check for underflow as well as overflow when scaling negative numbers.
ok millert@

Add a test case for fmt_scaled.c r1.20

no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert

Enable tests for +/-LLONG_MAX and add tests for other boundary conditions.
ok millert@

Add tests for scaled overflow and underflow and the exact overflow and
underflow boundaries for 64bit platforms. Tests for exactly under the
boundaries disabled pending fixes. ok millert@ djm@ (pre

Add tests for scaled overflow and underflow and the exact overflow and
underflow boundaries for 64bit platforms. Tests for exactly under the
boundaries disabled pending fixes. ok millert@ djm@ (previous version).

show more ...

Clean up errno handling in fmt_scaled test:
- always clear before calling function under test.
- save immediately after function under test.
- always use saved value for validation and reporting.

Clean up errno handling in fmt_scaled test:
- always clear before calling function under test.
- save immediately after function under test.
- always use saved value for validation and reporting.
- remove "fraction too big" testcase that never atually worked (but looked
like it did because the previous test's errno was never cleared).
- delete unecessary "extern int errno".

show more ...

Add missing includes to avoid implicit function declarations.

Convert quad_t to long long

require scan_scaled to set errno to EINVAL rather than ERANGE if it
encounters an invalid multiplier, like the man page says it should

"looks sensible" deraadt@, ok ian@

Repair comment ID & typo, no binary change

bullshit test; pointed out by david

Now that rounding is done properly for fractionless numbers, fix the
regression cases and add a few too.

Some more real-life regression cases.

new regression found in the wild: 1099512676352 -> 2.0T; fixed a minute ago.

errno -> err in a structure. OK deraadt@

Add a few test cases.

ok ian@

various cleanups; david says results are same

Regression for fmt_scaled() and scan_scaled().