allow fetching lists from https:// URLs too
switch user to _spamd before executing ftp(1) to fetch lists.sprinkle in some closefrom(2); ok deraadt@ beck@
Don't use .Aq for syntax elements that require ASCII "<>".Bug reported by Christian Heckendorf <mbie at ulmus dot me>, patch by me.OK jmc@ bentley@
pledge(2) spamd-setup(8)It needs these annotations, to at least run the operations next to them:stdio: malloc(3)rpath: open(2)inet: connect(2)/socket(2)proc: fork(2)exec: execvp(3)While her
pledge(2) spamd-setup(8)It needs these annotations, to at least run the operations next to them:stdio: malloc(3)rpath: open(2)inet: connect(2)/socket(2)proc: fork(2)exec: execvp(3)While here remove netinet/in.h since all we need is already in arpa/inet.h andsort the headers alphabeticallyOK beck@
show more ...
Remove NULL-checks before free(). ok tb@
Do not assume that asprintf() clears the pointer on failure, whichis non-portable. Also add missing asprintf() return value checks.OK deraadt@ guenther@ doug@
Allocate a bit more memory to reduce the change of having torealloc() which is expensive for large blacklists.
Does not need netinet/ip_ipsp.h
Replace <sys/param.h> with <limits.h> and other less dirty headers wherepossible. Annotate <sys/param.h> lines with their current reasons. Switchto PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N
Replace <sys/param.h> with <limits.h> and other less dirty headers wherepossible. Annotate <sys/param.h> lines with their current reasons. Switchto PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. ChangeMIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() wheresensible to avoid pulling in the pollution. These are the files confirmedthrough binary verification.ok guenther, millert, doug (helped with the verification protocol)
Replace "errx(1, "malloc failed")" with "err(1, NULL)" to getstandard "Cannot allocate memory" message.
Fix printing of number of whitelist entries in debug mode.
Use address-family specific lists of addr/mask entries instead ofa union that can store either ipv4 or ipv6. The old method used4x as much memory as was really needed for ipv4. The spamd-setuppr
Use address-family specific lists of addr/mask entries instead ofa union that can store either ipv4 or ipv6. The old method used4x as much memory as was really needed for ipv4. The spamd-setupprotocol has changed from: tag;message;a/m;a/m;a/m...\nto :tag;message;af;count;a/m;a/m;a/m...[af;count;a/m;a/m;a/m]\nOK phessler@ "nice" beck@
obvious reallocarray() conversions
Some missing .Pa macros in FILES sections;from Jan Stary <hans at stare dot cz>;discussed with jmc@.
remove some unnecessary sys/param.h inclusions
Change the way memory is allocated to reduce memory footprint. Loading thelarge uatraps uses now around 8 times less memory. Other cleanup includesa fast implementation of imask() (stolen from bgpd
Change the way memory is allocated to reduce memory footprint. Loading thelarge uatraps uses now around 8 times less memory. Other cleanup includesa fast implementation of imask() (stolen from bgpd), killing some unusedcode and try to estimate the memory needed in add_blacklist() to reduce therealloc() calls.Tested by many (sthen, matthieu, Stephan A. Rickauer)OK beck@, sthen@
Protect errno.OK millert
correct description of spamdb-setup blacklist only mode;fixes documentation/6083;original diff and pr from Kami Petersenok sthen
beef up the description of -D a little, and don;t imply theoption somehow terrorises spamd-setup;
-D before -d;
New option -D to daemonize spamd-setup for early bootup use. This avoidsspamd-setup hanging if there are various (network?) issues and the systemnot proceeding to multiuser so that this can be deb
New option -D to daemonize spamd-setup for early bootup use. This avoidsspamd-setup hanging if there are various (network?) issues and the systemnot proceeding to multiuser so that this can be debugged. We do not use& for startup in /etc/rc because this makes the spamd-setup a child of therc scripts after bootup (that is gross)Problem reported in PR 5864, change discussed with beck, ok millert
use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg
convert to new .Dd format;
update to describe current behaviour;with some help from millert and beck
spamd.conf lives in /etc/mail now;
123