getifaddrs() can return entries where ifa_addr is NULL. Check for this
before accessing anything in ifa_addr.
ok claudio@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Remove NULL-checks before free() and a few related dead assignments.

ok and valuable input from millert@

Wrap <rpc/*.h> so that calls go direct and the symbols are all weak.
Hide __xprt_register() and _authenticate(); truncate <rpc/svc_auth.h>

ok deraadt@

All these files include <stdlib.h>, so do not need to cast
malloc/calloc/realloc* returns.

Merge from NetBSD from 1999-03-25:"
* don't close the socket unless it was opened by the function
* note (in the comments) that the client is responsible for closing
the socket if they opened it,

Merge from NetBSD from 1999-03-25:"
* don't close the socket unless it was opened by the function
* note (in the comments) that the client is responsible for closing
the socket if they opened it, or they didn't use CLNT_DESTROY()

fixes a couple of unnecessary closing of already-closed sockets.
noted by: Matthias Drochner <M.Drochner@fz-juelich.de>"

tested by many in snaps
ok schwarze@

show more ...

insert the proper arguments into a prototype

Oracle has re-licensed sunrpc under a three-clause BSD license.
Update our sources appropriately. OK deraadt@ jsg@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Check return value of authunix_create_default(); from bret lambert
with some guidance by me; ok jaredy@

internal API newgetbroadcastnets() does not need a sock

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

ansify. ok deraadt@ jaredy@

Bit of KNF - replace (<type> *)0 and (<type> *)NULL with NULL. Pointed
out by mickey@, seconded by millert@.

ok deraadt@.

Ensure that 'addrs' is always initialized before use (from Yamamoto
Takashi).

If no broadcast networks are found then just return RPC_CANTSEND.

Eliminate perror() calls (suggested by Yamamoto Takas

Ensure that 'addrs' is always initialized before use (from Yamamoto
Takashi).

If no broadcast networks are found then just return RPC_CANTSEND.

Eliminate perror() calls (suggested by Yamamoto Takashi and seconded
by deraadt@, otto@ and millert@) and just let return values speak.

ok millert@

show more ...

Implement svc_getreq_poll(3) and friends and use poll(2) instead of select(2)
in the libc rpc code. The main difference between this and the previous
version is the use of a simple free list that si

Implement svc_getreq_poll(3) and friends and use poll(2) instead of select(2)
in the libc rpc code. The main difference between this and the previous
version is the use of a simple free list that simplifies the logic when
adding a socket to svc_pollfd. I've also added code to pack svc_pollfd
when the free list gets too big. The idea general idea is to keep
svc_pollfd as tightly packed as possible to make poll(2) efficient.
Tested by many people and OK deraadt@

show more ...

use socklen_t where needed; henning pvalchev ok

prototype cleanup

uninit variables

use getifaddrs(3) instead of SIOCGIFCONF, to avoid alignment issues.

realloc repair

avoid close(closed_socket) or close(-1); it looks disgusting in kdump

handle SIOCGIFCONF for as many interfaces as provided

use arc4random for xid generation

avoid close(-1) cases