bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPL

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

show more ...

Put the NOAOUT in one place

USE CPPFLAGS instead of CFLAGS for -D !

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRI

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

show more ...

Fix broken snprintf usage; noted in PR 47976 from Henning Petersen.
As a bonus, this removes the nonliteral format arguments.

Remove many HAVE_GCC || HAVE_PCC conditionals as the options also apply
to Clang. Add a few cases of HAVE_LLVM for -fno-strict-aliasing.

Use of non-literal format strings

gcc-4.5 is picky about potential negative indexes. appease it.

apply some -Wno-error and/or -fno-strict-aliasing.


all of this should be looked at closer, but some of them are not
very trivial.

remove most of the remaining HAVE_GCC tests that are always true in
the modern world.

Define NOAOUT if we're building for mips.

Use ${TOOL_SED} instead if plain sed in Makefiles.

Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC.

Rename MKPRIVATELIB to LIBISPRIVATE, to make it clearer that this is
a variable that is used by in-tree Makefiles to control behaviour.
(MKsomevar variables are generally intended to be controlled by

Rename MKPRIVATELIB to LIBISPRIVATE, to make it clearer that this is
a variable that is used by in-tree Makefiles to control behaviour.
(MKsomevar variables are generally intended to be controlled by the end-user)

show more ...

use -Wno-pointer-sign with GCC4.

Use MKPRIVATELIB=yes instead of providing an empty libinstall:: target and
setting NOLINT, NOPIC, NOPROFILE (etc)

Rework how MAKEVERBOSE operates:

* Don't bother prefixing commands with a line of ${_MKCMD}\
and instead rely upon "make -s". This is less intrusive on
all the Makefiles than the former. Id

Rework how MAKEVERBOSE operates:

* Don't bother prefixing commands with a line of ${_MKCMD}\
and instead rely upon "make -s". This is less intrusive on
all the Makefiles than the former. Idea from David Laight.

* Rename the variables use to print messages. The scheme now is:
_MKMSG_FOO Run _MKMSG 'foo'
_MKTARGET_FOO Run _MKMSG_FOO ${.TARGET}
From discussion with Alistair Crooks.

show more ...

support MAKEVERBOSE

PR/3343: Jonathan Stone: Errors and warnings to stderr if interactive

minor makefile delint

MKfoo=no -> NOfoo

set MKLINT=no. noted by NAKAJIMA Yoshihiro <nakayosh@kcn.ne.jp>

convert from NOxxx= to MKxxx=no.
include <bsd.own.mk> if testing a MKxxx variable.

- compile common code once (into libcommon.a), and link that in.
cut's compilation time by half!
- build a common version.c in libcommon.a
- don't build version.h - nothing uses it
- comment out th

- compile common code once (into libcommon.a), and link that in.
cut's compilation time by half!
- build a common version.c in libcommon.a
- don't build version.h - nothing uses it
- comment out the ifdef INFO and -DINFO stuff - it's always compiled in
- XXX: don't compile mopprobe with -DNODL (which actually changes the
compilation of stuff in common/*). nothing else does this, and it
meant that mopprobe would have had different behaviour. if this behaviour
is desired, a workaround can be put in place

show more ...