error: use separate tokens for characters, integers and pointers

Assisted by lint's queries 10, 14, 15.

No binary change.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: remove redundant parentheses around return value

No binary change.

error: fix lint warnings

can't happen, but gcc can't figure it out.

Don't use non-literal format strings. Split it up depending on the
number of arguments used.

Simplify

use warn/err.

counting was off, and setting things to themselves does not work very welll.

- use getopt
- use err
- add -p <filelevel> to chop levels like patch
- document all the options

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove exc

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

show more ...

pass -Wshadow

Sprinkle const.

Whitespace.

sprinkle static

Convert to raise_default_signal(3).

Support an explicit Q_error return from inquire(), which is returned
if there was an error on reading the reply.
Stops an infinite loop if you ^D the query.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove #ifndef'd __STDC__ code. ANSIfy.

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

show more ...

fix redundant and nested decls

More format string cleanup by sommerfeld.

For temporary files' pathnames, check $TMPDIR before falling back to _PATH_TMP.

remove unused extern.