PR bin/58787 telnetd - handle auto authentication better

Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from
https://github.com/cschuber/

PR bin/58787 telnetd - handle auto authentication better

Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from
https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

show more ...

telnetd: Stop defining the same variables concurrently in bss and data

auth_level and require_secure_login were defined in two places:

- global.c that picked it from headers and removed 'extern'

telnetd: Stop defining the same variables concurrently in bss and data

auth_level and require_secure_login were defined in two places:

- global.c that picked it from headers and removed 'extern'
- telnetd.c that initialized it to 0

line was defined twice: in global.c and sys_term.c with a non-zero value.
Remove the definition and initialization from sys_term.c and initialize
the variable early in main().

Detected during the build of telned with Address Sanitizer (MKSANITIZER).

Reviewed by <mrg>

show more ...

Remove unused macros.

fix wrong variable check, remove casts
http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html

Only include the headers we use and remove useless variable.

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

Remove duplicated #includes and some trailing whitespace while here.
From Slava Semushin <slava.semushin@gmail.com>

use _PATH_DEV instead of "/dev/"

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Pass -a [srrvis'd struct sockaddr] to login, so that login can record the
address where we have logged in from.

realloc pedannt

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

more cleanups

remove unused function
XXX what's the difference between #ifdef UTMPX and #ifdef SUPPORT_UTMPX

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

use bounded string op (there still are remains)

use strlcpy. minor style fixes

add some more ifdefs, so that we don't define variables we don't use.

PR/17999: FUKAUMI Naoki: Support wtmpx entries.

Fix #ifdef indentation after recent removal of #ifdef NEWINIT-code.
Patch by Brian Ginsbach.

Remove code #ifdef'd on NEWINIT (never used on NetBSD).
Sync with Cray, patch by Brian Ginsbach in private mail.

Cray-only patch (sync with cray). Patch by Brian Ginsbach in private mail.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Rename variable to avoid shadowing.

Improve whitespace a bit, per bin/13667 by Brian Ginsbach.