PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values t

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

show more ...

Put back rev. 1.20 so that nbpwd_mkdb built on 32bit time_t host generates
correct pwd.db.

merge christos-time_t

Avoid passing in the actual pw field in gettime because it might not
be the type that we think it is. Fixes cross builds.

change long -> unsigned long

remove debugging printf.

Improve error messages.

- fix initialization of dowarn [use before set, thanks luke]
- always initialize flags so that we don't have to check for it.
- use the consistent variable names in functions.

- test for too long username (from Greg Woods)
- centralize id and time_t parsing, providing better error checking of
numeric values; previously the code would accept 12foo as an expiration
or ch

- test for too long username (from Greg Woods)
- centralize id and time_t parsing, providing better error checking of
numeric values; previously the code would accept 12foo as an expiration
or change time.
- fix issue with dereferencing null flags in compat code.
- ansify, KNF

show more ...

fix cast-qual issue.

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/com

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

show more ...

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

Make almost all tools compile and run properly on non-NetBSD hosts. (In
particular, most tools now run correctly on Solaris 7.)

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attemp

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

show more ...

delint

Kill __LIBUTIL_BUILD in favor of the newly added _LIBC indicator completely;
suggested by Jason Thorpe.

Do the internal symbol renaming dance only if inside the libc build environment
so libutil won't be affected; noticed by Alistair Crooks and Allen Briggs.

Need an internal name for strsep().

const poisoning.

const poisoning.

Fix a serious symbol collision problem introduced when pw_scan() was added
to libc. Note, pw_scan() is NO LONGER exported from libc (it never should
have been, and we're just going to pretend like i

Fix a serious symbol collision problem introduced when pw_scan() was added
to libc. Note, pw_scan() is NO LONGER exported from libc (it never should
have been, and we're just going to pretend like it never was).

show more ...

* move pw_scan() from libutil to libc
* add support for YP "master.passwd.by*" (master.passwd in YP, including
pw_passwd) and "passwd.adjunct.by*" (SunOS `secure' maps (?)), based
on code in Free

* move pw_scan() from libutil to libc
* add support for YP "master.passwd.by*" (master.passwd in YP, including
pw_passwd) and "passwd.adjunct.by*" (SunOS `secure' maps (?)), based
on code in FreeBSD and partially from OpenBSD.
this is only used if euid == 0.
with this, the YP "passwd.by*" maps can have `*' in the pw_passwd field.
* use pw_scan() to parse YP "passwd.by*" and "master.passwd.by*" entries

XXX: i didn't test the "passwd.adjunct" support...

show more ...