Format string analysis: give 'q' its own enumerator.

This is in preparation for being able to warn about 'q' and other
non-standard format string features.

It also allows us to print its name corre

Format string analysis: give 'q' its own enumerator.

This is in preparation for being able to warn about 'q' and other
non-standard format string features.

It also allows us to print its name correctly.

llvm-svn: 150697

show more ...

Fix typo in PrintfConversionSpecifier::isDoubleArg()

This makes the printf diagnostics issue warnigns for %a, %A, %e, etc.
when used with the wrong argument.

llvm-svn: 150370

non-literal strftime format string is not unsafe.

llvm-svn: 150009

FormatCheckers should emit all diagnostics using EmitFormatDiagnostic().

llvm-svn: 149394

Update on format attribute handling.
- Remove the printf0 special handling as we treat it as printf anyway.
- Perform basic checks (non-literal, empty) for all formats and not only printf/scanf.

llv

Update on format attribute handling.
- Remove the printf0 special handling as we treat it as printf anyway.
- Perform basic checks (non-literal, empty) for all formats and not only printf/scanf.

llvm-svn: 149236

show more ...

Teach scanf/printf checking about '%Ld' and friends (a GNU extension). Fixes PR 9466.

llvm-svn: 148859

Tighten format string diagnostic and make it a bit clearer (and a bit closer to GCC's).

llvm-svn: 148579

Fix for PR9751 to change the behavior of -Wformat warnings. If the format
string is part of the function call, then there is no difference. If the
format string is not, the warning will point to th

Fix for PR9751 to change the behavior of -Wformat warnings. If the format
string is part of the function call, then there is no difference. If the
format string is not, the warning will point to the call site and a note
will point to where the format string is.

Fix-it hints for strings are moved to the note if a note is emitted. This will
prevent changes to format strings that may be used in multiple places.

llvm-svn: 143168

show more ...

Tweak printf format string parsing to accept 'hh' conversion specifier to accept any char, not just signed char. Fixes <rdar://problem/10303638>.

llvm-svn: 142908

Do not warn about empty format strings when there are no data arguments. Fixes <rdar://problem/9473155>.

llvm-svn: 140777

Control 'invalid conversion specifier' warnings under a subflag (-Wformat-invalid-specifier) of -Wformat. Fixes <rdar://problem/10031930>.

llvm-svn: 138686

Revert r135147 and r135075. The consensus was that this wasn't the right thing to do.

llvm-svn: 135152

Reapply r135075, but modify format-strings.c and format-strings-fixit.c test cases to be more portable with an explicit target triple.

llvm-svn: 135134

Re-relax conversion specifier checking for printf format strings and conversion specifiers. My recent change was a mistake.

llvm-svn: 135048

Fix inversion in argument type checking for format strings with conversion specifiers for character types.

llvm-svn: 135046

Don't add redundant FormatAttr, ConstAttr, or NoThrowAttr attributes,
either imlicitly (for builtins) or explicitly (due to multiple
specification of the same attributes). Fixes <rdar://problem/96120

Don't add redundant FormatAttr, ConstAttr, or NoThrowAttr attributes,
either imlicitly (for builtins) or explicitly (due to multiple
specification of the same attributes). Fixes <rdar://problem/9612060>.

llvm-svn: 133045

show more ...

Don't warn about using PredefinedExprs as format string literals. These never can be a real security issue.

Fixes PR 9314.

llvm-svn: 126447

Allow -Wformat to be enabled without -Wformat-security. GCC gates
-Wformat-security on -Wformat, not vice-versa.

Fixes PR8486. Patch by Oleg Slezberg.

llvm-svn: 126096

Add semantic checking that the "thousands grouping"
prefix in a printf format string is matched
with the appropriate conversion specifier.

llvm-svn: 123055

Add printf format string parsing support for '
prefix to format conversions (POSIX extension).

llvm-svn: 123054

Fix range in printf warnings for invalid conversion specifiers.

llvm-svn: 120735

The 'X' printf type has a valid alternative form. Fixes PR8641.

llvm-svn: 119946

Previously, the printf warnings would say your arguments type was 'int' when it was really a 'char'
or a 'short'. This fixes that and allows the hints to suggest 'h' modifiers for small ints.

Patch

Previously, the printf warnings would say your arguments type was 'int' when it was really a 'char'
or a 'short'. This fixes that and allows the hints to suggest 'h' modifiers for small ints.

Patch by Justin Bogner!

llvm-svn: 116996

show more ...

Check format strings when a called function has more than one FormatAttr (one for 'scanf' and one for 'printf'). Fixes <rdar://problem/8409437>.

llvm-svn: 113472

It appears that technically a null format string is not warned under -Wformat-nonliteral, as
the function processing the format string can decided whether or not to accept a null format string (e.g.,

It appears that technically a null format string is not warned under -Wformat-nonliteral, as
the function processing the format string can decided whether or not to accept a null format string (e.g., asl_log). Fixes <rdar://problem/8269537>.

llvm-svn: 113469

show more ...