xref: /llvm-project/clang/test/Sema/format-strings.c (revision 9bc9bcc2472373ab81a2106e5a04fc6037e19fcc)
1 // RUN: %clang_cc1 -fsyntax-only -verify -Wformat-nonliteral %s
2 
3 #include <stdarg.h>
4 typedef __typeof(sizeof(int)) size_t;
5 typedef struct _FILE FILE;
6 int fprintf(FILE *, const char *restrict, ...);
7 int printf(const char *restrict, ...); // expected-note{{passing argument to parameter here}}
8 int snprintf(char *restrict, size_t, const char *restrict, ...);
9 int sprintf(char *restrict, const char *restrict, ...);
10 int vasprintf(char **, const char *, va_list);
11 int asprintf(char **, const char *, ...);
12 int vfprintf(FILE *, const char *restrict, va_list);
13 int vprintf(const char *restrict, va_list);
14 int vsnprintf(char *, size_t, const char *, va_list);
15 int vsprintf(char *restrict, const char *restrict, va_list); // expected-note{{passing argument to parameter here}}
16 
17 char * global_fmt;
18 
19 void check_string_literal( FILE* fp, const char* s, char *buf, ... ) {
20 
21   char * b;
22   va_list ap;
23   va_start(ap,buf);
24 
25   printf(s); // expected-warning {{format string is not a string literal}}
26   vprintf(s,ap); // // no-warning
27   fprintf(fp,s); // expected-warning {{format string is not a string literal}}
28   vfprintf(fp,s,ap); // no-warning
29   asprintf(&b,s); // expected-warning {{format string is not a string lit}}
30   vasprintf(&b,s,ap); // no-warning
31   sprintf(buf,s); // expected-warning {{format string is not a string literal}}
32   snprintf(buf,2,s); // expected-warning {{format string is not a string lit}}
33   __builtin___sprintf_chk(buf,0,-1,s); // expected-warning {{format string is not a string literal}}
34   __builtin___snprintf_chk(buf,2,0,-1,s); // expected-warning {{format string is not a string lit}}
35   vsprintf(buf,s,ap); // no-warning
36   vsnprintf(buf,2,s,ap); // no-warning
37   vsnprintf(buf,2,global_fmt,ap); // expected-warning {{format string is not a string literal}}
38   __builtin___vsnprintf_chk(buf,2,0,-1,s,ap); // no-warning
39   __builtin___vsnprintf_chk(buf,2,0,-1,global_fmt,ap); // expected-warning {{format string is not a string literal}}
40 
41   // rdar://6079877
42   printf("abc"
43          "%*d", 1, 1); // no-warning
44   printf("abc\
45 def"
46          "%*d", 1, 1); // no-warning
47 
48   // <rdar://problem/6079850>, allow 'unsigned' (instead of 'int') to be used for both
49   // the field width and precision.  This deviates from C99, but is reasonably safe
50   // and is also accepted by GCC.
51   printf("%*d", (unsigned) 1, 1); // no-warning
52 }
53 
54 void check_conditional_literal(const char* s, int i) {
55   printf(i == 1 ? "yes" : "no"); // no-warning
56   printf(i == 0 ? (i == 1 ? "yes" : "no") : "dont know"); // no-warning
57   printf(i == 0 ? (i == 1 ? s : "no") : "dont know"); // expected-warning{{format string is not a string literal}}
58   printf("yes" ?: "no %d", 1); // expected-warning{{data argument not used by format string}}
59 }
60 
61 void check_writeback_specifier()
62 {
63   int x;
64   char *b;
65 
66   printf("%n",&x); // expected-warning {{'%n' in format string discouraged}}
67   sprintf(b,"%d%%%n",1, &x); // expected-warning {{'%n' in format string dis}}
68 }
69 
70 void check_invalid_specifier(FILE* fp, char *buf)
71 {
72   printf("%s%lb%d","unix",10,20); // expected-warning {{invalid conversion specifier 'b'}}
73   fprintf(fp,"%%%l"); // expected-warning {{incomplete format specifier}}
74   sprintf(buf,"%%%%%ld%d%d", 1, 2, 3); // expected-warning{{format specifies type 'long' but the argument has type 'int'}}
75   snprintf(buf, 2, "%%%%%ld%;%d", 1, 2, 3); // expected-warning{{format specifies type 'long' but the argument has type 'int'}} expected-warning {{invalid conversion specifier ';'}}
76 }
77 
78 void check_null_char_string(char* b)
79 {
80   printf("\0this is bogus%d",1); // expected-warning {{string contains '\0'}}
81   snprintf(b,10,"%%%%%d\0%d",1,2); // expected-warning {{string contains '\0'}}
82   printf("%\0d",1); // expected-warning {{string contains '\0'}}
83 }
84 
85 void check_empty_format_string(char* buf, ...)
86 {
87   va_list ap;
88   va_start(ap,buf);
89   vprintf("",ap); // expected-warning {{format string is empty}}
90   sprintf(buf, "", 1); // expected-warning {{format string is empty}}
91 
92   // Don't warn about empty format strings when there are no data arguments.
93   // This can arise from macro expansions and non-standard format string
94   // functions.
95   sprintf(buf, ""); // no-warning
96 }
97 
98 void check_wide_string(char* b, ...)
99 {
100   va_list ap;
101   va_start(ap,b);
102 
103   printf(L"foo %d",2); // expected-warning {{incompatible pointer types}}, expected-warning {{should not be a wide string}}
104   vsprintf(b,L"bar %d",ap); // expected-warning {{incompatible pointer types}}, expected-warning {{should not be a wide string}}
105 }
106 
107 void check_asterisk_precision_width(int x) {
108   printf("%*d"); // expected-warning {{'*' specified field width is missing a matching 'int' argument}}
109   printf("%.*d"); // expected-warning {{'.*' specified field precision is missing a matching 'int' argument}}
110   printf("%*d",12,x); // no-warning
111   printf("%*d","foo",x); // expected-warning {{field width should have type 'int', but argument has type 'char *'}}
112   printf("%.*d","foo",x); // expected-warning {{field precision should have type 'int', but argument has type 'char *'}}
113 }
114 
115 void __attribute__((format(printf,1,3))) myprintf(const char*, int blah, ...);
116 
117 void test_myprintf() {
118   myprintf("%d", 17, 18); // okay
119 }
120 
121 void test_constant_bindings(void) {
122   const char * const s1 = "hello";
123   const char s2[] = "hello";
124   const char *s3 = "hello";
125   char * const s4 = "hello";
126   extern const char s5[];
127 
128   printf(s1); // no-warning
129   printf(s2); // no-warning
130   printf(s3); // expected-warning{{not a string literal}}
131   printf(s4); // expected-warning{{not a string literal}}
132   printf(s5); // expected-warning{{not a string literal}}
133 }
134 
135 
136 // Test what happens when -Wformat-security only.
137 #pragma GCC diagnostic ignored "-Wformat-nonliteral"
138 #pragma GCC diagnostic warning "-Wformat-security"
139 
140 void test9(char *P) {
141   int x;
142   printf(P);   // expected-warning {{format string is not a string literal (potentially insecure)}}
143   printf(P, 42);
144   printf("%n", &x); // expected-warning {{use of '%n' in format string discouraged }}
145 }
146 
147 void torture(va_list v8) {
148   vprintf ("%*.*d", v8);  // no-warning
149 
150 }
151 
152 void test10(int x, float f, int i, long long lli) {
153   printf("%s"); // expected-warning{{more '%' conversions than data arguments}}
154   printf("%@", 12); // expected-warning{{invalid conversion specifier '@'}}
155   printf("\0"); // expected-warning{{format string contains '\0' within the string body}}
156   printf("xs\0"); // expected-warning{{format string contains '\0' within the string body}}
157   printf("%*d\n"); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
158   printf("%*.*d\n", x); // expected-warning{{'.*' specified field precision is missing a matching 'int' argument}}
159   printf("%*d\n", f, x); // expected-warning{{field width should have type 'int', but argument has type 'double'}}
160   printf("%*.*d\n", x, f, x); // expected-warning{{field precision should have type 'int', but argument has type 'double'}}
161   printf("%**\n"); // expected-warning{{invalid conversion specifier '*'}}
162   printf("%n", &i); // expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
163   printf("%d%d\n", x); // expected-warning{{more '%' conversions than data arguments}}
164   printf("%d\n", x, x); // expected-warning{{data argument not used by format string}}
165   printf("%W%d%Z\n", x, x, x); // expected-warning{{invalid conversion specifier 'W'}} expected-warning{{invalid conversion specifier 'Z'}}
166   printf("%"); // expected-warning{{incomplete format specifier}}
167   printf("%.d", x); // no-warning
168   printf("%.", x);  // expected-warning{{incomplete format specifier}}
169   printf("%f", 4); // expected-warning{{format specifies type 'double' but the argument has type 'int'}}
170   printf("%qd", lli); // no-warning
171   printf("%qd", x); // expected-warning{{format specifies type 'long long' but the argument has type 'int'}}
172   printf("%qp", (void *)0); // expected-warning{{length modifier 'q' results in undefined behavior or no effect with 'p' conversion specifier}}
173   printf("hhX %hhX", (unsigned char)10); // no-warning
174   printf("llX %llX", (long long) 10); // no-warning
175   // This is fine, because there is an implicit conversion to an int.
176   printf("%d", (unsigned char) 10); // no-warning
177   printf("%d", (long long) 10); // expected-warning{{format specifies type 'int' but the argument has type 'long long'}}
178   printf("%Lf\n", (long double) 1.0); // no-warning
179   printf("%f\n", (long double) 1.0); // expected-warning{{format specifies type 'double' but the argument has type 'long double'}}
180   // The man page says that a zero precision is okay.
181   printf("%.0Lf", (long double) 1.0); // no-warning
182   printf("%c\n", "x"); // expected-warning{{format specifies type 'int' but the argument has type 'char *'}}
183   printf("%c\n", 1.23); // expected-warning{{format specifies type 'int' but the argument has type 'double'}}
184   printf("Format %d, is %! %f", 1, 2, 4.4); // expected-warning{{invalid conversion specifier '!'}}
185 }
186 
187 typedef unsigned char uint8_t;
188 
189 void should_understand_small_integers() {
190   printf("%hhu", (short) 10); // expected-warning{{format specifies type 'unsigned char' but the argument has type 'short'}}
191   printf("%hu\n", (unsigned char) 1); // expected-warning{{format specifies type 'unsigned short' but the argument has type 'unsigned char'}}
192   printf("%hu\n", (uint8_t)1); // expected-warning{{format specifies type 'unsigned short' but the argument has type 'uint8_t'}}
193 }
194 
195 void test11(void *p, char *s) {
196   printf("%p", p); // no-warning
197   printf("%p", 123); // expected-warning{{format specifies type 'void *' but the argument has type 'int'}}
198   printf("%.4p", p); // expected-warning{{precision used with 'p' conversion specifier, resulting in undefined behavior}}
199   printf("%+p", p); // expected-warning{{flag '+' results in undefined behavior with 'p' conversion specifier}}
200   printf("% p", p); // expected-warning{{flag ' ' results in undefined behavior with 'p' conversion specifier}}
201   printf("%0p", p); // expected-warning{{flag '0' results in undefined behavior with 'p' conversion specifier}}
202   printf("%s", s); // no-warning
203   printf("%+s", p); // expected-warning{{flag '+' results in undefined behavior with 's' conversion specifier}}
204   printf("% s", p); // expected-warning{{flag ' ' results in undefined behavior with 's' conversion specifier}}
205   printf("%0s", p); // expected-warning{{flag '0' results in undefined behavior with 's' conversion specifier}}
206 }
207 
208 void test12(char *b) {
209   unsigned char buf[4];
210   printf ("%.4s\n", buf); // no-warning
211   printf ("%.4s\n", &buf); // expected-warning{{format specifies type 'char *' but the argument has type 'unsigned char (*)[4]'}}
212 
213   // Verify that we are checking asprintf
214   asprintf(&b, "%d", "asprintf"); // expected-warning{{format specifies type 'int' but the argument has type 'char *'}}
215 }
216 
217 void test13(short x) {
218   char bel = 007;
219   printf("bel: '0%hhd'\n", bel); // no-warning
220   printf("x: '0%hhd'\n", x); // expected-warning {{format specifies type 'char' but the argument has type 'short'}}
221 }
222 
223 typedef struct __aslclient *aslclient;
224 typedef struct __aslmsg *aslmsg;
225 int asl_log(aslclient asl, aslmsg msg, int level, const char *format, ...) __attribute__((__format__ (__printf__, 4, 5)));
226 void test_asl(aslclient asl) {
227   // Test case from <rdar://problem/7341605>.
228   asl_log(asl, 0, 3, "Error: %m"); // no-warning
229   asl_log(asl, 0, 3, "Error: %W"); // expected-warning{{invalid conversion specifier 'W'}}
230 }
231 
232 // <rdar://problem/7595366>
233 typedef enum { A } int_t;
234 void f0(int_t x) { printf("%d\n", x); }
235 
236 // Unicode test cases.  These are possibly specific to Mac OS X.  If so, they should
237 // eventually be moved into a separate test.
238 typedef __WCHAR_TYPE__ wchar_t;
239 
240 void test_unicode_conversions(wchar_t *s) {
241   printf("%S", s); // no-warning
242   printf("%s", s); // expected-warning{{format specifies type 'char *' but the argument has type 'wchar_t *'}}
243   printf("%C", s[0]); // no-warning
244   printf("%c", s[0]);
245   // FIXME: This test reports inconsistent results. On Windows, '%C' expects
246   // 'unsigned short'.
247   // printf("%C", 10);
248   // FIXME: we report the expected type as 'int*' instead of 'wchar_t*'
249   printf("%S", "hello"); // expected-warning{{but the argument has type 'char *'}}
250 }
251 
252 // Mac OS X supports positional arguments in format strings.
253 // This is an IEEE extension (IEEE Std 1003.1).
254 // FIXME: This is probably not portable everywhere.
255 void test_positional_arguments() {
256   printf("%0$", (int)2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
257   printf("%1$*0$d", (int) 2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
258   printf("%1$d", (int) 2); // no-warning
259   printf("%1$d", (int) 2, 2); // expected-warning{{data argument not used by format string}}
260   printf("%1$d%1$f", (int) 2); // expected-warning{{format specifies type 'double' but the argument has type 'int'}}
261   printf("%1$2.2d", (int) 2); // no-warning
262   printf("%2$*1$.2d", (int) 2, (int) 3); // no-warning
263   printf("%2$*8$d", (int) 2, (int) 3); // expected-warning{{specified field width is missing a matching 'int' argument}}
264   printf("%%%1$d", (int) 2); // no-warning
265   printf("%1$d%%", (int) 2); // no-warning
266 }
267 
268 // PR 6697 - Handle format strings where the data argument is not adjacent to the format string
269 void myprintf_PR_6697(const char *format, int x, ...) __attribute__((__format__(printf,1, 3)));
270 void test_pr_6697() {
271   myprintf_PR_6697("%s\n", 1, "foo"); // no-warning
272   myprintf_PR_6697("%s\n", 1, (int)0); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
273   // FIXME: Not everything should clearly support positional arguments,
274   // but we need a way to identify those cases.
275   myprintf_PR_6697("%1$s\n", 1, "foo"); // no-warning
276   myprintf_PR_6697("%2$s\n", 1, "foo"); // expected-warning{{data argument position '2' exceeds the number of data arguments (1)}}
277   myprintf_PR_6697("%18$s\n", 1, "foo"); // expected-warning{{data argument position '18' exceeds the number of data arguments (1)}}
278   myprintf_PR_6697("%1$s\n", 1, (int) 0); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
279 }
280 
281 void rdar8026030(FILE *fp) {
282   fprintf(fp, "\%"); // expected-warning{{incomplete format specifier}}
283 }
284 
285 void bug7377_bad_length_mod_usage() {
286   // Bad length modifiers
287   printf("%hhs", "foo"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
288   printf("%1$zp", (void *)0); // expected-warning{{length modifier 'z' results in undefined behavior or no effect with 'p' conversion specifier}}
289   printf("%ls", L"foo"); // no-warning
290   printf("%#.2Lf", (long double)1.234); // no-warning
291 
292   // Bad flag usage
293   printf("%#p", (void *) 0); // expected-warning{{flag '#' results in undefined behavior with 'p' conversion specifier}}
294   printf("%0d", -1); // no-warning
295   printf("%#n", (void *) 0); // expected-warning{{flag '#' results in undefined behavior with 'n' conversion specifier}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
296   printf("%-n", (void *) 0); // expected-warning{{flag '-' results in undefined behavior with 'n' conversion specifier}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
297   printf("%-p", (void *) 0); // no-warning
298 
299   // Bad optional amount use
300   printf("%.2c", 'a'); // expected-warning{{precision used with 'c' conversion specifier, resulting in undefined behavior}}
301   printf("%1n", (void *) 0); // expected-warning{{field width used with 'n' conversion specifier, resulting in undefined behavior}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
302   printf("%.9n", (void *) 0); // expected-warning{{precision used with 'n' conversion specifier, resulting in undefined behavior}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
303 
304   // Ignored flags
305   printf("% +f", 1.23); // expected-warning{{flag ' ' is ignored when flag '+' is present}}
306   printf("%+ f", 1.23); // expected-warning{{flag ' ' is ignored when flag '+' is present}}
307   printf("%0-f", 1.23); // expected-warning{{flag '0' is ignored when flag '-' is present}}
308   printf("%-0f", 1.23); // expected-warning{{flag '0' is ignored when flag '-' is present}}
309   printf("%-+f", 1.23); // no-warning
310 }
311 
312 // PR 7981 - handle '%lc' (wint_t)
313 #ifndef wint_t
314 typedef int __darwin_wint_t;
315 typedef __darwin_wint_t wint_t;
316 #endif
317 
318 void pr7981(wint_t c, wchar_t c2) {
319   printf("%lc", c); // no-warning
320   printf("%lc", 1.0); // expected-warning{{the argument has type 'double'}}
321   printf("%lc", (char) 1); // no-warning
322   printf("%lc", &c); // expected-warning{{the argument has type 'wint_t *' (aka 'int *')}}
323   printf("%lc", c2); // no-warning
324 }
325 
326 // <rdar://problem/8269537> -Wformat-security says NULL is not a string literal
327 void rdar8269537() {
328   // This is likely to crash in most cases, but -Wformat-nonliteral technically
329   // doesn't warn in this case.
330   printf(0); // no-warning
331 }
332 
333 // Handle functions with multiple format attributes.
334 extern void rdar8332221_vprintf_scanf(const char *, va_list, const char *, ...)
335      __attribute__((__format__(__printf__, 1, 0)))
336      __attribute__((__format__(__scanf__, 3, 4)));
337 
338 void rdar8332221(va_list ap, int *x, long *y) {
339   rdar8332221_vprintf_scanf("%", ap, "%d", x); // expected-warning{{incomplete format specifier}}
340 }
341 
342 // PR8641
343 void pr8641() {
344   printf("%#x\n", 10);
345   printf("%#X\n", 10);
346 }
347 
348 void posix_extensions() {
349   // Test %'d, "thousands grouping".
350   // <rdar://problem/8816343>
351   printf("%'d\n", 123456789); // no-warning
352   printf("%'i\n", 123456789); // no-warning
353   printf("%'f\n", (float) 1.0); // no-warning
354   printf("%'p\n", (void*) 0); // expected-warning{{results in undefined behavior with 'p' conversion specifier}}
355 }
356 
357 // PR8486
358 //
359 // Test what happens when -Wformat is on, but -Wformat-security is off.
360 #pragma GCC diagnostic warning "-Wformat"
361 #pragma GCC diagnostic ignored "-Wformat-security"
362 
363 void pr8486() {
364   printf("%s", 1); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
365 }
366 
367 // PR9314
368 // Don't warn about string literals that are PreDefinedExprs, e.g. __func__.
369 void pr9314() {
370   printf(__PRETTY_FUNCTION__); // no-warning
371   printf(__func__); // no-warning
372 }
373 
374 int printf(const char * restrict, ...) __attribute__((__format__ (__printf__, 1, 2)));
375 
376 void rdar9612060(void) {
377   printf("%s", 2); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
378 }
379 
380 void check_char(unsigned char x, signed char y) {
381   printf("%c", y); // no-warning
382   printf("%hhu", x); // no-warning
383   printf("%hhi", y); // no-warning
384   printf("%hhi", x); // no-warning
385   printf("%c", x); // no-warning
386   printf("%hhu", y); // no-warning
387 }
388 
389 // Test suppression of individual warnings.
390 
391 void test_suppress_invalid_specifier() {
392 #pragma clang diagnostic push
393 #pragma clang diagnostic ignored "-Wformat-invalid-specifier"
394   printf("%@", 12); // no-warning
395 #pragma clang diagnostic pop
396 }
397 
398 // Make sure warnings are on for next test.
399 #pragma GCC diagnostic warning "-Wformat"
400 #pragma GCC diagnostic warning "-Wformat-security"
401 
402 // Test that the printf call site is where the warning is attached.  If the
403 // format string is somewhere else, point to it in a note.
404 void pr9751() {
405   const char kFormat1[] = "%d %d \n"; // expected-note{{format string is defined here}}}
406   printf(kFormat1, 0); // expected-warning{{more '%' conversions than data arguments}}
407   printf("%d %s\n", 0); // expected-warning{{more '%' conversions than data arguments}}
408 
409   const char kFormat2[] = "%18$s\n"; // expected-note{{format string is defined here}}
410   printf(kFormat2, 1, "foo"); // expected-warning{{data argument position '18' exceeds the number of data arguments (2)}}
411   printf("%18$s\n", 1, "foo"); // expected-warning{{data argument position '18' exceeds the number of data arguments (2)}}
412 
413   const char kFormat3[] = "%n"; // expected-note{{format string is defined here}}
414   printf(kFormat3, "as"); // expected-warning{{use of '%n' in format string discouraged}}
415   printf("%n", "as"); // expected-warning{{use of '%n' in format string discouraged}}
416 
417   const char kFormat4[] = "%y"; // expected-note{{format string is defined here}}
418   printf(kFormat4, 5); // expected-warning{{invalid conversion specifier 'y'}}
419   printf("%y", 5); // expected-warning{{invalid conversion specifier 'y'}}
420 
421   const char kFormat5[] = "%."; // expected-note{{format string is defined here}}
422   printf(kFormat5, 5); // expected-warning{{incomplete format specifier}}
423   printf("%.", 5); // expected-warning{{incomplete format specifier}}
424 
425   const char kFormat6[] = "%s"; // expected-note{{format string is defined here}}
426   printf(kFormat6, 5); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
427   printf("%s", 5); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
428 
429   const char kFormat7[] = "%0$"; // expected-note{{format string is defined here}}
430   printf(kFormat7, 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
431   printf("%0$", 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
432 
433   const char kFormat8[] = "%1$d %d"; // expected-note{{format string is defined here}}
434   printf(kFormat8, 4, 4); // expected-warning{{cannot mix positional and non-positional arguments in format string}}
435   printf("%1$d %d", 4, 4); // expected-warning{{cannot mix positional and non-positional arguments in format string}}
436 
437   const char kFormat9[] = ""; // expected-note{{format string is defined here}}
438   printf(kFormat9, 4, 4); // expected-warning{{format string is empty}}
439   printf("", 4, 4); // expected-warning{{format string is empty}}
440 
441   const char kFormat10[] = "\0%d"; // expected-note{{format string is defined here}}
442   printf(kFormat10, 4); // expected-warning{{format string contains '\0' within the string body}}
443   printf("\0%d", 4); // expected-warning{{format string contains '\0' within the string body}}
444 
445   const char kFormat11[] = "%*d"; // expected-note{{format string is defined here}}
446   printf(kFormat11); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
447   printf("%*d"); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
448 
449   const char kFormat12[] = "%*d"; // expected-note{{format string is defined here}}
450   printf(kFormat12, 4.4); // expected-warning{{field width should have type 'int', but argument has type 'double'}}
451   printf("%*d", 4.4); // expected-warning{{field width should have type 'int', but argument has type 'double'}}
452 
453   const char kFormat13[] = "%.3p"; // expected-note{{format string is defined here}}
454   void *p;
455   printf(kFormat13, p); // expected-warning{{precision used with 'p' conversion specifier, resulting in undefined behavior}}
456   printf("%.3p", p); // expected-warning{{precision used with 'p' conversion specifier, resulting in undefined behavior}}
457 
458   const char kFormat14[] = "%0s"; // expected-note{{format string is defined here}}
459   printf(kFormat14, "a"); // expected-warning{{flag '0' results in undefined behavior with 's' conversion specifier}}
460   printf("%0s", "a"); // expected-warning{{flag '0' results in undefined behavior with 's' conversion specifier}}
461 
462   const char kFormat15[] = "%hhs"; // expected-note{{format string is defined here}}
463   printf(kFormat15, "a"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
464   printf("%hhs", "a"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
465 
466   const char kFormat16[] = "%-0d"; // expected-note{{format string is defined here}}
467   printf(kFormat16, 5); // expected-warning{{flag '0' is ignored when flag '-' is present}}
468   printf("%-0d", 5); // expected-warning{{flag '0' is ignored when flag '-' is present}}
469 
470   // Make sure that the "format string is defined here" note is not emitted
471   // when the original string is within the argument expression.
472   printf(1 ? "yes %d" : "no %d"); // expected-warning 2{{more '%' conversions than data arguments}}
473 
474   const char kFormat17[] = "%hu"; // expected-note{{format string is defined here}}}
475   printf(kFormat17, (int[]){0}); // expected-warning{{format specifies type 'unsigned short' but the argument}}
476 
477   printf("%a", (long double)0); // expected-warning{{format specifies type 'double' but the argument has type 'long double'}}
478 }
479 
480 // PR 9466: clang: doesn't know about %Lu, %Ld, and %Lx
481 void printf_longlong(long long x, unsigned long long y) {
482   printf("%Ld", y); // no-warning
483   printf("%Lu", y); // no-warning
484   printf("%Lx", y); // no-warning
485   printf("%Ld", x); // no-warning
486   printf("%Lu", x); // no-warning
487   printf("%Lx", x); // no-warning
488   printf("%Ls", "hello"); // expected-warning {{length modifier 'L' results in undefined behavior or no effect with 's' conversion specifier}}
489 }
490 
491 void __attribute__((format(strfmon,1,2))) monformat(const char *fmt, ...);
492 void __attribute__((format(strftime,1,0))) dateformat(const char *fmt);
493 
494 // Other formats
495 void test_other_formats() {
496   char *str = "";
497   monformat("", 1); // expected-warning{{format string is empty}}
498   monformat(str); // expected-warning{{format string is not a string literal (potentially insecure)}}
499   dateformat(""); // expected-warning{{format string is empty}}
500   dateformat(str); // no-warning (using strftime non literal is not unsafe)
501 }
502