[clang-tidy][readability-container-contains] Fix matching of non-binaryOperator cases (#110386)

Fix #79437.

[clang-tidy][readability-container-contains] Use hasOperands when possible (#109178)

Simplifies two cases and matches two new cases previously missing,
`container.end() [!=]= container.find(...)`.

[clang-tidy][readability-container-contains] Extend to any class with contains (#107521)

This check will now work out of the box with other containers that have a
`contains` method, such as `folly:

[clang-tidy][readability-container-contains] Extend to any class with contains (#107521)

This check will now work out of the box with other containers that have a
`contains` method, such as `folly::F14` or Abseil containers.

It will also work with strings, which are basically just weird containers.
`std::string` and `std::string_view` will have a `contains` method starting with
C++23. `llvm::StringRef` and `folly::StringPiece` are examples of existing
implementations with a `contains` method.

show more ...

[clang-tidy] readability-container-contains literal suffixes (#74215)

Before this PR, readability-container-contains fix-its did not handle
integer literal suffixes correctly. It e.g. changed
```

[clang-tidy] readability-container-contains literal suffixes (#74215)

Before this PR, readability-container-contains fix-its did not handle
integer literal suffixes correctly. It e.g. changed
```
MyMap.count(2) != 0U;
```
into
```
MyMap.contains(2)U;
```

With this PR, it correctly changes it to
```
MyMap.contains(2);
```

show more ...

[clang-tidy] Update tests to include C++23 and C++26

This commit changes the `c++xx-or-later` definitions to also include
C++23 and the upcoming C++26.
`readability/container-contains.cpp` to also t

[clang-tidy] Update tests to include C++23 and C++26

This commit changes the `c++xx-or-later` definitions to also include
C++23 and the upcoming C++26.
`readability/container-contains.cpp` to also test newer C++ versions.

Also, this commit adjusts a couple of test cases slightly:
* `container-contains.cpp` now also tests newer C++ versions.
Restricting it to C++20 was an oversight of mine when originally
writing this check.
* `unconventional-assign-operator.cpp`: The `return rhs` raised
a "non-const lvalue reference to type 'BadReturnStatement' cannot
bind to a temporary" error in C++23. The issue is circumenvented
by writing `return *&rhs`.
* `const-correctness-values.cpp` was also running into the same error
in C++23. The troublesome test cases were moved to a separate file.

Differential Revision: https://reviews.llvm.org/D157246

show more ...

[clang-tidy] Organize test files into subdirectories by module (NFC)

Eliminate clutter by reorganizing the Lit test files for clang-tidy:
- Move checkers/<module>-* to checkers/<module>/*.
- Move mo

[clang-tidy] Organize test files into subdirectories by module (NFC)

Eliminate clutter by reorganizing the Lit test files for clang-tidy:
- Move checkers/<module>-* to checkers/<module>/*.
- Move module specific inputs from Inputs to <module>/Inputs. Remove
any module prefix from the file or subdirectory name as they are no
longer needed.
- Introduce a Lit substitution %clang_tidy_headers for the system
headers in checkers/Inputs/Headers and use this throughout. This
avoids referencing system headers through a relative path to the
parent directory and makes it clear that these fake system headers are
shared among all modules.
- Update add_new_check.py to follow the above conventions when creating
the boiler plate test files for a new check.
- Update Contributing.rst to describe per-module Inputs directory and
fix link to test source code.

Differential Revision: https://reviews.llvm.org/D128072

show more ...