argparse: enable with MSVC

The issues that were preventing argparser from getting compiled with
MSVC were fixed, so now it should not be excluded from the
compilation anymore.

Signed-off-by: Andre

argparse: enable with MSVC

The issues that were preventing argparser from getting compiled with
MSVC were fixed, so now it should not be excluded from the
compilation anymore.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

show more ...

argparse: fix hyphens in doc

With the line in rst file:
The single mode: "--aaa" or "-a".
corresponding line in html doc:
The single mode: -aaa or -a.
the two hyphens (--aaa) become one (-aaa).

A

argparse: fix hyphens in doc

With the line in rst file:
The single mode: "--aaa" or "-a".
corresponding line in html doc:
The single mode: -aaa or -a.
the two hyphens (--aaa) become one (-aaa).

According to [1], this commit uses the backquote (``xxx``) to fix it.
And for consistency, use this format for all arguments.

[1] https://stackoverflow.com/questions/51075907/display-two-dashes-in-rst-file

Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Jie Hai <haijie1@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

argparse: fix argument flags size

The struct rte_argparse_arg's flags was 64bit type, uint64_t should be
used instead of uint32_t where the operation happened.

Also, the flags' bit16 was also unuse

argparse: fix argument flags size

The struct rte_argparse_arg's flags was 64bit type, uint64_t should be
used instead of uint32_t where the operation happened.

Also, the flags' bit16 was also unused, so don't test bit16 in testcase
test_argparse_invalid_arg_flags.

In addition, this commit introduces two bitmask marcros and removes an
internal duplicate macro.

Fixes: 6c5c6571601c ("argparse: verify argument config")
Fixes: 31ed9f9f43bb ("argparse: parse parameters")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Jie Hai <haijie1@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

argparse: replace flag enum with macros

The enum rte_argparse_flag's value is u64, but an enum in C is
represented as an int. This commit replace these enum values with
macro.

Bugzilla ID: 1409
Fix

argparse: replace flag enum with macros

The enum rte_argparse_flag's value is u64, but an enum in C is
represented as an int. This commit replace these enum values with
macro.

Bugzilla ID: 1409
Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
Fixes: 5357c248c960 ("argparse: parse unsigned integers")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Jie Hai <haijie1@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

argparse: remove dead code

The judgement "obj->callback == NULL" is dead code which can't be
reached, because verify_arg_saver() already make sure obj->callback
must not be NULL when arg->val_saver

argparse: remove dead code

The judgement "obj->callback == NULL" is dead code which can't be
reached, because verify_arg_saver() already make sure obj->callback
must not be NULL when arg->val_saver is NULL.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Jie Hai <haijie1@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

argparse: clarify error logs

This patch rewords the error messages.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Jie Hai <ha

argparse: clarify error logs

This patch rewords the error messages.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Jie Hai <haijie1@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

build: exclude rather than include libs in MSVC build

Some libraries that could be built with MSVC were not being built.

Switch from explicit include to exclude of libs to get immediate CI
coverage

build: exclude rather than include libs in MSVC build

Some libraries that could be built with MSVC were not being built.

Switch from explicit include to exclude of libs to get immediate CI
coverage of libraries that already work with MSVC Windows builds.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...