examples/flow_filtering: remove duplicate assignment

Last action in template was being assigned twice.

Coverity issue: 451221
Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases snip

examples/flow_filtering: remove duplicate assignment

Last action in template was being assigned twice.

Coverity issue: 451221
Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases snippets")
Cc: stable@dpdk.org

Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>

show more ...

examples/flow_filtering: fix build with GCC 15

Gcc 15 no longer allows initialization of arrays with strings
because the null character is dropped.
Resolve by using an array initializer.

../example

examples/flow_filtering: fix build with GCC 15

Gcc 15 no longer allows initialization of arrays with strings
because the null character is dropped.
Resolve by using an array initializer.

../examples/flow_filtering/snippets/snippet_match_mpls.c: In function ‘snippet_mpls_create_pattern_template’:
../examples/flow_filtering/snippets/snippet_match_mpls.c:62:31: warning: initializer-string for array of ‘unsigned char’ is too long [-Wunterminated-string-initialization]
62 | .label_tc_s = "\xff\xff\xf1",
| ^~~~~~~~~~~~~~

Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases snippets")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: David Marchand <david.marchand@redhat.com>

show more ...

examples: replace packed attributes

MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro

examples: replace packed attributes

MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro __rte_packed_end to restore
the pack value prior to the push.

Macro __rte_packed_end is deliberately utilized to trigger a
MSVC compiler warning if no existing packing has been pushed allowing
easy identification of locations where the __rte_packed_begin is
missing.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>

show more ...

examples/ip-pipeline: remove some packed attributes

Removed packed attributes from structs that are naturally packed
already, or don't require packing.

Signed-off-by: Andre Muezerie <andremue@linux

examples/ip-pipeline: remove some packed attributes

Removed packed attributes from structs that are naturally packed
already, or don't require packing.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>

show more ...

examples/ptpclient: revert frequency adjustment

The commit 6d55af611fd5 ("examples/ptpclient: add frequency adjustment")
includes some GPL-licensed code and therefore cannot be applied to the
DPDK.

examples/ptpclient: revert frequency adjustment

The commit 6d55af611fd5 ("examples/ptpclient: add frequency adjustment")
includes some GPL-licensed code and therefore cannot be applied to the
DPDK. Therefore, revert that commit.

By reverting this commit, the basic functionality (PMD support for
high-precision clocks) will not be affected, but its accuracy will be
reduced to the microsecond level.

Fixes: 6d55af611fd5 ("examples/ptpclient: add frequency adjustment")

Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

show more ...

examples/flow_filtering: introduce use cases snippets

These code snippets demonstrate rule creation using
template and non-template APIs.
They include functions that enable developers to create rule

examples/flow_filtering: introduce use cases snippets

These code snippets demonstrate rule creation using
template and non-template APIs.
They include functions that enable developers to create rules.
The purpose of providing these snippets is to allow developers
to reuse them, thereby saving time and effort during the
implementation of flow rules.

The code snippets are categorized based on their usage and can be copied,
paste and modified to suit any requirements.
The snippets provided here are kept up to date and are being compiled
along with the rest of the examples.

There is a skeleton that demonstrates rule creation
using both template and non template APIs.

Developers can change the functions in the skeleton to the corresponding
snippet functions with the appropriate suffix and create rules using the
snippets themselves for easy testing. Each snippet has the same functions
to implement the actions and patterns for the corresponding feature.

Signed-off-by: Shani Peretz <shperetz@nvidia.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

examples/l3fwd: add option to set mbuf cache size

The mempool cache size of mbuf is set to
RTE_MEMPOOL_CACHE_MAX_SIZE as default. This patch allows
users to configure the cache size by "--mbcache",

examples/l3fwd: add option to set mbuf cache size

The mempool cache size of mbuf is set to
RTE_MEMPOOL_CACHE_MAX_SIZE as default. This patch allows
users to configure the cache size by "--mbcache", and limits
the parameter to a maximum of RTE_MEMPOOL_CACHE_MAX_SIZE.

Signed-off-by: Jie Hai <haijie1@huawei.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

show more ...

examples/l3fwd: add option to set Rx burst size

Now the Rx burst size is fixed to MAX_PKT_BURST (32). This
parameter needs to be modified in some performance optimization
scenarios. So an option '--

examples/l3fwd: add option to set Rx burst size

Now the Rx burst size is fixed to MAX_PKT_BURST (32). This
parameter needs to be modified in some performance optimization
scenarios. So an option '--burst' is added to set the burst size
explicitly. The default value is DEFAULT_PKT_BURST (32) and maximum
value is MAX_PKT_BURST (512).

Signed-off-by: Jie Hai <haijie1@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...

examples/fips_validation: fix EdDSA signature size

Fix EdDSA signature size.

Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn

examples/fips_validation: fix EdDSA signature size

Fix EdDSA signature size.

Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Acked-by: Brian Dooley <brian.dooley@intel.com>

show more ...

examples/fips_validation: prehash input for RSA

Plain text needs to be prehashed for RSA as well in asymmetric
crypto validation.

Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")

Si

examples/fips_validation: prehash input for RSA

Plain text needs to be prehashed for RSA as well in asymmetric
crypto validation.

Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Acked-by: Brian Dooley <brian.dooley@intel.com>

show more ...

examples/l2fwd-event: fix spinlock handling

Detected by pvs-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might remain blocked.

Fixe

examples/l2fwd-event: fix spinlock handling

Detected by pvs-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might remain blocked.

Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

show more ...

examples/ptp: replace terms master and slave

Remove one of the few remaining uses of master/slave.

The IEEE 1588 standard has been updated to remove the use
of master-slave terminology. Change the

examples/ptp: replace terms master and slave

Remove one of the few remaining uses of master/slave.

The IEEE 1588 standard has been updated to remove the use
of master-slave terminology. Change the sample to Use the terms
recommended by IEEE 1588g-2022 amendment.

In place of the term “master”, use the term “timeTransmitter”.
In place of the term “slave”, use the term “timeReceiver”.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

show more ...

power: fix build with libvirt

Following moving rte_power_guest* API from the power library to the
kvm_vm driver, the symbols are not exposed anymore, since the library
hosting them is the kvm_vm dri

power: fix build with libvirt

Following moving rte_power_guest* API from the power library to the
kvm_vm driver, the symbols are not exposed anymore, since the library
hosting them is the kvm_vm driver binary.

Finish this cleanup by hosting the rte_power_guest_channel.h header in
the driver, then version the symbols and add corresponding build
dependencies in the vm_power_manager example.

Fixes: 6f987b594fa6 ("power: refactor core power management")

Signed-off-by: David Marchand <david.marchand@redhat.com>

show more ...

examples/ptpclient: add frequency adjustment

This patch adds PI servo controller to support frequency
adjustment API for IEEE1588 PTP.

For example, the command for starting ptpclient with PI contro

examples/ptpclient: add frequency adjustment

This patch adds PI servo controller to support frequency
adjustment API for IEEE1588 PTP.

For example, the command for starting ptpclient with PI controller is:
dpdk-ptpclient -a 0000:81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1

Signed-off-by: Simei Su <simei.su@intel.com>
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Acked-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>

show more ...

examples/qos_sched: check link query return

The return status of link is undefined if call to rte_eth_link_get
returns an error.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-

examples/qos_sched: check link query return

The return status of link is undefined if call to rte_eth_link_get
returns an error.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...

examples/pipeline: check info query return

The rte_eth_dev_info_get and rte_eth_link_get functions may return
an error, and in that case the information structure is undefined.
The port is valid che

examples/pipeline: check info query return

The rte_eth_dev_info_get and rte_eth_link_get functions may return
an error, and in that case the information structure is undefined.
The port is valid check is not needed, that can be handled by
rte_eth_dev_info_get checks.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...

examples/ntb: check info query return

The ethdev_info is only valid if rte_eth_dev_info_get returns success.

Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
Cc: stable@dpdk.org

Signed

examples/ntb: check info query return

The ethdev_info is only valid if rte_eth_dev_info_get returns success.

Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...

examples/l3fwd: check info query return

Need to check return value from rte_eth_dev_info_get.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesys

examples/l3fwd: check info query return

Need to check return value from rte_eth_dev_info_get.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...

examples/ethtool: handle drivers without registers info

If device does not support reading registers then call to
rte_eth_dev_get_reg_info will return an error.
This fixes compiler warning when warn

examples/ethtool: handle drivers without registers info

If device does not support reading registers then call to
rte_eth_dev_get_reg_info will return an error.
This fixes compiler warning when warn unused result is set.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

show more ...

examples/l3fwd: fix read beyond boundaries in ACL mode

With commit: ACL mode now can use send_packets_multi().
What I missed with that changes: send_packets_multi() can't deal
properly with input ds

examples/l3fwd: fix read beyond boundaries in ACL mode

With commit: ACL mode now can use send_packets_multi().
What I missed with that changes: send_packets_multi() can't deal
properly with input dst_port[i] == BAD_PORT (though it can set
it itself), as it uses dst_port[i] values to read L2 addresses for the port
and assumes dst_port[] to contain valid only values.
To fix that just add a check that all dst_port[] entries are valid before
calling : send_packets_multi(). Otherwise use send_packets_single().
An alternative, and probably more logical approach would be to
re-arrange send_packets_multi() so that it updates L2 packet headers
at the very last state - when dst_port[] are finialized.
But that would affect all other modes, but that would affect all other
modes and will require much more code changes and testing.

Bugzilla ID: 1502
Fixes: aa7c6077c19b ("examples/l3fwd: avoid packets reorder in ACL mode")

Reported-by: Song Jiale <songx.jiale@intel.com>
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

examples/l3fwd: fix read beyond boundaries

ASAN report:
ERROR: AddressSanitizer: unknown-crash on address 0x7ffffef92e32 at pc 0x00000053d1e9 bp 0x7ffffef92c00 sp 0x7ffffef92bf8
READ of size 16 at 0

examples/l3fwd: fix read beyond boundaries

ASAN report:
ERROR: AddressSanitizer: unknown-crash on address 0x7ffffef92e32 at pc 0x00000053d1e9 bp 0x7ffffef92c00 sp 0x7ffffef92bf8
READ of size 16 at 0x7ffffef92e32 thread T0
#0 0x53d1e8 in _mm_loadu_si128 /usr/lib64/gcc/x86_64-suse-linux/11/include/emmintrin.h:703
#1 0x53d1e8 in send_packets_multi ../examples/l3fwd/l3fwd_sse.h:125
#2 0x53d1e8 in acl_send_packets ../examples/l3fwd/l3fwd_acl.c:1048
#3 0x53ec18 in acl_main_loop ../examples/l3fwd/l3fwd_acl.c:1127
#4 0x12151eb in rte_eal_mp_remote_launch ../lib/eal/common/eal_common_launch.c:83
#5 0x5bf2df in main ../examples/l3fwd/main.c:1647
#6 0x7f6d42a0d2bc in __libc_start_main (/lib64/libc.so.6+0x352bc)
#7 0x527499 in _start (/home/kananyev/dpdk-l3fwd-acl/x86_64-native-linuxapp-gcc-dbg-b1/examples/dpdk-l3fwd+0x527499)

Reason for that is that send_packets_multi() uses 16B loads to access
input dst_port[]and might read beyond array boundaries.
Right now, it doesn't cause any real issue - junk values are ignored, also
inside l3fwd we always allocate dst_port[] array on the stack, so
memory beyond it is always available.
Anyway, it probably need to be fixed.
The patch below simply allocates extra space for dst_port[], so
send_packets_multi() will never read beyond its boundaries.

Probably a better fix would be to change send_packets_multi()
itself to avoid access beyond 'nb_rx' entries.

Bugzilla ID: 1502
Fixes: 94c54b4158d5 ("examples/l3fwd: rework exact-match")
Cc: stable@dpdk.org

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

show more ...

examples/l3fwd-power: add PM QoS configuration

The '--cpu-resume-latency' can use to control C-state selection.
Setting the CPU resume latency to 0 can limit the CPU just to enter
C0-state to improv

examples/l3fwd-power: add PM QoS configuration

The '--cpu-resume-latency' can use to control C-state selection.
Setting the CPU resume latency to 0 can limit the CPU just to enter
C0-state to improve performance, which also may increase the power
consumption of platform.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>

show more ...

examples/l3fwd-power: fix options parsing overflow

Many variables are 'uint32_t', like, 'pause_duration', 'scale_freq_min'
and so on. They use parse_int() to parse it from command line.
But overflow

examples/l3fwd-power: fix options parsing overflow

Many variables are 'uint32_t', like, 'pause_duration', 'scale_freq_min'
and so on. They use parse_int() to parse it from command line.
But overflow problem occurs when this function return.

Fixes: 59f2853c4cae ("examples/l3fwd_power: add configuration options")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

show more ...

power: rename files for CPU frequency management

This patch renames the existing core power library source files
from rte_power.* to rte_power_cpufreq.* for better clarity

Signed-off-by: Sivaprasad

power: rename files for CPU frequency management

This patch renames the existing core power library source files
from rte_power.* to rte_power_cpufreq.* for better clarity

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

show more ...

test/power: remove function pointer validations

After refactoring the power library, power management operations will be
consistently supported regardless of the operating environment, making
functi

test/power: remove function pointer validations

After refactoring the power library, power management operations will be
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

show more ...