net/nfp: add missing period in logs

Unified add period at the end of the sentence in log.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewe

net/nfp: add missing period in logs

Unified add period at the end of the sentence in log.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

security: use IPv6 address structure

For consistency with the rest of the code base, update
rte_security_ipsec_tunnel_param to use rte_ipv6_addr structures instead
of in6_addr.

Signed-off-by: Robin

security: use IPv6 address structure

For consistency with the rest of the code base, update
rte_security_ipsec_tunnel_param to use rte_ipv6_addr structures instead
of in6_addr.

Signed-off-by: Robin Jarry <rjarry@redhat.com>

show more ...

net/nfp: do not set IPv6 flag in transport mode

The transport only encapsulates the security protocol header,
does not pay attention to the IP protocol type, and need not
to set the IPv6 flag.

Fixe

net/nfp: do not set IPv6 flag in transport mode

The transport only encapsulates the security protocol header,
does not pay attention to the IP protocol type, and need not
to set the IPv6 flag.

Fixes: 3d21da66c06b ("net/nfp: create security session")
Cc: stable@dpdk.org

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: fix uninitialized variable

CI found in the logic of 'nfp_aesgcm_iv_update()', the variable
'cfg_iv' may be used uninitialized in some case.

Coverity issue: 415808
Fixes: 7e13f2dc603e ("net

net/nfp: fix uninitialized variable

CI found in the logic of 'nfp_aesgcm_iv_update()', the variable
'cfg_iv' may be used uninitialized in some case.

Coverity issue: 415808
Fixes: 7e13f2dc603e ("net/nfp: fix IPsec data endianness")
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: fix IPsec data endianness

The algorithm key of the security framework is stored in the u8
array according to big-endian, and the driver algorithm key is
CPU-endian of u32, so it maybe need

net/nfp: fix IPsec data endianness

The algorithm key of the security framework is stored in the u8
array according to big-endian, and the driver algorithm key is
CPU-endian of u32, so it maybe need to convert the endianness order
to ensure that the value assigned to the driver is CPU-endian.

This patch removes the operation of converting IPsec Tx metadata
to big-endian to ensure that IPsec Tx metadata is CPU-endian.

Fixes: 547137405be7 ("net/nfp: initialize IPsec related content")
Fixes: 3d21da66c06b ("net/nfp: create security session")
Fixes: 310a1780581e ("net/nfp: support IPsec Rx and Tx offload")
Cc: stable@dpdk.org

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: create meta data module

Move the Rx meta data code to new 'nfp_net_meta' module, which
makes related logic more clean and the code architecture more
reasonable.
There is no functional chang

net/nfp: create meta data module

Move the Rx meta data code to new 'nfp_net_meta' module, which
makes related logic more clean and the code architecture more
reasonable.
There is no functional change, just moving verbatim code around.

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: verify strdup return

Add verify strdup return value logic.

Fixes: 3d21da66c06b ("net/nfp: create security session")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.c

net/nfp: verify strdup return

Add verify strdup return value logic.

Fixes: 3d21da66c06b ("net/nfp: create security session")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

use C11 alignof

Replace use of __alignof__(e) (resp. __alignof__(T) with C11
alignof(typeof(e)) (resp. alignof(T)) to improve portability
between toolchains.

Signed-off-by: Tyler Retzlaff <roretzla

use C11 alignof

Replace use of __alignof__(e) (resp. __alignof__(T) with C11
alignof(typeof(e)) (resp. alignof(T)) to improve portability
between toolchains.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Volodymyr Fialko <vfialko@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

show more ...

remove unnecessary null checks before free

This is the latest round of places that are checking for NULL
pointer before calling free or rte_free.
It is result of applying the nullfree.cocci script.

remove unnecessary null checks before free

This is the latest round of places that are checking for NULL
pointer before calling free or rte_free.
It is result of applying the nullfree.cocci script.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

show more ...

net/nfp: remove unneeded data abstraction

The data structure 'struct nfp_net_adapter' has only one data field and
we won't extend it in the future, which makes this abstraction unneeded,
so remove t

net/nfp: remove unneeded data abstraction

The data structure 'struct nfp_net_adapter' has only one data field and
we won't extend it in the future, which makes this abstraction unneeded,
so remove this data structure and the related macro
'NFP_NET_DEV_PRIVATE_TO_HW'.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: fix offload flags of security capabilities

This patch resolves configuration error of ol_flags in the
rte_security_capability. Currently ol_flags in the ingress direction
of the SA, 'RTE_SE

net/nfp: fix offload flags of security capabilities

This patch resolves configuration error of ol_flags in the
rte_security_capability. Currently ol_flags in the ingress direction
of the SA, 'RTE_SECURITY_TX_OLOAD_NEED_MDATA' is configured. In fact,
ol_flags only in the egress direction of the SA needs to be configured.

Fixes: e6d69ea011c9 ("net/nfp: get security capabilities and session size")
Cc: stable@dpdk.org

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: rename parameter in related logic

Rename parameter 'hw' into 'net_hw' in the related logic, to make the
name more accurate.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-b

net/nfp: rename parameter in related logic

Rename parameter 'hw' into 'net_hw' in the related logic, to make the
name more accurate.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: change parameter of functions

Change the parameter of some functions from 'struct nfp_net_hw' into the
super class 'struct nfp_hw', prepare for the upcoming common library.

Signed-off-by:

net/nfp: change parameter of functions

Change the parameter of some functions from 'struct nfp_net_hw' into the
super class 'struct nfp_hw', prepare for the upcoming common library.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: extract capability field

Extract the 'cap' and 'cap_ext' data field into the super class, ready
for the upcoming common library.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Revie

net/nfp: extract capability field

Extract the 'cap' and 'cap_ext' data field into the super class, ready
for the upcoming common library.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: rename ctrl module

Rename the 'nfp_ctrl' module into 'nfp_net_ctrl' module, because which
is more suitable and we will add 'nfp_common_ctrl' module in the
'drivers/common/nfp' directory.

S

net/nfp: rename ctrl module

Rename the 'nfp_ctrl' module into 'nfp_net_ctrl' module, because which
is more suitable and we will add 'nfp_common_ctrl' module in the
'drivers/common/nfp' directory.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: rename net common module

Rename the 'nfp_common' module into 'nfp_net_common' module, because
which is more suitable and we will add 'nfp_common' module in the
'drivers/common/nfp' director

net/nfp: rename net common module

Rename the 'nfp_common' module into 'nfp_net_common' module, because
which is more suitable and we will add 'nfp_common' module in the
'drivers/common/nfp' directory.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

show more ...

net/nfp: fix Tx performance

The former commit imports a register read operation into the data path
logic, which will severely degrade performance.
Fix this bug by moving the register read logic out

net/nfp: fix Tx performance

The former commit imports a register read operation into the data path
logic, which will severely degrade performance.
Fix this bug by moving the register read logic out of the data path.
Read 'cap_extend' only once in the initialisation logic and store it
in the data structure. And all other logics that need this value should
get it from the data structure.

Fixes: 310a1780581e ("net/nfp: support IPsec Rx and Tx offload")
Cc: stable@dpdk.org

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: destroy security session

Delete SA from NIC and destroy security session.

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

net/nfp: support IPsec Rx and Tx offload

The Rx path checks the ipsec metadata and base on the
crypto status sets ol_flags in the rte_mbuf.

The Tx path write IPsec message to mbuf metadata based
on

net/nfp: support IPsec Rx and Tx offload

The Rx path checks the ipsec metadata and base on the
crypto status sets ol_flags in the rte_mbuf.

The Tx path write IPsec message to mbuf metadata based
on mbuf dynamic field.

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Signed-off-by: Chang Miao <chang.miao@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: update security session

Update the configuration information in priv_session when
the configuration parameters of sess_conf change.

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>

net/nfp: update security session

Update the configuration information in priv_session when
the configuration parameters of sess_conf change.

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: create security session

Create security session to manage IPsec protocol specific message
and crypto parameters. This session support full protocol offload
and inline crypto operation with

net/nfp: create security session

Create security session to manage IPsec protocol specific message
and crypto parameters. This session support full protocol offload
and inline crypto operation with NIC devices.

Signed-off-by: Chang Miao <chang.miao@corigine.com>
Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: get IPsec Rx/Tx packet statistics

IPsec packet processing is mostly carried out in hardware.
The hardware statistics on successful packets and discarded
packets. The driver can obtain these

net/nfp: get IPsec Rx/Tx packet statistics

IPsec packet processing is mostly carried out in hardware.
The hardware statistics on successful packets and discarded
packets. The driver can obtain these statistics by Mailbox.

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: get security capabilities and session size

Add full protocol offload as well as inline crypto IPsec
capabilities and return these for rte_security.

Return size of security session for rte_

net/nfp: get security capabilities and session size

Add full protocol offload as well as inline crypto IPsec
capabilities and return these for rte_security.

Return size of security session for rte_security.

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...

net/nfp: initialize IPsec related content

If enable IPsec capability bit, driver need to Initialize IPsec.
Set security context and security offload capabilities in datapath.
Define private session

net/nfp: initialize IPsec related content

If enable IPsec capability bit, driver need to Initialize IPsec.
Set security context and security offload capabilities in datapath.
Define private session and add SA array for each PF to save all
SA data in driver. Add internal mbuf dynamic flag and field to save
IPsec related data to dynamic mbuf field.

Also update the release note, add the inline IPsec offload section for NFP
PMD.

Signed-off-by: Chang Miao <chang.miao@corigine.com>
Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>

show more ...