#
e0d947a1 |
| 04-Oct-2024 |
Ferruh Yigit <ferruh.yigit@amd.com> |
ethdev: convert string initialization
gcc 15 experimental [1], with -Wextra flag, gives warning in variable initialization as string [2].
The warning has a point when initialized variable is intend
ethdev: convert string initialization
gcc 15 experimental [1], with -Wextra flag, gives warning in variable initialization as string [2].
The warning has a point when initialized variable is intended to use as string, since assignment is missing the required null terminator for this case. But warning is useless for our usecase.
In this patch only updated a few instance to show the issue, there are many instances to fix, if we prefer to go this way. Other option is to disable warning but it can be useful for actual string usecases, so I prefer to keep it.
Converted string initialization to array initialization.
[1] gcc (GCC) 15.0.0 20241003 (experimental)
[2] ../lib/ethdev/rte_flow.h:906:36: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] 906 | .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", | ^~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/ethdev/rte_flow.h:907:36: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] 907 | .hdr.src_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", | ^~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/ethdev/rte_flow.h:1009:25: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] 1009 | "\xff\xff\xff\xff\xff\xff\xff\xff" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/ethdev/rte_flow.h:1012:25: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] 1012 | "\xff\xff\xff\xff\xff\xff\xff\xff" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/ethdev/rte_flow.h:1135:20: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] 1135 | .hdr.vni = "\xff\xff\xff", | ^~~~~~~~~~~~~~
Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> Acked-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
show more ...
|
#
295a1de2 |
| 31-Oct-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: fix buffer leaks in MACsec error path
In case of failure of a test in macsec autotest, the buffers were not getting cleaned. Added appropriate code to clean the buffers.
Fixes: 993ea
test/security: fix buffer leaks in MACsec error path
In case of failure of a test in macsec autotest, the buffers were not getting cleaned. Added appropriate code to clean the buffers.
Fixes: 993ea577a006 ("test/security: add inline MACsec cases") Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <gakhil@marvell.com> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
show more ...
|
#
79bdb787 |
| 20-Sep-2023 |
Akhil Goyal <gakhil@marvell.com> |
security: hide security context
rte_security_ctx is used by all security APIs to identify which device security_op it need to call and hence it should be opaque to the application. Hence, it is now
security: hide security context
rte_security_ctx is used by all security APIs to identify which device security_op it need to call and hence it should be opaque to the application. Hence, it is now moved to internal header file and all APIs will now take an opaque pointer for it. The fast path inline APIs like set metadata need to get flags from security_ctx. The flags are now retrieved using inline APIs which use macros to get the offset of flags in security_ctx.
Signed-off-by: Akhil Goyal <gakhil@marvell.com> Acked-by: Ciara Power <ciara.power@intel.com> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
show more ...
|
#
b15d5134 |
| 31-Jul-2023 |
Ankur Dwivedi <adwivedi@marvell.com> |
test/security: add capability verification for MACsec
Before running each MACsec test, the device capability is read. The capability is then verified to check if the device supports a feature or not
test/security: add capability verification for MACsec
Before running each MACsec test, the device capability is read. The capability is then verified to check if the device supports a feature or not. If the feature is not supported the test is skipped.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
show more ...
|
#
63bf81a6 |
| 23-Aug-2023 |
Anatoly Burakov <anatoly.burakov@intel.com> |
test: fix named test macro
Currently, the TEST_CASE_NAMED_ST macro is implemented in a way that is identical to TEST_CASE_NAMED_WITH_DATA. In particular, it expects the test function to have a data
test: fix named test macro
Currently, the TEST_CASE_NAMED_ST macro is implemented in a way that is identical to TEST_CASE_NAMED_WITH_DATA. In particular, it expects the test function to have a data argument, which is why a bunch of tests have an unused data arguments.
Fix this by adjusting the macro to not expect a test function with data arguments, and adjust the dependent test cases accordingly.
Fixes: 474f12024dd9 ("test/crypto: add lookaside IPsec cases") Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> Acked-by: Akhil Goyal <gakhil@marvell.com> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> Acked-by: Anoob Joseph <anoobj@marvell.com>
show more ...
|
#
2a3a153e |
| 08-Jun-2023 |
Ankur Dwivedi <adwivedi@marvell.com> |
test/security: verify MACsec anti replay
This patch enables anti replay test case for MACsec.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
|
#
4885ba24 |
| 08-Jun-2023 |
Ankur Dwivedi <adwivedi@marvell.com> |
test/security: verify MACsec Rx rekey
This patch enables the Rx rekey test case for MACSEC.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
|
#
ad344741 |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: verify MACsec Tx HW rekey
This patch enables the Tx HW rekey test case for MACSEC.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
|
#
339b9354 |
| 08-Jun-2023 |
Ankur Dwivedi <adwivedi@marvell.com> |
test/security: verify MACsec interrupts
This patch enables the test_inline_macsec_interrupts_all test case for MACSEC.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> Signed-off-by: Akhil Goyal
test/security: verify MACsec interrupts
This patch enables the test_inline_macsec_interrupts_all test case for MACSEC.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
show more ...
|
#
164757d6 |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: verify MACsec stats
Added cases to verify various stats of MACsec.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
|
#
7c3b1dec |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: add MACsec negative cases
Added MACsec negative test cases to verify pkt drop, untagged rx, bad tag rx, sa not in use, out packets untagged, pkts too long.
Signed-off-by: Akhil Goyal
test/security: add MACsec negative cases
Added MACsec negative test cases to verify pkt drop, untagged rx, bad tag rx, sa not in use, out packets untagged, pkts too long.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
show more ...
|
#
e67246cb |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: add MACsec VLAN cases
Added cases to verify MACsec processing with VLAN tags inserted. Vectors are added to verify 1/2/3 VLAN tags in clear or encrypted data.
Signed-off-by: Akhil Go
test/security: add MACsec VLAN cases
Added cases to verify MACsec processing with VLAN tags inserted. Vectors are added to verify 1/2/3 VLAN tags in clear or encrypted data.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
show more ...
|
#
e3d83ea4 |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: verify multi flow MACsec
Added test case and test vectors to verify multiple flows of MACsec.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
|
#
2da0c0a7 |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: add MACsec integrity cases
Added test vectors and test cases to verify auth_only/verify_only and encap-decap/auth-verify to verify the complete TX-RX path using the loopback mode of e
test/security: add MACsec integrity cases
Added test vectors and test cases to verify auth_only/verify_only and encap-decap/auth-verify to verify the complete TX-RX path using the loopback mode of ethdev.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
show more ...
|
#
993ea577 |
| 08-Jun-2023 |
Akhil Goyal <gakhil@marvell.com> |
test/security: add inline MACsec cases
Updated test app to verify Inline MACsec offload using rte_security APIs. A couple of test cases are added to verify encap only and decap only of some known te
test/security: add inline MACsec cases
Updated test app to verify Inline MACsec offload using rte_security APIs. A couple of test cases are added to verify encap only and decap only of some known test vectors from MACsec specification.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
show more ...
|