test/crypto: fix TLS zero length record check

The code was duplicating the same condition three times?
Reading the commit message, the intention was:

Add unit tests to verify the zero len TLS r

test/crypto: fix TLS zero length record check

The code was duplicating the same condition three times?
Reading the commit message, the intention was:

Add unit tests to verify the zero len TLS records. Zero len packets are
allowed when content type is app data while zero packet length with
other content type (such as handshake) would result in an error.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 79a58624369a ("test/security: verify zero length TLS records")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Anoob Joseph <anoobj@marvell.com>

show more ...

test/crypto: fix synchronous API calls

For the synchronous API the enqueue/dequeue burst functions are not
called. Skip these tests when calling the synchronous API.

Fixes: 4ad17a1c8fb3 ("test/cryp

test/crypto: fix synchronous API calls

For the synchronous API the enqueue/dequeue burst functions are not
called. Skip these tests when calling the synchronous API.

Fixes: 4ad17a1c8fb3 ("test/crypto: fix enqueue/dequeue callback case")
Cc: stable@dpdk.org

Signed-off-by: Brian Dooley <brian.dooley@intel.com>

show more ...

test/crypto: verify error recovery

Add a callback for error recovery and register it with cryptodev.
Add a unit test to verify the error recovery of cryptodev.
The unit test generates an error by pa

test/crypto: verify error recovery

Add a callback for error recovery and register it with cryptodev.
Add a unit test to verify the error recovery of cryptodev.
The unit test generates an error by passing an mbuf to cryptodev
allocated from heap memory. The registered callback will be called as
part of error recovery.
The unit test verifies the cryptodev recovery by testing a simple
crypto operation.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: free pools in teardown

Free the pools allocated in testsuite_setup.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

test/crypto: remove unused macros

The macros are not used. Remove the same.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

test/crypto: remove bool redefinition

Remove redefinition of TRUE & FALSE. These are defined by stdbool. Can
use the same.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <ga

test/crypto: remove bool redefinition

Remove redefinition of TRUE & FALSE. These are defined by stdbool. Can
use the same.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: enable larger packets with TLS

Enable larger packet sizes with TLS. Add wrapper for existing
create_segmented_mbuf() function to get allocations from both pools.

Signed-off-by: Anoob J

test/crypto: enable larger packets with TLS

Enable larger packet sizes with TLS. Add wrapper for existing
create_segmented_mbuf() function to get allocations from both pools.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: add asserts to validate test lengths

Add asserts to validate the max lengths set.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

test/crypto: fix allocation comment

This patch fixes a typo in the `test_cryptodev.c` file where "out-op" was
incorrectly used instead of "out-of-place" on three separate occasions.

Fixes: f3dbf94b

test/crypto: fix allocation comment

This patch fixes a typo in the `test_cryptodev.c` file where "out-op" was
incorrectly used instead of "out-of-place" on three separate occasions.

Fixes: f3dbf94be60c ("app/test: check SGL on QAT")
Fixes: 43220096d66a ("test/crypto: add PDCP cases for scatter gather")
Cc: stable@dpdk.org

Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

cryptodev: fix build without crypto callbacks

Crypto callbacks APIs are available in header files but when
the macro RTE_CRYPTO_CALLBACKS unset, test application need to
put #ifdef in its code.

The

cryptodev: fix build without crypto callbacks

Crypto callbacks APIs are available in header files but when
the macro RTE_CRYPTO_CALLBACKS unset, test application need to
put #ifdef in its code.

The test application should be able to build and run, regardless
DPDK library is built with RTE_CRYPTO_CALLBACKS defined or not.

Added ENOTSUP from the beginning of the APIs implementation
if RTE_CRYPTO_CALLBACKS macro is unset/undefined.

Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks")
Fixes: 5523a75af539 ("test/crypto: add case for enqueue/dequeue callbacks")
Cc: stable@dpdk.org

Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: use single session in TLS data walkthrough

Existing data walkthrough test creates a new session
per each test packet size. Enhance the test to use single
session instead.

Signed-off-by

test/crypto: use single session in TLS data walkthrough

Existing data walkthrough test creates a new session
per each test packet size. Enhance the test to use single
session instead.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify TLS out-of-place SG list

Add multi segmented test for TLS 1.3 and
multi segmented out of place tests for DTLS 1.2 and TLS 1.3.

Signed-off-by: Aakash Sasidharan <asasidharan@marv

test/crypto: verify TLS out-of-place SG list

Add multi segmented test for TLS 1.3 and
multi segmented out of place tests for DTLS 1.2 and TLS 1.3.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify DTLS 1.2 padding corruption

Add unit test to verify corrupted padding bytes in DTLS-1.2 record

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Signed-off-by: Aakash

test/crypto: verify DTLS 1.2 padding corruption

Add unit test to verify corrupted padding bytes in DTLS-1.2 record

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify TLS 1.2 padding corruption

Add unit test to verify corrupted padding bytes in TLS-1.2 record

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Signed-off-by: Aakash Sa

test/crypto: verify TLS 1.2 padding corruption

Add unit test to verify corrupted padding bytes in TLS-1.2 record

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/security: add TLS 1.3 data walkthrough case

Add combined mode data walkthrough test and multi-segmented
packet data walkthrough test for TLS 1.3.

Signed-off-by: Aakash Sasidharan <asasidharan@

test/security: add TLS 1.3 data walkthrough case

Add combined mode data walkthrough test and multi-segmented
packet data walkthrough test for TLS 1.3.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: add TLS-1.3 combined mode cases

Add cases to try TLS 1.3 record write(encrypt) + read(decrypt)
operations. This is used for testing TLS 1.3 record features with
all algorithms supported

test/crypto: add TLS-1.3 combined mode cases

Add cases to try TLS 1.3 record write(encrypt) + read(decrypt)
operations. This is used for testing TLS 1.3 record features with
all algorithms supported by the security device.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: add TLS-1.3 padding case

Add unit tests to verify the padding for TLS-1.3.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

test/crypto: fix enqueue/dequeue callback case

The enqueue/dequeue callback test cases were using the
test_null_burst_operation() for doing enqueue/dequeue.
But this function is only designed to be

test/crypto: fix enqueue/dequeue callback case

The enqueue/dequeue callback test cases were using the
test_null_burst_operation() for doing enqueue/dequeue.
But this function is only designed to be run for NULL PMD.
Hence for other PMDs, the callback was not getting called.
Now, separate processing thread is removed, instead NULL crypto
operation is created and processed so that callbacks are called.
Also added a check on a global static variable to verify
that the callback is actually called and fail the case if
it is not getting called.

Fixes: 5523a75af539 ("test/crypto: add case for enqueue/dequeue callbacks")
Cc: stable@dpdk.org

Signed-off-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Ganapati Kundapura <ganapati.kundapura@intel.com>

show more ...

test/crypto: add queue pair depth used count

Added a test case to verify the new API
rte_cryptodev_qp_depth_used() to get the used
depth of a crypto device queue pair.

Signed-off-by: Akhil Goyal <g

test/crypto: add queue pair depth used count

Added a test case to verify the new API
rte_cryptodev_qp_depth_used() to get the used
depth of a crypto device queue pair.

Signed-off-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>

show more ...

test/crypto: add TLS 1.2 out-of-place SG case

Add TLS 1.2 out-of-place multi-segmented packet test.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell

test/crypto: add TLS 1.2 out-of-place SG case

Add TLS 1.2 out-of-place multi-segmented packet test.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify DTLS 1.2 padding

Add unit tests to verify the padding for DTLS-1.2.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked

test/crypto: verify DTLS 1.2 padding

Add unit tests to verify the padding for DTLS-1.2.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify TLS 1.2 padding

Add unit tests to verify the padding for TLS-1.2.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-b

test/crypto: verify TLS 1.2 padding

Add unit tests to verify the padding for TLS-1.2.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify TLS 1.3 zero length record

Add unit tests to verify TLS-1.3 record with zero length.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@m

test/crypto: verify TLS 1.3 zero length record

Add unit tests to verify TLS-1.3 record with zero length.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify TLS 1.3 custom content type

Add unit tests to verify TLS-1.3 record with content type as custom.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Jose

test/crypto: verify TLS 1.3 custom content type

Add unit tests to verify TLS-1.3 record with content type as custom.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...

test/crypto: verify header corruption in TLS 1.3

Add unit tests to verify TLS-1.3 record with header corruption.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <

test/crypto: verify header corruption in TLS 1.3

Add unit tests to verify TLS-1.3 record with header corruption.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

show more ...