#
ecf86ccb |
| 05-Feb-2021 |
Ferruh Yigit <ferruh.yigit@intel.com> |
app/testpmd: remove duplicated offload display
"show port cap all|<port_id>" was to display offload configuration of port(s).
But later two other commands added to show same information in more acc
app/testpmd: remove duplicated offload display
"show port cap all|<port_id>" was to display offload configuration of port(s).
But later two other commands added to show same information in more accurate way: show port (port_id) rx_offload configuration show port (port_id) tx_offload configuration
These new commands can both show port and queue level configuration, also with their capabilities counterparts easier to see offload capability and configuration of the port in similar syntax.
So the functionality is duplicated and removing this version, to favor the new commands.
Another problem with this command is it requires each new offload to be added into the function to display them, and there were missing offloads that are not displayed, this requirement for sure will create gaps by time as new offloads added.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Lance Richardson <lance.richardson@broadcom.com> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
show more ...
|
#
dec7c4bd |
| 04-Feb-2021 |
Dekel Peled <dekelp@nvidia.com> |
app/testpmd: support shared age action query
Shared age action query was implemented as part of flow query, but was not implemented as part of shared action query.
This patch adds the required impl
app/testpmd: support shared age action query
Shared age action query was implemented as part of flow query, but was not implemented as part of shared action query.
This patch adds the required implementation.
Fixes: 2f622174bf86 ("app/testpmd: support query of age action") Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com>
show more ...
|
#
761c4d66 |
| 18-Jan-2021 |
Steve Yang <stevex.yang@intel.com> |
app/testpmd: fix max Rx packet length for VLAN packets
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets wi
app/testpmd: fix max Rx packet length for VLAN packets
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Removed the rx_offloads assignment for jumbo frame during command line parsing, and set the correct jumbo frame flag if MTU size is larger than the default value 'RTE_ETHER_MTU' within 'init_config()'.
Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration") Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting MTU") Cc: stable@dpdk.org
Signed-off-by: Steve Yang <stevex.yang@intel.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
3de08812 |
| 20-Dec-2020 |
Karra Satwik <kaara.satwik@chelsio.com> |
app/testpmd: fix start index for showing FEC array
Start from index 0 when going through the FEC array. This will allow "off" to get printed for RTE_ETH_FEC_NOFEC mode.
Fixes: b19da32e3151 ("app/te
app/testpmd: fix start index for showing FEC array
Start from index 0 when going through the FEC array. This will allow "off" to get printed for RTE_ETH_FEC_NOFEC mode.
Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: stable@dpdk.org
Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
08dcd187 |
| 02-Dec-2020 |
Huisong Li <lihuisong@huawei.com> |
app/testpmd: fix queue stats mapping configuration
Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure me
app/testpmd: fix queue stats mapping configuration
Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure message after executing the command "set stat_qmap rx 0 2 2". 2) Once queue mapping is set, unrelated and unmapped queues are also displayed. 3) The configuration result does not take effect or can not be queried in real time. 4) The mapping arrays, "tx_queue_stats_mappings_array" & "rx_queue_stats_mappings_array" are global and their sizes are based on fixed max port and queue size assumptions. 5) These record structures, 'map_port_queue_stats_mapping_registers()' and its sub functions are redundant for majority of drivers. 6) The display of the queue stats and queue stats mapping is mixed together.
Since xstats is used to obtain queue statistics, we have made the following simplifications and adjustments: 1) If PMD requires and supports queue stats mapping, configure to driver in real time by calling ethdev API after executing the command "set stat_qmap rx/tx ...". If not, the command can not be accepted. 2) Based on the above adjustments, these record structures, 'map_port_queue_stats_mapping_registers()' and its sub functions can be removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters, and 'parse_queue_stats_mapping_config()' can be removed too. 3) remove display of queue stats mapping in 'fwd_stats_display()' & 'nic_stats_display()', and obtain queue stats by xstats. Since the record structures are removed, 'nic_stats_mapping_display()' can be deleted.
Fixes: 4dccdc789bf4 ("app/testpmd: simplify handling of stats mappings error") Fixes: 013af9b6b64f ("app/testpmd: various updates") Fixes: ed30d9b691b2 ("app/testpmd: add stats per queue") Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
46914aa1 |
| 18-Nov-2020 |
Simei Su <simei.su@intel.com> |
ethdev: add eCPRI RSS offload type
This patch defines new RSS offload types for eCPRI. For eCPRI with Message Type 0, the hash field is physical channel ID.
Signed-off-by: Simei Su <simei.su@intel.
ethdev: add eCPRI RSS offload type
This patch defines new RSS offload types for eCPRI. For eCPRI with Message Type 0, the hash field is physical channel ID.
Signed-off-by: Simei Su <simei.su@intel.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
de956d5e |
| 10-Nov-2020 |
Matan Azrad <matan@nvidia.com> |
app/testpmd: support age shared action context
When an age action becomes aged-out the next call for rte_flow_get_aged_flows API should return the action context supplied by the action configuration
app/testpmd: support age shared action context
When an age action becomes aged-out the next call for rte_flow_get_aged_flows API should return the action context supplied by the action configuration structure.
In case the age action is created by the shared action API, the shared action context of the Testpmd application was not set.
In addition, the application handler of the contexts returned by the rte_flow_get_aged_flows API didn't consider the fact that the action could be set by the shared action API and considered it as regular flow context.
This caused a crash in Testpmd when the context is parsed.
This patch set context type in the flow and shared action context and uses it to parse the aged-out contexts correctly.
Signed-off-by: Matan Azrad <matan@nvidia.com> Acked-by: Dekel Peled <dekelp@nvidia.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
653c6ed4 |
| 27-Oct-2020 |
Zhenghua Zhou <zhenghuax.zhou@intel.com> |
app/testpmd: do not allow dynamic change of core number
When the number of forwarding cores changed in runtime, the issue may be encountered: If the nbcore set little than current nbcore, the forwar
app/testpmd: do not allow dynamic change of core number
When the number of forwarding cores changed in runtime, the issue may be encountered: If the nbcore set little than current nbcore, the forwarding thread will still running on the extra cores. Therefore, trying to stop forwarding will hang testpmd, since it will wait for the extra cores to stop.
So do not allow to change nbcore number when forwarding is running.
Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display") Cc: stable@dpdk.org
Signed-off-by: Zhenghua Zhou <zhenghuax.zhou@intel.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
1be514fb |
| 22-Oct-2020 |
Andrew Rybchenko <arybchenko@solarflare.com> |
ethdev: remove legacy FDIR filter type support
Instead of FDIR filters RTE flow API should be used.
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Acked-by: Ajit Khaparde <ajit.khapard
ethdev: remove legacy FDIR filter type support
Instead of FDIR filters RTE flow API should be used.
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Acked-by: Haiyue Wang <haiyue.wang@intel.com> Acked-by: Hyong Youb Kim <hyonkim@cisco.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
af270529 |
| 02-Nov-2020 |
Thomas Monjalon <thomas@monjalon.net> |
ethdev: include mbuf registration in Tx timestamp API
Previously, the Tx timestamp field and flag were registered in testpmd, as described in mlx5 guide. For consistency between Rx and Tx timestamps
ethdev: include mbuf registration in Tx timestamp API
Previously, the Tx timestamp field and flag were registered in testpmd, as described in mlx5 guide. For consistency between Rx and Tx timestamps, managing mbuf registrations inside the driver, as properly documented, is a simpler expectation.
The only driver to support this feature (mlx5) is updated as well as the testpmd application.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Acked-by: David Marchand <david.marchand@redhat.com> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Acked-by: Olivier Matz <olivier.matz@6wind.com>
show more ...
|
#
cb056611 |
| 15-Oct-2020 |
Stephen Hemminger <stephen@networkplumber.org> |
eal: rename lcore master and slave
Replace master lcore with main lcore and replace slave lcore with worker lcore.
Keep the old functions and macros but mark them as deprecated for this release.
T
eal: rename lcore master and slave
Replace master lcore with main lcore and replace slave lcore with worker lcore.
Keep the old functions and macros but mark them as deprecated for this release.
The "--master-lcore" command line option is also deprecated and any usage will print a warning and use "--main-lcore" as replacement.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
show more ...
|
#
a8d0d473 |
| 15-Oct-2020 |
Bruce Richardson <bruce.richardson@intel.com> |
build: replace use of old build macros
Use the newer macros defined by meson in all DPDK source code, to ensure there are no errors when the old non-standard macros are removed.
Signed-off-by: Bruc
build: replace use of old build macros
Use the newer macros defined by meson in all DPDK source code, to ensure there are no errors when the old non-standard macros are removed.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Luca Boccassi <bluca@debian.org> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Acked-by: Rosen Xu <rosen.xu@intel.com> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
show more ...
|
#
91c78e09 |
| 16-Oct-2020 |
Viacheslav Ovsiienko <viacheslavo@nvidia.com> |
app/testpmd: add rxoffs commands and parameters
Add command line parameter:
--rxoffs=X[,Y]
Sets the offsets of packet segments from the beginning of the receiving buffer if split feature is engage
app/testpmd: add rxoffs commands and parameters
Add command line parameter:
--rxoffs=X[,Y]
Sets the offsets of packet segments from the beginning of the receiving buffer if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only).
Add interactive mode command, providing the same:
testpmd> set rxoffs (x[,y]*)
Where x[,y]* represents a CSV list of values, without white space.
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
show more ...
|
#
0f2096d7 |
| 16-Oct-2020 |
Viacheslav Ovsiienko <viacheslavo@nvidia.com> |
app/testpmd: add rxpkts commands and parameters
Add command line parameter:
--rxpkts=X[,Y]
Sets the length of segments to scatter packets on receiving if split feature is engaged. Affects only the
app/testpmd: add rxpkts commands and parameters
Add command line parameter:
--rxpkts=X[,Y]
Sets the length of segments to scatter packets on receiving if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only).
Add interactive mode command:
testpmd> set rxpkts (x[,y]*)
Where x[,y]* represents a CSV list of values, without white space.
Sets the length of segments to scatter packets on receiving if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only). Optionally the multiple memory pools can be specified with --mbuf-size command line parameter and the mbufs to receive will be allocated sequentially from these extra memory pools.
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
show more ...
|
#
3b13528a |
| 16-Oct-2020 |
Viacheslav Ovsiienko <viacheslavo@nvidia.com> |
app/testpmd: add buffer split offload configuration
This patch add support for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT providing per queue configuration for this offload.
Signed-off-by: Viacheslav Ovsiienk
app/testpmd: add buffer split offload configuration
This patch add support for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT providing per queue configuration for this offload.
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
show more ...
|
#
26cbb419 |
| 16-Oct-2020 |
Viacheslav Ovsiienko <viacheslavo@nvidia.com> |
app/testpmd: add multiple pools per core creation
The command line parameter --mbuf-size is updated, it can handle the multiple values like the following:
--mbuf-size=2176,512,768,4096
specifying
app/testpmd: add multiple pools per core creation
The command line parameter --mbuf-size is updated, it can handle the multiple values like the following:
--mbuf-size=2176,512,768,4096
specifying the creation the extra memory pools with the requested mbuf data buffer sizes. If some buffer split feature is engaged the extra memory pools can be used to configure the Rx queues with rte_the_dev_rx_queue_setup_ex().
The extra pools are created with requested sizes, and pool names are assigned with appended index: mbuf_pool_socket_%socket_%index. Index zero is used to specify the first mandatory pool to maintain compatibility with existing code.
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
show more ...
|
#
1b9f2746 |
| 16-Oct-2020 |
Gregory Etelson <getelson@nvidia.com> |
app/testpmd: add commands for tunnel offload
Tunnel Offload API provides hardware independent, unified model to offload tunneled traffic. Key model elements are: - apply matches to both outer and i
app/testpmd: add commands for tunnel offload
Tunnel Offload API provides hardware independent, unified model to offload tunneled traffic. Key model elements are: - apply matches to both outer and inner packet headers during entire offload procedure; - restore outer header of partially offloaded packet; - model is implemented as a set of helper functions.
Implementation details:
* Create application tunnel: flow tunnel create <port> type <tunnel type> On success, the command creates application tunnel object and returns the tunnel descriptor. Tunnel descriptor is used in subsequent flow creation commands to reference the tunnel.
* Create tunnel steering flow rule: tunnel_set <tunnel descriptor> parameter used with steering rule template.
* Create tunnel matching flow rule: tunnel_match <tunnel descriptor> used with matching rule template.
* If tunnel steering rule was offloaded, outer header of a partially offloaded packet is restored after miss.
Example: test packet= <Ether dst=24:8a:07:8d:ae:d6 src=50:6b:4b:cc:fc:e2 type=IPv4 | <IP version=4 ihl=5 proto=udp src=1.1.1.1 dst=1.1.1.10 | <UDP sport=4789 dport=4789 len=58 chksum=0x7f7b | <VXLAN NextProtocol=Ethernet vni=0x0 | <Ether dst=24:aa:aa:aa:aa:d6 src=50:bb:bb:bb:bb:e2 type=IPv4 | <IP version=4 ihl=5 proto=icmp src=2.2.2.2 dst=2.2.2.200 | <ICMP type=echo-request code=0 chksum=0xf7ff id=0x0 seq=0x0 |>>>>>>> >>> len(packet) 92
testpmd> flow flush 0 testpmd> port 0/queue 0: received 1 packets src=50:6B:4B:CC:FC:E2 - dst=24:8A:07:8D:AE:D6 - type=0x0800 - length=92
testpmd> flow tunnel 0 type vxlan port 0: flow tunnel #1 type vxlan testpmd> flow create 0 ingress group 0 tunnel_set 1 pattern eth /ipv4 / udp dst is 4789 / vxlan / end actions jump group 0 / end Flow rule #0 created testpmd> port 0/queue 0: received 1 packets tunnel restore info: - vxlan tunnel - outer header present # <-- src=50:6B:4B:CC:FC:E2 - dst=24:8A:07:8D:AE:D6 - type=0x0800 - length=92
testpmd> flow create 0 ingress group 0 tunnel_match 1 pattern eth / ipv4 / udp dst is 4789 / vxlan / eth / ipv4 / end actions set_mac_dst mac_addr 02:CA:FE:CA:FA:80 / queue index 0 / end Flow rule #1 created testpmd> port 0/queue 0: received 1 packets src=50:BB:BB:BB:BB:E2 - dst=02:CA:FE:CA:FA:80 - type=0x0800 - length=42
* Destroy flow tunnel flow tunnel destroy <port> id <tunnel id>
* Show existing flow tunnels flow tunnel list <port>
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
show more ...
|
#
8c2c75be |
| 16-Oct-2020 |
Junyu Jiang <junyux.jiang@intel.com> |
app/testpmd: fix flow flush with invalid port
There is no error info displayed when running flow flush command with invalid port. This patch fixed the issue.
Fixes: 2a449871a12d ("app/testpmd: alig
app/testpmd: fix flow flush with invalid port
There is no error info displayed when running flow flush command with invalid port. This patch fixed the issue.
Fixes: 2a449871a12d ("app/testpmd: align behaviour of multi-port detach") Cc: stable@dpdk.org
Signed-off-by: Junyu Jiang <junyux.jiang@intel.com> Reviewed-by: Suanming Mou <suanmingm@nvidia.com>
show more ...
|
#
55509e3a |
| 14-Oct-2020 |
Andrey Vesnovaty <andreyv@nvidia.com> |
app/testpmd: support shared flow action
This patch adds shared action support to testpmd CLI.
All shared actions created via testpmd CLI assigned ID for further reference in other CLI commands. Sha
app/testpmd: support shared flow action
This patch adds shared action support to testpmd CLI.
All shared actions created via testpmd CLI assigned ID for further reference in other CLI commands. Shared action ID supplied as CLI argument or assigned by testpmd is similar to flow ID & limited to scope of testpdm CLI.
Create shared action syntax: flow shared_action {port_id} create [action_id {shared_action_id}] [ingress] [egress] action {action} / end
Create shared action examples: flow shared_action 0 create action_id 100 \ ingress action rss queues 1 2 end / end This creates shared rss action with id 100 on port 0.
flow shared_action 0 create action_id \ ingress action rss queues 0 1 end / end This creates shared rss action with id assigned by testpmd on port 0.
Update shared action syntax: flow shared_action {port_id} update {shared_action_id} action {action} / end
Update shared action example: flow shared_action 0 update 100 \ action rss queues 0 3 end / end This updates shared rss action having id 100 on port 0 with rss to queues 0 3 (in create example rss queues were 1 & 2).
Destroy shared action syntax: flow shared_action {port_id} destroy action_id {shared_action_id} [...]
Destroy shared action example: flow shared_action 0 destroy action_id 100 action_id 101 This destroys shared actions having id 100 & 101
Query shared action syntax: flow shared_action {port} query {shared_action_id}
Query shared action example: flow shared_action 0 query 100 This queries shared actions having id 100
Use shared action as flow action syntax: flow create {port_id} ... / end actions [action / [...]] shared {action_id} / [action / [...]] end
Use shared action as flow action example: flow create 0 ingress pattern ... / end \ actions shared 100 / end This creates flow rule where rss action is shared rss action having id 100.
All shared action CLIs report status of the command. Shared action query CLI output depends on action type.
Signed-off-by: Andrey Vesnovaty <andreyv@nvidia.com> Acked-by: Ori Kam <orika@nvidia.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
2f622174 |
| 07-Oct-2020 |
Dekel Peled <dekelp@nvidia.com> |
app/testpmd: support query of age action
Following ethdev update in the previous patch of this series, this patch adds CLI support to query information related to AGE action.
Signed-off-by: Dekel P
app/testpmd: support query of age action
Following ethdev update in the previous patch of this series, this patch adds CLI support to query information related to AGE action.
Signed-off-by: Dekel Peled <dekelp@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com>
show more ...
|
#
a16baafb |
| 08-Oct-2020 |
Sarosh Arif <sarosh.arif@emumba.com> |
app/testpmd: add speed capability in device info
Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info"
Bugzilla ID: 496
Si
app/testpmd: add speed capability in device info
Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info"
Bugzilla ID: 496
Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|
#
b19da32e |
| 08-Oct-2020 |
Min Hu (Connor) <humin29@huawei.com> |
app/testpmd: add FEC command
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities -
app/testpmd: add FEC command
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port <port_id> fec_mode auto|off|rs|baser
where:
auto|off|rs|baser are four kinds of FEC mode which dev support according to MAC link speed.
Signed-off-by: Min Hu (Connor) <humin29@huawei.com> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> Reviewed-by: Chengwen Feng <fengchengwen@huawei.com> Reviewed-by: Chengchang Tang <tangchengchang@huawei.com>
show more ...
|
#
62aa0e8c |
| 21-Sep-2020 |
Ferruh Yigit <ferruh.yigit@intel.com> |
app/testpmd: fix build with gcc 11
Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 (experimental)
../app/test-pmd/config.c:1777:61: warning: argument 3 of type ‘const uint32
app/testpmd: fix build with gcc 11
Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 (experimental)
../app/test-pmd/config.c:1777:61: warning: argument 3 of type ‘const uint32_t[n]’ {aka ‘const unsigned int[n]’} declared as a variable length array [-Wvla-parameter] 1777 | port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n]) | ~~~~~~~~~~~~~~~^~~~~~~~ In file included from ../app/test-pmd/config.c:53: ../app/test-pmd/testpmd.h:764:67: note: previously declared as a pointer ‘const uint32_t *’ {aka ‘const unsigned int *’} 764 | void port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group); | ~~~~~~~~~~~~~~~~^~~~~
Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Reviewed-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Asaf Penso <asafp@nvidia.com>
show more ...
|
#
2a449871 |
| 28-Sep-2020 |
Thomas Monjalon <thomas@monjalon.net> |
app/testpmd: align behaviour of multi-port detach
A port can be closed in multiple situations: - close command calling close_port() -> rte_eth_dev_close() - exit calling close_port() -> rte_eth_de
app/testpmd: align behaviour of multi-port detach
A port can be closed in multiple situations: - close command calling close_port() -> rte_eth_dev_close() - exit calling close_port() -> rte_eth_dev_close() - hotplug calling close_port() -> rte_eth_dev_close() - hotplug calling detach_device() -> rte_dev_remove() - port detach command, detach_device() -> rte_dev_remove() - device detach command, detach_devargs() -> rte_eal_hotplug_remove()
The flow rules are flushed before each close. It was already done in close_port(), detach_devargs() and detach_port_device() which calls detach_device(), but not in detach_device(). As a consequence, it was missing for siblings of port detach command and unplugged device. The check before calling port_flow_flush() is moved inside the function.
The state of the port to close is checked to be stopped. As above, this check was missing in detach_device(), impacting the cases of a multi-port device unplugged or detached with the port detach command.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
show more ...
|
#
700ded7a |
| 25-Sep-2020 |
Huisong Li <lihuisong@huawei.com> |
app/testpmd: fix displaying Rx/Tx queues information
Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_c
app/testpmd: fix displaying Rx/Tx queues information
Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf" maintained in testpmd application may be not the value actually used by PMD driver. For instance, user does not set a field, but PMD driver has to use the default value.
This patch fixes rxtx_config_display so that the information of Rx/Tx queues can be really displayed for the PMD driver that implement .rxq_info_get and .txq_info_get ops callback function.
Fixes: 75c530c1bd53 ("app/testpmd: fix port configuration print") Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
show more ...
|