| 2233925d | 09-Jul-2024 |
David Marchand <david.marchand@redhat.com> |
ci: run more checks in private repositories
Though devtools/checkpatches.sh is run as part of our CI, some other (not well known) checks could help when run in private repositories before submitting
ci: run more checks in private repositories
Though devtools/checkpatches.sh is run as part of our CI, some other (not well known) checks could help when run in private repositories before submitting to the mailing list and even when run from the ovsrobot.
Most of them require a git history or checked sources to run. And I can't guarantee there won't be false positives.
Add a new job just for those checks so that it won't block compilation tests in other jobs.
Signed-off-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Robin Jarry <rjarry@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com>
show more ...
|
| 2ea7994a | 31-Jan-2024 |
David Marchand <david.marchand@redhat.com> |
ci: update versions of actions in GHA
GitHub started deprecating GHA actions based on Node 16 [1]. For now, only warnings are raised, but we might as well switch to v4 versions of the common actions
ci: update versions of actions in GHA
GitHub started deprecating GHA actions based on Node 16 [1]. For now, only warnings are raised, but we might as well switch to v4 versions of the common actions, now.
Link: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com>
show more ...
|
| 870623ad | 20-Jun-2023 |
David Marchand <david.marchand@redhat.com> |
ci: fix libabigail cache in GHA
In repositories where multiple branches run the ABI checks using different versions of libabigail (for example, a 22.11 branch using libabigail-1.8 and a main branch
ci: fix libabigail cache in GHA
In repositories where multiple branches run the ABI checks using different versions of libabigail (for example, a 22.11 branch using libabigail-1.8 and a main branch using libabigail-2.1), a collision happens on the libabigail binary cache entry. As a single cache entry is used, the content of the cache (let's say the cache was built for libabigail 2.1) won't match what the branch wants to use (in this example running the check for 22.11 branch requires libabigail 1.8). .ci/linux-build.sh then tries to recompile libabigail but it fails as the packages used for building libabigail are missing.
Add the version to the cache entry name to avoid this collision.
Fixes: 443267090edc ("ci: enable v21 ABI checks") Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com>
show more ...
|
| a3a2bff6 | 15-Dec-2022 |
David Marchand <david.marchand@redhat.com> |
ci: align Ubuntu and Fedora build coverage
Some dependencies were missing for builds in those two environments: - for Ubuntu 20.04: libssl-dev, zlib1g-dev, - for Fedora 35: libarchive-devel, libbsd-
ci: align Ubuntu and Fedora build coverage
Some dependencies were missing for builds in those two environments: - for Ubuntu 20.04: libssl-dev, zlib1g-dev, - for Fedora 35: libarchive-devel, libbsd-devel, jansson-devel,
Signed-off-by: David Marchand <david.marchand@redhat.com>
show more ...
|
| bfc43a0f | 29-Nov-2022 |
David Marchand <david.marchand@redhat.com> |
drivers: fix symbol exports when map is omitted
ld exports any global symbol by default if no version script is passed. As a consequence, the incriminated change let any public symbol leak out of th
drivers: fix symbol exports when map is omitted
ld exports any global symbol by default if no version script is passed. As a consequence, the incriminated change let any public symbol leak out of the driver shared libraries.
Hide again those symbols by providing a default map file which unexports any global symbol using a local: * catch-all statement.
The checks are skipped for this default map file as it is intentionnally an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol maps")) and there is nothing else to check in this map.
This change impacts the exported symbols, hence, bump the version in the ABI check to the v22.11.1 from the 22.11 LTS branch.
Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") Cc: stable@dpdk.org
Reported-by: Luca Boccassi <luca.boccassi@microsoft.com> Signed-off-by: David Marchand <david.marchand@redhat.com> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Aaron Conole <aconole@redhat.com>
show more ...
|