world/kernel: Use the rounddown() macro in various places.

Tested-by: zrj

kernel/disk: Remove use of "%b" format.

Switch to args safe "%pb%i" internal format.

kernel/nata: Deal with ATA_DEV() and atadev->unit.

Hopefully I got all places correctly.

While there, some misc cleanup.

kernel/nata: Misc cleanup in non chipset codes.

* Move some stuff around.
* Add local implementations of biofinish() and g_io_deliver().
* Add prints for READ_NATIVE_MAX_ADDRESS.
* Use >= in

kernel/nata: Misc cleanup in non chipset codes.

* Move some stuff around.
* Add local implementations of biofinish() and g_io_deliver().
* Add prints for READ_NATIVE_MAX_ADDRESS.
* Use >= in comparisons for devclass_get_maxunit()

No functional change.

show more ...

kernel/nata: Return more data for natacontrol(8).

* include info about backing subdisks
* use last 16 bytes of serial number in meta (as MatrixRAID does)
* add optional automatc spindown/spinup s

kernel/nata: Return more data for natacontrol(8).

* include info about backing subdisks
* use last 16 bytes of serial number in meta (as MatrixRAID does)
* add optional automatc spindown/spinup support (dmesg noisy)
* various cleanups
* natacontrol(8) additions + cleanup

Taken-from: FreeBSD

show more ...

kernel - Cleanup gcc warnings

* Cleanup gcc warnings at higher optimization levels. This will allow
us to build kernels -O2 or -O3.

kernel - Fix boot-time panic in NATA revealed by new callout mechanics

* The NATA driver was using spin locks in a very, very dangerous way.
They did not play nice with the new blocking callout me

kernel - Fix boot-time panic in NATA revealed by new callout mechanics

* The NATA driver was using spin locks in a very, very dangerous way.
They did not play nice with the new blocking callout mechanism.

* Replace all of NATAs spinlocks with lockmgr locks. In addition, change
all asynchronous callout_stop() calls to synchronous callout_stop_sync()
calls, and use callout_init_lk() to auto-lock ch->state_lock for the
callback, which fixes a long-time deadlock race.

Reported-by: tuxillo

show more ...

kernel/spinlock: Add a description to struct spinlock.

And add it to spin_init() and SPINLOCK_INITIALIZER().

Submitted-by: dclink (see <http://bugs.dragonflybsd.org/issues/2714>)
OK'd-by: dill

kernel/spinlock: Add a description to struct spinlock.

And add it to spin_init() and SPINLOCK_INITIALIZER().

Submitted-by: dclink (see <http://bugs.dragonflybsd.org/issues/2714>)
OK'd-by: dillon

show more ...

Convert files to UTF-8

Taken-from: FreeBSD

kernel/nataraid: Fix an issue with the devstat support I added recently.

This fixes the "devstat_end_transaction: HELP!! busy_count for ar0 is < 0"
we were seeing.

Tested-by: Aaron Bieber <deftly@g

kernel/nataraid: Fix an issue with the devstat support I added recently.

This fixes the "devstat_end_transaction: HELP!! busy_count for ar0 is < 0"
we were seeing.

Tested-by: Aaron Bieber <deftly@gmail.com>

show more ...

kernel/nataraid: Fix a panic upon booting with a degraded Intel RAID.

disk_idx has upper bits set in this case which we need to mask.

Taken-from: FreeBSD's r205074
Reported-and-tested-b

kernel/nataraid: Fix a panic upon booting with a degraded Intel RAID.

disk_idx has upper bits set in this case which we need to mask.

Taken-from: FreeBSD's r205074
Reported-and-tested-by: Aaron Bieber <deftly@gmail.com>

show more ...

kernel/nataraid: Fix a bug for array sizes >2TB.

The overall array size (total_sectors) in the softc was already 64 bit
wide but due to a missing cast when multiplying the 32 bit disk size
by the nu

kernel/nataraid: Fix a bug for array sizes >2TB.

The overall array size (total_sectors) in the softc was already 64 bit
wide but due to a missing cast when multiplying the 32 bit disk size
by the number of disks, it never became larger than 32 bits.

Also, the disk size was signed when it should have been unsigned.

Note that these fixes apply to RAIDs created using natacontrol(8), but
not necessarily to those created with BIOS utilities.

Reported-by: Aaron Bieber <deftly@gmail.com>

show more ...

kernel/nataraid: Add devstat support.

kernel/nataraid: Fix nVidia MediaShield metadata kprintfs for unsigned.

kernel: Use DEVMETHOD_END in the drivers.

kernel/disk: Remove some unused variables and add __debugvar.

Remove some duplicated semicolons (mostly in the kernel).

Revert "nataraid(4): Add devstat support."

This reverts commit 3e184884618d66845f8b90e6dae483155da6dce6.

Oops, it was a bit too untested and causes nasty messages on the
console. Will investigate a

Revert "nataraid(4): Add devstat support."

This reverts commit 3e184884618d66845f8b90e6dae483155da6dce6.

Oops, it was a bit too untested and causes nasty messages on the
console. Will investigate and commit a proper fix.

Reported-by: Joerg Anslik <joerg@anslik.de>

show more ...

nataraid(4): Add devstat support.

kernel: Remove some old major numbers.

kernel - Work through some memory leaks in dsched

* Add a uninitbufbio() function to complement initbufbio(). Also move
BUF_LOCKINIT() into initbufbio() and BUF_LOCKFREE() into uninitbufbio().

*

kernel - Work through some memory leaks in dsched

* Add a uninitbufbio() function to complement initbufbio(). Also move
BUF_LOCKINIT() into initbufbio() and BUF_LOCKFREE() into uninitbufbio().

* There are several device drivers and other places where the struct buf
is still being allocated manually (verses using getpbuf()). These were
kfree()ing the buffer without dealing with e.g. dsched_exit_buf().

Have uninitbufbio() call dsched_exit_buf() and adjust the various manual
allocations/frees of struct buf to call uninitbufbio() before kfree()ing.
Also remove various manual calls to BUF_LOCKFREE() (which is now done
inside uninitbufbio()).

* This should hopefully deal with the memory leaks but there could be a
few left.

Reported-by: "Steve O'Hara-Smith" <steve@sohara.org>

show more ...

spinlocks - Rename API to spin_{try,un,}lock

* Rename the API to spin_trylock, spin_unlock and spin_lock instead of
spin_lock_wr, spin_unlock_wr and spin_trylock_wr now that we only have
exclusi

spinlocks - Rename API to spin_{try,un,}lock

* Rename the API to spin_trylock, spin_unlock and spin_lock instead of
spin_lock_wr, spin_unlock_wr and spin_trylock_wr now that we only have
exclusive spinlocks.

* 99% of this patch was generated by a semantic coccinelle patch

show more ...

kernel - gcc -Os/-O2 warnings pass

* This is just a partial pass on the code to start cleaning up gcc
warnings at higher optimization levels.

dump - Make use of the new dumping

* Adapt our dumping infrastructure to the new dump type.

* Update all disk/raid dump methods (except aac) to work with the new
dumps. These now don't take matte

dump - Make use of the new dumping

* Adapt our dumping infrastructure to the new dump type.

* Update all disk/raid dump methods (except aac) to work with the new
dumps. These now don't take matters into their own hands and just write
what they are told to.

show more ...

MPSAFE - tsleep_interlock, BUF/BIO, cluster, swap_pager.

* tsleep_interlock()/tsleep() could miss wakeups during periods of
heavy cpu activity. What would happen is code inbetween the two
calls

MPSAFE - tsleep_interlock, BUF/BIO, cluster, swap_pager.

* tsleep_interlock()/tsleep() could miss wakeups during periods of
heavy cpu activity. What would happen is code inbetween the two
calls would try to send an IPI (say, issue a wakeup()), but while
sending the IPI the kernel would be forced to process incoming IPIs
synchronous to avoid a deadlock.

The new tsleep_interlock()/tsleep() code adds another TAILQ_ENTRY to
the thread structure allowing tsleep_interlock() to formally place
the thread on the appropriate sleep queue without having to deschedule
the thread. Any wakeup which occurs between the interlock and the
real tsleep() call will remove the thread from the queue and the
later tsleep() call will recognize this and simply return without sleeping.

The new tsleep() call requires PINTERLOCKED to be passed to tsleep
so tsleep() knows that the thread has already been placed on a sleep
queue.

* Continue making BUF/BIO MPSAFE. Remove B_ASYNC and B_WANT from buf->b_flag
and add a new bio->bio_flags field to the bio. Add BIO_SYNC, BIO_WANT,
and BIO_DONE. Use atomic_cmpset_int() (aka cmpxchg) to interlock
biodone() against biowait().

vn_strategy() and dev_dstrategy() call semantics now require that
synchronous BIO's install a bio_done function and set BIO_SYNC in
the bio.

* Clean up the cluster code a bit.

* Redo the swap_pager code. Instead of issuing I/O during the collection,
which depended on critical sections to avoid races in the cluster append,
we now build the entire collection first and then dispatch the I/O.
This allows us to use only async completion for the BIOs, instead of
a hybrid sync-or-async completion.

show more ...