xref: /spdk/test/unit/lib/nvmf/fc.c/fc_ut.c (revision 9889ab2dc80e40dae92dcef361d53dcba722043d)
1 /*
2  *   BSD LICENSE
3  *
4  *   Copyright (c) 2018-2019 Broadcom.  All Rights Reserved.
5  *   The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
6  *
7  *   Redistribution and use in source and binary forms, with or without
8  *   modification, are permitted provided that the following conditions
9  *   are met:
10  *
11  *     * Redistributions of source code must retain the above copyright
12  *       notice, this list of conditions and the following disclaimer.
13  *     * Redistributions in binary form must reproduce the above copyright
14  *       notice, this list of conditions and the following disclaimer in
15  *       the documentation and/or other materials provided with the
16  *       distribution.
17  *     * Neither the name of Intel Corporation nor the names of its
18  *       contributors may be used to endorse or promote products derived
19  *       from this software without specific prior written permission.
20  *
21  *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
22  *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
23  *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
24  *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
25  *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
26  *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
27  *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
28  *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
29  *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
30  *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
31  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
32  */
33 
34 /* NVMF FC Transport Unit Test */
35 
36 #include "spdk/env.h"
37 #include "spdk_cunit.h"
38 #include "spdk/nvmf.h"
39 #include "spdk_internal/event.h"
40 #include "spdk/endian.h"
41 #include "spdk/trace.h"
42 #include "spdk_internal/log.h"
43 
44 #include "ut_multithread.c"
45 
46 #include "transport.h"
47 #include "nvmf_internal.h"
48 #include "nvmf_fc.h"
49 
50 #include "json/json_util.c"
51 #include "json/json_write.c"
52 #include "nvmf/nvmf.c"
53 #include "nvmf/transport.c"
54 #include "nvmf/subsystem.c"
55 #include "nvmf/fc.c"
56 #include "nvmf/fc_ls.c"
57 
58 /*
59  * SPDK Stuff
60  */
61 
62 #ifdef SPDK_CONFIG_RDMA
63 const struct spdk_nvmf_transport_ops spdk_nvmf_transport_rdma = {
64 	.type = SPDK_NVME_TRANSPORT_RDMA,
65 	.opts_init = NULL,
66 	.create = NULL,
67 	.destroy = NULL,
68 
69 	.listen = NULL,
70 	.stop_listen = NULL,
71 	.accept = NULL,
72 
73 	.listener_discover = NULL,
74 
75 	.poll_group_create = NULL,
76 	.poll_group_destroy = NULL,
77 	.poll_group_add = NULL,
78 	.poll_group_poll = NULL,
79 
80 	.req_free = NULL,
81 	.req_complete = NULL,
82 
83 	.qpair_fini = NULL,
84 	.qpair_get_peer_trid = NULL,
85 	.qpair_get_local_trid = NULL,
86 	.qpair_get_listen_trid = NULL,
87 };
88 #endif
89 
90 const struct spdk_nvmf_transport_ops spdk_nvmf_transport_tcp = {
91 	.type = SPDK_NVME_TRANSPORT_TCP,
92 };
93 
94 struct spdk_trace_histories *g_trace_histories;
95 
96 DEFINE_STUB_V(_spdk_trace_record, (uint64_t tsc, uint16_t tpoint_id, uint16_t poller_id,
97 				   uint32_t size, uint64_t object_id, uint64_t arg1));
98 DEFINE_STUB(spdk_env_get_core_count, uint32_t, (void), 4);
99 DEFINE_STUB(spdk_nvme_transport_id_compare, int,
100 	    (const struct spdk_nvme_transport_id *trid1,
101 	     const struct spdk_nvme_transport_id *trid2), 0);
102 DEFINE_STUB_V(spdk_trace_register_object, (uint8_t type, char id_prefix));
103 DEFINE_STUB_V(spdk_trace_register_description,
104 	      (const char *name, uint16_t tpoint_id, uint8_t owner_type,
105 	       uint8_t object_type, uint8_t new_object, uint8_t arg1_type,
106 	       const char *arg1_name));
107 DEFINE_STUB_V(spdk_trace_add_register_fn, (struct spdk_trace_register_fn *reg_fn));
108 DEFINE_STUB(spdk_bdev_get_name, const char *, (const struct spdk_bdev *bdev), "fc_ut_test");
109 DEFINE_STUB_V(spdk_nvmf_ctrlr_destruct, (struct spdk_nvmf_ctrlr *ctrlr));
110 DEFINE_STUB_V(spdk_nvmf_qpair_free_aer, (struct spdk_nvmf_qpair *qpair));
111 DEFINE_STUB(spdk_bdev_get_io_channel, struct spdk_io_channel *, (struct spdk_bdev_desc *desc),
112 	    NULL);
113 DEFINE_STUB_V(spdk_nvmf_request_exec, (struct spdk_nvmf_request *req));
114 DEFINE_STUB_V(spdk_nvmf_ctrlr_ns_changed, (struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid));
115 DEFINE_STUB(spdk_bdev_open, int, (struct spdk_bdev *bdev, bool write,
116 				  spdk_bdev_remove_cb_t remove_cb,
117 				  void *remove_ctx, struct spdk_bdev_desc **desc), 0);
118 DEFINE_STUB_V(spdk_bdev_close, (struct spdk_bdev_desc *desc));
119 DEFINE_STUB(spdk_bdev_module_claim_bdev, int,
120 	    (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc,
121 	     struct spdk_bdev_module *module), 0);
122 DEFINE_STUB_V(spdk_bdev_module_release_bdev, (struct spdk_bdev *bdev));
123 DEFINE_STUB(spdk_bdev_get_block_size, uint32_t, (const struct spdk_bdev *bdev), 512);
124 DEFINE_STUB(spdk_bdev_get_num_blocks, uint64_t, (const struct spdk_bdev *bdev), 1024);
125 
126 DEFINE_STUB(spdk_nvmf_ctrlr_async_event_ns_notice, int, (struct spdk_nvmf_ctrlr *ctrlr), 0);
127 
128 const char *
129 spdk_nvme_transport_id_trtype_str(enum spdk_nvme_transport_type trtype)
130 {
131 	switch (trtype) {
132 	case SPDK_NVME_TRANSPORT_PCIE:
133 		return "PCIe";
134 	case SPDK_NVME_TRANSPORT_RDMA:
135 		return "RDMA";
136 	case SPDK_NVME_TRANSPORT_FC:
137 		return "FC";
138 	default:
139 		return NULL;
140 	}
141 }
142 
143 const char *
144 spdk_nvme_transport_id_adrfam_str(enum spdk_nvmf_adrfam adrfam)
145 {
146 	switch (adrfam) {
147 	case SPDK_NVMF_ADRFAM_IPV4:
148 		return "IPv4";
149 	case SPDK_NVMF_ADRFAM_IPV6:
150 		return "IPv6";
151 	case SPDK_NVMF_ADRFAM_IB:
152 		return "IB";
153 	case SPDK_NVMF_ADRFAM_FC:
154 		return "FC";
155 	default:
156 		return NULL;
157 	}
158 }
159 
160 const struct spdk_uuid *
161 spdk_bdev_get_uuid(const struct spdk_bdev *bdev)
162 {
163 	return &bdev->uuid;
164 }
165 
166 static bool g_lld_init_called = false;
167 
168 int
169 nvmf_fc_lld_init(void)
170 {
171 	g_lld_init_called = true;
172 	return 0;
173 }
174 
175 static bool g_lld_fini_called = false;
176 
177 void
178 nvmf_fc_lld_fini(void)
179 {
180 	g_lld_fini_called = true;
181 }
182 
183 DEFINE_STUB_V(nvmf_fc_lld_start, (void));
184 DEFINE_STUB(nvmf_fc_init_q, int, (struct spdk_nvmf_fc_hwqp *hwqp), 0);
185 DEFINE_STUB_V(nvmf_fc_reinit_q, (void *queues_prev, void *queues_curr));
186 DEFINE_STUB(nvmf_fc_init_rqpair_buffers, int, (struct spdk_nvmf_fc_hwqp *hwqp), 0);
187 DEFINE_STUB(nvmf_fc_set_q_online_state, int, (struct spdk_nvmf_fc_hwqp *hwqp, bool online), 0);
188 DEFINE_STUB(nvmf_fc_put_xchg, int, (struct spdk_nvmf_fc_hwqp *hwqp, struct spdk_nvmf_fc_xchg *xri),
189 	    0);
190 DEFINE_STUB(nvmf_fc_recv_data, int, (struct spdk_nvmf_fc_request *fc_req), 0);
191 DEFINE_STUB(nvmf_fc_send_data, int, (struct spdk_nvmf_fc_request *fc_req), 0);
192 DEFINE_STUB_V(nvmf_fc_rqpair_buffer_release, (struct spdk_nvmf_fc_hwqp *hwqp, uint16_t buff_idx));
193 DEFINE_STUB(nvmf_fc_xmt_rsp, int, (struct spdk_nvmf_fc_request *fc_req, uint8_t *ersp_buf,
194 				   uint32_t ersp_len), 0);
195 DEFINE_STUB(nvmf_fc_xmt_ls_rsp, int, (struct spdk_nvmf_fc_nport *tgtport,
196 				      struct spdk_nvmf_fc_ls_rqst *ls_rqst), 0);
197 DEFINE_STUB(nvmf_fc_issue_abort, int, (struct spdk_nvmf_fc_hwqp *hwqp,
198 				       struct spdk_nvmf_fc_xchg *xri,
199 				       spdk_nvmf_fc_caller_cb cb, void *cb_args), 0);
200 DEFINE_STUB(nvmf_fc_xmt_bls_rsp, int, (struct spdk_nvmf_fc_hwqp *hwqp,
201 				       uint16_t ox_id, uint16_t rx_id,
202 				       uint16_t rpi, bool rjt, uint8_t rjt_exp,
203 				       spdk_nvmf_fc_caller_cb cb, void *cb_args), 0);
204 DEFINE_STUB(nvmf_fc_alloc_srsr_bufs, struct spdk_nvmf_fc_srsr_bufs *, (size_t rqst_len,
205 		size_t rsp_len), NULL);
206 DEFINE_STUB_V(nvmf_fc_free_srsr_bufs, (struct spdk_nvmf_fc_srsr_bufs *srsr_bufs));
207 DEFINE_STUB(nvmf_fc_xmt_srsr_req, int, (struct spdk_nvmf_fc_hwqp *hwqp,
208 					struct spdk_nvmf_fc_srsr_bufs *xmt_srsr_bufs,
209 					spdk_nvmf_fc_caller_cb cb, void *cb_args), 0);
210 DEFINE_STUB(nvmf_fc_q_sync_available, bool, (void), true);
211 DEFINE_STUB(nvmf_fc_issue_q_sync, int, (struct spdk_nvmf_fc_hwqp *hwqp, uint64_t u_id,
212 					uint16_t skip_rq), 0);
213 DEFINE_STUB(nvmf_fc_assign_conn_to_hwqp, bool, (struct spdk_nvmf_fc_hwqp *hwqp,
214 		uint64_t *conn_id, uint32_t sq_size), true);
215 DEFINE_STUB(nvmf_fc_get_hwqp_from_conn_id, struct spdk_nvmf_fc_hwqp *,
216 	    (struct spdk_nvmf_fc_hwqp *queues,
217 	     uint32_t num_queues, uint64_t conn_id), NULL);
218 DEFINE_STUB_V(nvmf_fc_release_conn, (struct spdk_nvmf_fc_hwqp *hwqp, uint64_t conn_id,
219 				     uint32_t sq_size));
220 DEFINE_STUB_V(nvmf_fc_dump_all_queues, (struct spdk_nvmf_fc_hwqp *ls_queue,
221 					struct spdk_nvmf_fc_hwqp *io_queues,
222 					uint32_t num_io_queues,
223 					struct spdk_nvmf_fc_queue_dump_info *dump_info));
224 DEFINE_STUB_V(nvmf_fc_get_xri_info, (struct spdk_nvmf_fc_hwqp *hwqp,
225 				     struct spdk_nvmf_fc_xchg_info *info));
226 DEFINE_STUB(nvmf_fc_get_rsvd_thread, struct spdk_thread *, (void), NULL);
227 
228 uint32_t
229 nvmf_fc_process_queue(struct spdk_nvmf_fc_hwqp *hwqp)
230 {
231 	hwqp->lcore_id++;
232 	return 0; /* always return 0 or else it will poll forever */
233 }
234 
235 struct spdk_nvmf_fc_xchg *
236 nvmf_fc_get_xri(struct spdk_nvmf_fc_hwqp *hwqp)
237 {
238 	static struct spdk_nvmf_fc_xchg xchg;
239 
240 	xchg.xchg_id = 1;
241 	return &xchg;
242 }
243 
244 #define MAX_FC_UT_POLL_THREADS 8
245 static struct spdk_nvmf_poll_group *g_poll_groups[MAX_FC_UT_POLL_THREADS] = {0};
246 #define MAX_FC_UT_HWQPS MAX_FC_UT_POLL_THREADS
247 static struct spdk_nvmf_tgt *g_nvmf_tgt = NULL;
248 static struct spdk_nvmf_transport *g_nvmf_tprt = NULL;
249 uint8_t g_fc_port_handle = 0xff;
250 struct spdk_nvmf_fc_hwqp lld_q[MAX_FC_UT_HWQPS];
251 
252 static void
253 _add_transport_done(void *arg, int status)
254 {
255 	CU_ASSERT(status == 0);
256 }
257 
258 static void
259 _add_transport_done_dup_err(void *arg, int status)
260 {
261 	CU_ASSERT(status == -EEXIST);
262 }
263 
264 static void
265 create_transport_test(void)
266 {
267 	const struct spdk_nvmf_transport_ops *ops = NULL;
268 	struct spdk_nvmf_transport_opts opts = { 0 };
269 	struct spdk_nvmf_target_opts tgt_opts = {
270 		.name = "nvmf_test_tgt",
271 		.max_subsystems = 0
272 	};
273 
274 	allocate_threads(8);
275 	set_thread(0);
276 
277 	g_nvmf_tgt = spdk_nvmf_tgt_create(&tgt_opts);
278 	SPDK_CU_ASSERT_FATAL(g_nvmf_tgt != NULL);
279 
280 	ops = spdk_nvmf_get_transport_ops((enum spdk_nvme_transport_type) SPDK_NVMF_TRTYPE_FC);
281 	SPDK_CU_ASSERT_FATAL(ops != NULL);
282 
283 	ops->opts_init(&opts);
284 
285 	g_lld_init_called = false;
286 	g_nvmf_tprt = spdk_nvmf_transport_create((enum spdk_nvme_transport_type) SPDK_NVMF_TRTYPE_FC,
287 			&opts);
288 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
289 
290 	CU_ASSERT(g_lld_init_called == true);
291 	CU_ASSERT(opts.max_queue_depth == g_nvmf_tprt->opts.max_queue_depth);
292 	CU_ASSERT(opts.max_qpairs_per_ctrlr == g_nvmf_tprt->opts.max_qpairs_per_ctrlr);
293 	CU_ASSERT(opts.in_capsule_data_size == g_nvmf_tprt->opts.in_capsule_data_size);
294 	CU_ASSERT(opts.max_io_size == g_nvmf_tprt->opts.max_io_size);
295 	CU_ASSERT(opts.io_unit_size == g_nvmf_tprt->opts.io_unit_size);
296 	CU_ASSERT(opts.max_aq_depth == g_nvmf_tprt->opts.max_aq_depth);
297 
298 	set_thread(0);
299 
300 	spdk_nvmf_tgt_add_transport(g_nvmf_tgt, g_nvmf_tprt,
301 				    _add_transport_done, 0);
302 	poll_thread(0);
303 
304 	/* Add transport again - should get error */
305 	spdk_nvmf_tgt_add_transport(g_nvmf_tgt, g_nvmf_tprt,
306 				    _add_transport_done_dup_err, 0);
307 	poll_thread(0);
308 
309 	/* create transport with bad args/options */
310 #ifndef SPDK_CONFIG_RDMA
311 	CU_ASSERT(spdk_nvmf_transport_create(SPDK_NVMF_TRTYPE_RDMA, &opts) == NULL);
312 #endif
313 	CU_ASSERT(spdk_nvmf_transport_create(998, &opts) == NULL);
314 	opts.max_io_size = 1024 ^ 3;
315 	CU_ASSERT(spdk_nvmf_transport_create((enum spdk_nvme_transport_type) SPDK_NVMF_TRTYPE_FC,
316 					     &opts) == NULL);
317 	opts.max_io_size = 999;
318 	opts.io_unit_size = 1024;
319 	CU_ASSERT(spdk_nvmf_transport_create((enum spdk_nvme_transport_type) SPDK_NVMF_TRTYPE_FC,
320 					     &opts) == NULL);
321 }
322 
323 static void
324 port_init_cb(uint8_t port_handle, enum spdk_fc_event event_type, void *arg, int err)
325 {
326 	CU_ASSERT(err == 0);
327 	CU_ASSERT(port_handle == 2);
328 	g_fc_port_handle = port_handle;
329 }
330 
331 static void
332 create_fc_port_test(void)
333 {
334 	struct spdk_nvmf_fc_hw_port_init_args init_args = { 0 };
335 	struct spdk_nvmf_fc_port *fc_port = NULL;
336 	int err;
337 
338 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
339 
340 	init_args.port_handle = 2;
341 	init_args.io_queue_cnt = spdk_min(MAX_FC_UT_HWQPS, spdk_env_get_core_count());
342 	init_args.ls_queue_size = 100;
343 	init_args.io_queue_size = 100;
344 	init_args.io_queues = (void *)lld_q;
345 
346 	set_thread(0);
347 	err = spdk_nvmf_fc_master_enqueue_event(SPDK_FC_HW_PORT_INIT, (void *)&init_args, port_init_cb);
348 	CU_ASSERT(err == 0);
349 	poll_thread(0);
350 
351 	fc_port = spdk_nvmf_fc_port_lookup(g_fc_port_handle);
352 	CU_ASSERT(fc_port != NULL);
353 }
354 
355 static void
356 online_fc_port_test(void)
357 {
358 	struct spdk_nvmf_fc_port *fc_port;
359 	struct spdk_nvmf_fc_hw_port_online_args args;
360 	int err;
361 
362 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
363 
364 	fc_port = spdk_nvmf_fc_port_lookup(g_fc_port_handle);
365 	SPDK_CU_ASSERT_FATAL(fc_port != NULL);
366 
367 	set_thread(0);
368 	args.port_handle = g_fc_port_handle;
369 	err = spdk_nvmf_fc_master_enqueue_event(SPDK_FC_HW_PORT_ONLINE, (void *)&args, port_init_cb);
370 	CU_ASSERT(err == 0);
371 	poll_threads();
372 	set_thread(0);
373 	if (err == 0) {
374 		uint32_t i;
375 		for (i = 0; i < fc_port->num_io_queues; i++) {
376 			CU_ASSERT(fc_port->io_queues[i].fgroup != 0);
377 			CU_ASSERT(fc_port->io_queues[i].fgroup != 0);
378 			CU_ASSERT(fc_port->io_queues[i].fgroup->hwqp_count != 0);
379 		}
380 	}
381 }
382 
383 static void
384 create_poll_groups_test(void)
385 {
386 	unsigned i;
387 
388 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
389 
390 	for (i = 0; i < MAX_FC_UT_POLL_THREADS; i++) {
391 		set_thread(i);
392 		g_poll_groups[i] = spdk_nvmf_poll_group_create(g_nvmf_tgt);
393 		poll_thread(i);
394 		CU_ASSERT(g_poll_groups[i] != NULL);
395 	}
396 	set_thread(0);
397 }
398 
399 static void
400 poll_group_poll_test(void)
401 {
402 	unsigned i;
403 	unsigned poll_cnt =  10;
404 	struct spdk_nvmf_fc_port *fc_port = NULL;
405 
406 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
407 
408 	set_thread(0);
409 	fc_port = spdk_nvmf_fc_port_lookup(g_fc_port_handle);
410 	SPDK_CU_ASSERT_FATAL(fc_port != NULL);
411 
412 	for (i = 0; i < fc_port->num_io_queues; i++) {
413 		fc_port->io_queues[i].lcore_id = 0;
414 	}
415 
416 	for (i = 0; i < poll_cnt; i++) {
417 		/* this should cause spdk_nvmf_fc_poll_group_poll to be called() */
418 		poll_threads();
419 	}
420 
421 	/* check if hwqp's lcore_id has been updated */
422 	for (i = 0; i < fc_port->num_io_queues; i++) {
423 		CU_ASSERT(fc_port->io_queues[i].lcore_id == poll_cnt);
424 	}
425 }
426 
427 static void
428 remove_hwqps_from_poll_groups_test(void)
429 {
430 	unsigned i;
431 	struct spdk_nvmf_fc_port *fc_port = NULL;
432 
433 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
434 
435 	fc_port = spdk_nvmf_fc_port_lookup(g_fc_port_handle);
436 	SPDK_CU_ASSERT_FATAL(fc_port != NULL);
437 
438 	for (i = 0; i < fc_port->num_io_queues; i++) {
439 		spdk_nvmf_fc_poll_group_remove_hwqp(&fc_port->io_queues[i]);
440 		poll_threads();
441 		CU_ASSERT(fc_port->io_queues[i].fgroup == 0);
442 	}
443 }
444 
445 static void
446 destroy_transport_test(void)
447 {
448 	unsigned i;
449 
450 	set_thread(0);
451 	SPDK_CU_ASSERT_FATAL(g_nvmf_tprt != NULL);
452 
453 	for (i = 0; i < MAX_FC_UT_POLL_THREADS; i++) {
454 		set_thread(i);
455 		spdk_nvmf_poll_group_destroy(g_poll_groups[i]);
456 		poll_thread(0);
457 	}
458 
459 	SPDK_CU_ASSERT_FATAL(g_nvmf_tgt != NULL);
460 	g_lld_fini_called = false;
461 	spdk_nvmf_tgt_destroy(g_nvmf_tgt, NULL, NULL);
462 	poll_threads();
463 	CU_ASSERT(g_lld_fini_called == true);
464 }
465 
466 static int
467 nvmf_fc_tests_init(void)
468 {
469 	return 0;
470 }
471 
472 static int
473 nvmf_fc_tests_fini(void)
474 {
475 	free_threads();
476 	return 0;
477 }
478 
479 int main(int argc, char **argv)
480 {
481 	unsigned int num_failures = 0;
482 	CU_pSuite suite = NULL;
483 
484 	if (CU_initialize_registry() != CUE_SUCCESS) {
485 		return CU_get_error();
486 	}
487 
488 	suite = CU_add_suite("NVMf-FC", nvmf_fc_tests_init, nvmf_fc_tests_fini);
489 	if (suite == NULL) {
490 		CU_cleanup_registry();
491 		return CU_get_error();
492 	}
493 
494 	if (CU_add_test(suite, "Create Target & FC Transport",
495 			create_transport_test) == NULL) {
496 		CU_cleanup_registry();
497 		return CU_get_error();
498 	}
499 
500 	if (CU_add_test(suite, "Create Poll Groups",
501 			create_poll_groups_test) == NULL) {
502 		CU_cleanup_registry();
503 		return CU_get_error();
504 	}
505 
506 	if (CU_add_test(suite, "Create FC Port",
507 			create_fc_port_test) == NULL) {
508 		CU_cleanup_registry();
509 		return CU_get_error();
510 	}
511 
512 
513 	if (CU_add_test(suite, "Online FC Port",
514 			online_fc_port_test) == NULL) {
515 		CU_cleanup_registry();
516 		return CU_get_error();
517 	}
518 
519 	if (CU_add_test(suite, "PG poll", poll_group_poll_test) == NULL) {
520 		CU_cleanup_registry();
521 		return CU_get_error();
522 	}
523 
524 	if (CU_add_test(suite, "Remove HWQP's from PG's",
525 			remove_hwqps_from_poll_groups_test) == NULL) {
526 		CU_cleanup_registry();
527 		return CU_get_error();
528 	}
529 
530 	if (CU_add_test(suite, "Destroy Transport & Target",
531 			destroy_transport_test) == NULL) {
532 		CU_cleanup_registry();
533 		return CU_get_error();
534 	}
535 
536 	CU_basic_set_mode(CU_BRM_VERBOSE);
537 	CU_basic_run_tests();
538 	num_failures = CU_get_number_of_failures();
539 	CU_cleanup_registry();
540 
541 	return num_failures;
542 }
543