1 /*- 2 * BSD LICENSE 3 * 4 * Copyright (c) Intel Corporation. 5 * All rights reserved. 6 * 7 * Redistribution and use in source and binary forms, with or without 8 * modification, are permitted provided that the following conditions 9 * are met: 10 * 11 * * Redistributions of source code must retain the above copyright 12 * notice, this list of conditions and the following disclaimer. 13 * * Redistributions in binary form must reproduce the above copyright 14 * notice, this list of conditions and the following disclaimer in 15 * the documentation and/or other materials provided with the 16 * distribution. 17 * * Neither the name of Intel Corporation nor the names of its 18 * contributors may be used to endorse or promote products derived 19 * from this software without specific prior written permission. 20 * 21 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 22 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 23 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 24 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 25 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 26 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 27 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 28 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 29 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 30 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 31 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 32 */ 33 34 #include "spdk/stdinc.h" 35 36 #include "spdk_cunit.h" 37 #include "spdk_internal/mock.h" 38 39 #include "common/lib/test_env.c" 40 #include "nvmf/ctrlr.c" 41 42 SPDK_LOG_REGISTER_COMPONENT("nvmf", SPDK_LOG_NVMF) 43 44 struct spdk_bdev { 45 int ut_mock; 46 uint64_t blockcnt; 47 }; 48 49 DEFINE_STUB(spdk_nvmf_tgt_find_subsystem, 50 struct spdk_nvmf_subsystem *, 51 (struct spdk_nvmf_tgt *tgt, const char *subnqn), 52 NULL); 53 54 DEFINE_STUB(spdk_nvmf_poll_group_create, 55 struct spdk_nvmf_poll_group *, 56 (struct spdk_nvmf_tgt *tgt), 57 NULL); 58 59 DEFINE_STUB_V(spdk_nvmf_poll_group_destroy, 60 (struct spdk_nvmf_poll_group *group)); 61 62 DEFINE_STUB_V(spdk_nvmf_transport_qpair_fini, 63 (struct spdk_nvmf_qpair *qpair)); 64 65 DEFINE_STUB(spdk_nvmf_poll_group_add, 66 int, 67 (struct spdk_nvmf_poll_group *group, struct spdk_nvmf_qpair *qpair), 68 0); 69 70 DEFINE_STUB(spdk_nvmf_poll_group_remove, 71 int, 72 (struct spdk_nvmf_poll_group *group, struct spdk_nvmf_qpair *qpair), 73 0); 74 75 DEFINE_STUB(spdk_nvmf_subsystem_get_sn, 76 const char *, 77 (const struct spdk_nvmf_subsystem *subsystem), 78 NULL); 79 80 DEFINE_STUB(spdk_nvmf_subsystem_get_ns, 81 struct spdk_nvmf_ns *, 82 (struct spdk_nvmf_subsystem *subsystem, uint32_t nsid), 83 NULL); 84 85 DEFINE_STUB(spdk_nvmf_subsystem_get_first_ns, 86 struct spdk_nvmf_ns *, 87 (struct spdk_nvmf_subsystem *subsystem), 88 NULL); 89 90 DEFINE_STUB(spdk_nvmf_subsystem_get_next_ns, 91 struct spdk_nvmf_ns *, 92 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ns *prev_ns), 93 NULL); 94 95 DEFINE_STUB(spdk_nvmf_subsystem_host_allowed, 96 bool, 97 (struct spdk_nvmf_subsystem *subsystem, const char *hostnqn), 98 true); 99 100 DEFINE_STUB(spdk_nvmf_subsystem_add_ctrlr, 101 int, 102 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr), 103 0); 104 105 DEFINE_STUB_V(spdk_nvmf_subsystem_remove_ctrlr, 106 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr)); 107 108 DEFINE_STUB(spdk_nvmf_subsystem_get_ctrlr, 109 struct spdk_nvmf_ctrlr *, 110 (struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid), 111 NULL); 112 113 DEFINE_STUB(spdk_nvmf_ctrlr_dsm_supported, 114 bool, 115 (struct spdk_nvmf_ctrlr *ctrlr), 116 false); 117 118 DEFINE_STUB(spdk_nvmf_ctrlr_write_zeroes_supported, 119 bool, 120 (struct spdk_nvmf_ctrlr *ctrlr), 121 false); 122 123 DEFINE_STUB_V(spdk_nvmf_get_discovery_log_page, 124 (struct spdk_nvmf_tgt *tgt, void *buffer, uint64_t offset, uint32_t length)); 125 126 DEFINE_STUB(spdk_nvmf_request_complete, 127 int, 128 (struct spdk_nvmf_request *req), 129 -1); 130 131 DEFINE_STUB(spdk_nvmf_request_abort, 132 int, 133 (struct spdk_nvmf_request *req), 134 -1); 135 136 int 137 spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata) 138 { 139 uint64_t num_blocks; 140 141 SPDK_CU_ASSERT_FATAL(ns->bdev != NULL); 142 num_blocks = ns->bdev->blockcnt; 143 nsdata->nsze = num_blocks; 144 nsdata->ncap = num_blocks; 145 nsdata->nuse = num_blocks; 146 nsdata->nlbaf = 0; 147 nsdata->flbas.format = 0; 148 nsdata->lbaf[0].lbads = spdk_u32log2(512); 149 150 return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; 151 } 152 153 static void 154 test_get_log_page(void) 155 { 156 struct spdk_nvmf_subsystem subsystem = {}; 157 struct spdk_nvmf_request req = {}; 158 struct spdk_nvmf_qpair qpair = {}; 159 struct spdk_nvmf_ctrlr ctrlr = {}; 160 union nvmf_h2c_msg cmd = {}; 161 union nvmf_c2h_msg rsp = {}; 162 char data[4096]; 163 164 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 165 166 ctrlr.subsys = &subsystem; 167 168 qpair.ctrlr = &ctrlr; 169 170 req.qpair = &qpair; 171 req.cmd = &cmd; 172 req.rsp = &rsp; 173 req.data = &data; 174 req.length = sizeof(data); 175 176 /* Get Log Page - all valid */ 177 memset(&cmd, 0, sizeof(cmd)); 178 memset(&rsp, 0, sizeof(rsp)); 179 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 180 cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16; 181 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 182 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 183 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 184 185 /* Get Log Page with invalid log ID */ 186 memset(&cmd, 0, sizeof(cmd)); 187 memset(&rsp, 0, sizeof(rsp)); 188 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 189 cmd.nvme_cmd.cdw10 = 0; 190 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 191 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 192 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 193 194 /* Get Log Page with invalid offset (not dword aligned) */ 195 memset(&cmd, 0, sizeof(cmd)); 196 memset(&rsp, 0, sizeof(rsp)); 197 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 198 cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16; 199 cmd.nvme_cmd.cdw12 = 2; 200 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 201 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 202 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 203 204 /* Get Log Page without data buffer */ 205 memset(&cmd, 0, sizeof(cmd)); 206 memset(&rsp, 0, sizeof(rsp)); 207 req.data = NULL; 208 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 209 cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16; 210 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 211 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 212 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 213 req.data = data; 214 } 215 216 static void 217 test_process_fabrics_cmd(void) 218 { 219 struct spdk_nvmf_request req = {}; 220 int ret; 221 struct spdk_nvmf_qpair req_qpair = {}; 222 union nvmf_h2c_msg req_cmd = {}; 223 union nvmf_c2h_msg req_rsp = {}; 224 225 req.qpair = &req_qpair; 226 req.cmd = &req_cmd; 227 req.rsp = &req_rsp; 228 req.qpair->ctrlr = NULL; 229 230 /* No ctrlr and invalid command check */ 231 req.cmd->nvmf_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_PROPERTY_GET; 232 ret = spdk_nvmf_ctrlr_process_fabrics_cmd(&req); 233 CU_ASSERT_EQUAL(req.rsp->nvme_cpl.status.sc, SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR); 234 CU_ASSERT_EQUAL(ret, SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 235 } 236 237 static bool 238 nvme_status_success(const struct spdk_nvme_status *status) 239 { 240 return status->sct == SPDK_NVME_SCT_GENERIC && status->sc == SPDK_NVME_SC_SUCCESS; 241 } 242 243 struct spdk_thread * 244 spdk_get_thread(void) 245 { 246 return NULL; 247 } 248 249 void 250 spdk_thread_send_msg(const struct spdk_thread *thread, spdk_thread_fn fn, void *ctx) 251 { 252 fn(ctx); 253 } 254 255 static void 256 test_connect(void) 257 { 258 struct spdk_nvmf_fabric_connect_data connect_data; 259 struct spdk_nvmf_poll_group group; 260 struct spdk_nvmf_transport transport; 261 struct spdk_nvmf_subsystem subsystem; 262 struct spdk_nvmf_request req; 263 struct spdk_nvmf_qpair admin_qpair; 264 struct spdk_nvmf_qpair qpair; 265 struct spdk_nvmf_qpair qpair2; 266 struct spdk_nvmf_ctrlr ctrlr; 267 struct spdk_nvmf_tgt tgt; 268 union nvmf_h2c_msg cmd; 269 union nvmf_c2h_msg rsp; 270 const uint8_t hostid[16] = { 271 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 272 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F 273 }; 274 const char subnqn[] = "nqn.2016-06.io.spdk:subsystem1"; 275 const char hostnqn[] = "nqn.2016-06.io.spdk:host1"; 276 int rc; 277 278 memset(&group, 0, sizeof(group)); 279 280 memset(&ctrlr, 0, sizeof(ctrlr)); 281 TAILQ_INIT(&ctrlr.qpairs); 282 ctrlr.subsys = &subsystem; 283 ctrlr.qpair_mask = spdk_bit_array_create(3); 284 SPDK_CU_ASSERT_FATAL(ctrlr.qpair_mask != NULL); 285 ctrlr.vcprop.cc.bits.en = 1; 286 ctrlr.vcprop.cc.bits.iosqes = 6; 287 ctrlr.vcprop.cc.bits.iocqes = 4; 288 289 memset(&admin_qpair, 0, sizeof(admin_qpair)); 290 TAILQ_INSERT_TAIL(&ctrlr.qpairs, &admin_qpair, link); 291 admin_qpair.group = &group; 292 293 memset(&tgt, 0, sizeof(tgt)); 294 tgt.opts.max_queue_depth = 64; 295 tgt.opts.max_qpairs_per_ctrlr = 3; 296 297 memset(&transport, 0, sizeof(transport)); 298 transport.tgt = &tgt; 299 300 memset(&qpair, 0, sizeof(qpair)); 301 qpair.transport = &transport; 302 qpair.group = &group; 303 304 memset(&connect_data, 0, sizeof(connect_data)); 305 memcpy(connect_data.hostid, hostid, sizeof(hostid)); 306 connect_data.cntlid = 0xFFFF; 307 snprintf(connect_data.subnqn, sizeof(connect_data.subnqn), "%s", subnqn); 308 snprintf(connect_data.hostnqn, sizeof(connect_data.hostnqn), "%s", hostnqn); 309 310 memset(&subsystem, 0, sizeof(subsystem)); 311 subsystem.id = 1; 312 TAILQ_INIT(&subsystem.ctrlrs); 313 subsystem.tgt = &tgt; 314 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 315 snprintf(subsystem.subnqn, sizeof(subsystem.subnqn), "%s", subnqn); 316 317 memset(&cmd, 0, sizeof(cmd)); 318 cmd.connect_cmd.opcode = SPDK_NVME_OPC_FABRIC; 319 cmd.connect_cmd.cid = 1; 320 cmd.connect_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_CONNECT; 321 cmd.connect_cmd.recfmt = 0; 322 cmd.connect_cmd.qid = 0; 323 cmd.connect_cmd.sqsize = 31; 324 cmd.connect_cmd.cattr = 0; 325 cmd.connect_cmd.kato = 120000; 326 327 memset(&req, 0, sizeof(req)); 328 req.qpair = &qpair; 329 req.length = sizeof(connect_data); 330 req.xfer = SPDK_NVME_DATA_HOST_TO_CONTROLLER; 331 req.data = &connect_data; 332 req.cmd = &cmd; 333 req.rsp = &rsp; 334 335 MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, &subsystem); 336 MOCK_SET(spdk_nvmf_poll_group_create, struct spdk_nvmf_poll_group *, &group); 337 338 /* Valid admin connect command */ 339 memset(&rsp, 0, sizeof(rsp)); 340 rc = spdk_nvmf_ctrlr_connect(&req); 341 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 342 CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status)); 343 CU_ASSERT(qpair.ctrlr != NULL); 344 spdk_bit_array_free(&qpair.ctrlr->qpair_mask); 345 free(qpair.ctrlr); 346 qpair.ctrlr = NULL; 347 348 /* Invalid data length */ 349 memset(&rsp, 0, sizeof(rsp)); 350 req.length = sizeof(connect_data) - 1; 351 rc = spdk_nvmf_ctrlr_connect(&req); 352 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 353 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 354 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 355 CU_ASSERT(qpair.ctrlr == NULL); 356 req.length = sizeof(connect_data); 357 358 /* Invalid recfmt */ 359 memset(&rsp, 0, sizeof(rsp)); 360 cmd.connect_cmd.recfmt = 1234; 361 rc = spdk_nvmf_ctrlr_connect(&req); 362 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 363 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 364 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INCOMPATIBLE_FORMAT); 365 CU_ASSERT(qpair.ctrlr == NULL); 366 cmd.connect_cmd.recfmt = 0; 367 368 /* Unterminated subnqn */ 369 memset(&rsp, 0, sizeof(rsp)); 370 memset(connect_data.subnqn, 'a', sizeof(connect_data.subnqn)); 371 rc = spdk_nvmf_ctrlr_connect(&req); 372 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 373 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 374 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 375 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 376 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256); 377 CU_ASSERT(qpair.ctrlr == NULL); 378 snprintf(connect_data.subnqn, sizeof(connect_data.subnqn), "%s", subnqn); 379 380 /* Subsystem not found */ 381 memset(&rsp, 0, sizeof(rsp)); 382 MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, NULL); 383 rc = spdk_nvmf_ctrlr_connect(&req); 384 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 385 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 386 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 387 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 388 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256); 389 CU_ASSERT(qpair.ctrlr == NULL); 390 MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, &subsystem); 391 392 /* Unterminated hostnqn */ 393 memset(&rsp, 0, sizeof(rsp)); 394 memset(connect_data.hostnqn, 'b', sizeof(connect_data.hostnqn)); 395 rc = spdk_nvmf_ctrlr_connect(&req); 396 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 397 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 398 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 399 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 400 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 512); 401 CU_ASSERT(qpair.ctrlr == NULL); 402 snprintf(connect_data.hostnqn, sizeof(connect_data.hostnqn), "%s", hostnqn); 403 404 /* Host not allowed */ 405 memset(&rsp, 0, sizeof(rsp)); 406 MOCK_SET(spdk_nvmf_subsystem_host_allowed, bool, false); 407 rc = spdk_nvmf_ctrlr_connect(&req); 408 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 409 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 410 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_HOST); 411 CU_ASSERT(qpair.ctrlr == NULL); 412 MOCK_SET(spdk_nvmf_subsystem_host_allowed, bool, true); 413 414 /* Invalid sqsize == 0 */ 415 memset(&rsp, 0, sizeof(rsp)); 416 cmd.connect_cmd.sqsize = 0; 417 rc = spdk_nvmf_ctrlr_connect(&req); 418 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 419 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 420 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 421 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 422 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44); 423 CU_ASSERT(qpair.ctrlr == NULL); 424 cmd.connect_cmd.sqsize = 31; 425 426 /* Invalid sqsize > max_queue_depth */ 427 memset(&rsp, 0, sizeof(rsp)); 428 cmd.connect_cmd.sqsize = 64; 429 rc = spdk_nvmf_ctrlr_connect(&req); 430 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 431 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 432 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 433 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 434 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44); 435 CU_ASSERT(qpair.ctrlr == NULL); 436 cmd.connect_cmd.sqsize = 31; 437 438 /* Invalid cntlid for admin queue */ 439 memset(&rsp, 0, sizeof(rsp)); 440 connect_data.cntlid = 0x1234; 441 rc = spdk_nvmf_ctrlr_connect(&req); 442 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 443 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 444 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 445 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 446 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16); 447 CU_ASSERT(qpair.ctrlr == NULL); 448 connect_data.cntlid = 0xFFFF; 449 450 ctrlr.admin_qpair = &admin_qpair; 451 ctrlr.subsys = &subsystem; 452 453 /* Valid I/O queue connect command */ 454 memset(&rsp, 0, sizeof(rsp)); 455 MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, &ctrlr); 456 cmd.connect_cmd.qid = 1; 457 rc = spdk_nvmf_ctrlr_connect(&req); 458 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 459 CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status)); 460 CU_ASSERT(qpair.ctrlr == &ctrlr); 461 qpair.ctrlr = NULL; 462 TAILQ_INIT(&ctrlr.qpairs); 463 464 /* Non-existent controller */ 465 memset(&rsp, 0, sizeof(rsp)); 466 MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, NULL); 467 rc = spdk_nvmf_ctrlr_connect(&req); 468 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 469 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 470 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 471 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 472 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16); 473 CU_ASSERT(qpair.ctrlr == NULL); 474 MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, &ctrlr); 475 476 /* I/O connect to discovery controller */ 477 memset(&rsp, 0, sizeof(rsp)); 478 subsystem.subtype = SPDK_NVMF_SUBTYPE_DISCOVERY; 479 rc = spdk_nvmf_ctrlr_connect(&req); 480 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 481 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 482 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 483 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 484 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 485 CU_ASSERT(qpair.ctrlr == NULL); 486 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 487 488 /* I/O connect to disabled controller */ 489 memset(&rsp, 0, sizeof(rsp)); 490 ctrlr.vcprop.cc.bits.en = 0; 491 rc = spdk_nvmf_ctrlr_connect(&req); 492 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 493 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 494 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 495 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 496 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 497 CU_ASSERT(qpair.ctrlr == NULL); 498 ctrlr.vcprop.cc.bits.en = 1; 499 500 /* I/O connect with invalid IOSQES */ 501 memset(&rsp, 0, sizeof(rsp)); 502 ctrlr.vcprop.cc.bits.iosqes = 3; 503 rc = spdk_nvmf_ctrlr_connect(&req); 504 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 505 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 506 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 507 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 508 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 509 CU_ASSERT(qpair.ctrlr == NULL); 510 ctrlr.vcprop.cc.bits.iosqes = 6; 511 512 /* I/O connect with invalid IOCQES */ 513 memset(&rsp, 0, sizeof(rsp)); 514 ctrlr.vcprop.cc.bits.iocqes = 3; 515 rc = spdk_nvmf_ctrlr_connect(&req); 516 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 517 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 518 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 519 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 520 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 521 CU_ASSERT(qpair.ctrlr == NULL); 522 ctrlr.vcprop.cc.bits.iocqes = 4; 523 524 /* I/O connect with too many existing qpairs */ 525 memset(&rsp, 0, sizeof(rsp)); 526 spdk_bit_array_set(ctrlr.qpair_mask, 0); 527 spdk_bit_array_set(ctrlr.qpair_mask, 1); 528 spdk_bit_array_set(ctrlr.qpair_mask, 2); 529 rc = spdk_nvmf_ctrlr_connect(&req); 530 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 531 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 532 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER); 533 CU_ASSERT(qpair.ctrlr == NULL); 534 spdk_bit_array_clear(ctrlr.qpair_mask, 0); 535 spdk_bit_array_clear(ctrlr.qpair_mask, 1); 536 spdk_bit_array_clear(ctrlr.qpair_mask, 2); 537 538 /* I/O connect with duplicate queue ID */ 539 memset(&rsp, 0, sizeof(rsp)); 540 memset(&qpair2, 0, sizeof(qpair2)); 541 qpair2.group = &group; 542 qpair2.qid = 1; 543 TAILQ_INSERT_TAIL(&ctrlr.qpairs, &qpair, link); 544 spdk_bit_array_set(ctrlr.qpair_mask, 1); 545 cmd.connect_cmd.qid = 1; 546 rc = spdk_nvmf_ctrlr_connect(&req); 547 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 548 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 549 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER); 550 CU_ASSERT(qpair.ctrlr == NULL); 551 TAILQ_INIT(&ctrlr.qpairs); 552 553 /* Clean up globals */ 554 MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, NULL); 555 MOCK_SET(spdk_nvmf_poll_group_create, struct spdk_nvmf_poll_group *, NULL); 556 557 spdk_bit_array_free(&ctrlr.qpair_mask); 558 } 559 560 static void 561 test_get_ns_id_desc_list(void) 562 { 563 struct spdk_nvmf_subsystem subsystem; 564 struct spdk_nvmf_qpair qpair; 565 struct spdk_nvmf_ctrlr ctrlr; 566 struct spdk_nvmf_request req; 567 struct spdk_nvmf_ns *ns_ptrs[1]; 568 struct spdk_nvmf_ns ns; 569 union nvmf_h2c_msg cmd; 570 union nvmf_c2h_msg rsp; 571 struct spdk_bdev bdev; 572 uint8_t buf[4096]; 573 574 memset(&subsystem, 0, sizeof(subsystem)); 575 ns_ptrs[0] = &ns; 576 subsystem.ns = ns_ptrs; 577 subsystem.max_nsid = 1; 578 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 579 580 memset(&ns, 0, sizeof(ns)); 581 ns.opts.nsid = 1; 582 ns.bdev = &bdev; 583 584 memset(&qpair, 0, sizeof(qpair)); 585 qpair.ctrlr = &ctrlr; 586 587 memset(&ctrlr, 0, sizeof(ctrlr)); 588 ctrlr.subsys = &subsystem; 589 ctrlr.vcprop.cc.bits.en = 1; 590 591 memset(&req, 0, sizeof(req)); 592 req.qpair = &qpair; 593 req.cmd = &cmd; 594 req.rsp = &rsp; 595 req.xfer = SPDK_NVME_DATA_CONTROLLER_TO_HOST; 596 req.data = buf; 597 req.length = sizeof(buf); 598 599 memset(&cmd, 0, sizeof(cmd)); 600 cmd.nvme_cmd.opc = SPDK_NVME_OPC_IDENTIFY; 601 cmd.nvme_cmd.cdw10 = SPDK_NVME_IDENTIFY_NS_ID_DESCRIPTOR_LIST; 602 603 /* Invalid NSID */ 604 cmd.nvme_cmd.nsid = 0; 605 memset(&rsp, 0, sizeof(rsp)); 606 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 607 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 608 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 609 610 /* Valid NSID, but ns has no IDs defined */ 611 cmd.nvme_cmd.nsid = 1; 612 memset(&rsp, 0, sizeof(rsp)); 613 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 614 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 615 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 616 CU_ASSERT(spdk_mem_all_zero(buf, sizeof(buf))); 617 618 /* Valid NSID, only EUI64 defined */ 619 ns.opts.eui64[0] = 0x11; 620 ns.opts.eui64[7] = 0xFF; 621 memset(&rsp, 0, sizeof(rsp)); 622 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 623 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 624 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 625 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); 626 CU_ASSERT(buf[1] == 8); 627 CU_ASSERT(buf[4] == 0x11); 628 CU_ASSERT(buf[11] == 0xFF); 629 CU_ASSERT(buf[13] == 0); 630 631 /* Valid NSID, only NGUID defined */ 632 memset(ns.opts.eui64, 0, sizeof(ns.opts.eui64)); 633 ns.opts.nguid[0] = 0x22; 634 ns.opts.nguid[15] = 0xEE; 635 memset(&rsp, 0, sizeof(rsp)); 636 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 637 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 638 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 639 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_NGUID); 640 CU_ASSERT(buf[1] == 16); 641 CU_ASSERT(buf[4] == 0x22); 642 CU_ASSERT(buf[19] == 0xEE); 643 CU_ASSERT(buf[21] == 0); 644 645 /* Valid NSID, both EUI64 and NGUID defined */ 646 ns.opts.eui64[0] = 0x11; 647 ns.opts.eui64[7] = 0xFF; 648 ns.opts.nguid[0] = 0x22; 649 ns.opts.nguid[15] = 0xEE; 650 memset(&rsp, 0, sizeof(rsp)); 651 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 652 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 653 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 654 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); 655 CU_ASSERT(buf[1] == 8); 656 CU_ASSERT(buf[4] == 0x11); 657 CU_ASSERT(buf[11] == 0xFF); 658 CU_ASSERT(buf[12] == SPDK_NVME_NIDT_NGUID); 659 CU_ASSERT(buf[13] == 16); 660 CU_ASSERT(buf[16] == 0x22); 661 CU_ASSERT(buf[31] == 0xEE); 662 CU_ASSERT(buf[33] == 0); 663 664 /* Valid NSID, EUI64, NGUID, and UUID defined */ 665 ns.opts.eui64[0] = 0x11; 666 ns.opts.eui64[7] = 0xFF; 667 ns.opts.nguid[0] = 0x22; 668 ns.opts.nguid[15] = 0xEE; 669 ns.opts.uuid.u.raw[0] = 0x33; 670 ns.opts.uuid.u.raw[15] = 0xDD; 671 memset(&rsp, 0, sizeof(rsp)); 672 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 673 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 674 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 675 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); 676 CU_ASSERT(buf[1] == 8); 677 CU_ASSERT(buf[4] == 0x11); 678 CU_ASSERT(buf[11] == 0xFF); 679 CU_ASSERT(buf[12] == SPDK_NVME_NIDT_NGUID); 680 CU_ASSERT(buf[13] == 16); 681 CU_ASSERT(buf[16] == 0x22); 682 CU_ASSERT(buf[31] == 0xEE); 683 CU_ASSERT(buf[32] == SPDK_NVME_NIDT_UUID); 684 CU_ASSERT(buf[33] == 16); 685 CU_ASSERT(buf[36] == 0x33); 686 CU_ASSERT(buf[51] == 0xDD); 687 CU_ASSERT(buf[53] == 0); 688 } 689 690 static void 691 test_identify_ns(void) 692 { 693 struct spdk_nvmf_subsystem subsystem = {}; 694 struct spdk_nvme_cmd cmd = {}; 695 struct spdk_nvme_cpl rsp = {}; 696 struct spdk_nvme_ns_data nsdata = {}; 697 struct spdk_bdev bdev[3] = {{.blockcnt = 1234}, {.blockcnt = 0}, {.blockcnt = 5678}}; 698 struct spdk_nvmf_ns ns[3] = {{.bdev = &bdev[0]}, {.bdev = NULL}, {.bdev = &bdev[2]}}; 699 struct spdk_nvmf_ns *ns_arr[3] = {&ns[0], NULL, &ns[2]}; 700 701 subsystem.ns = ns_arr; 702 subsystem.max_nsid = SPDK_COUNTOF(ns_arr); 703 704 /* Invalid NSID 0 */ 705 cmd.nsid = 0; 706 memset(&nsdata, 0, sizeof(nsdata)); 707 memset(&rsp, 0, sizeof(rsp)); 708 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&subsystem, &cmd, &rsp, 709 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 710 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 711 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 712 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 713 714 /* Valid NSID 1 */ 715 cmd.nsid = 1; 716 memset(&nsdata, 0, sizeof(nsdata)); 717 memset(&rsp, 0, sizeof(rsp)); 718 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&subsystem, &cmd, &rsp, 719 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 720 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 721 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS); 722 CU_ASSERT(nsdata.nsze == 1234); 723 724 /* Valid but inactive NSID 2 */ 725 cmd.nsid = 2; 726 memset(&nsdata, 0, sizeof(nsdata)); 727 memset(&rsp, 0, sizeof(rsp)); 728 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&subsystem, &cmd, &rsp, 729 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 730 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 731 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS); 732 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 733 734 /* Valid NSID 3 */ 735 cmd.nsid = 3; 736 memset(&nsdata, 0, sizeof(nsdata)); 737 memset(&rsp, 0, sizeof(rsp)); 738 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&subsystem, &cmd, &rsp, 739 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 740 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 741 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS); 742 CU_ASSERT(nsdata.nsze == 5678); 743 744 /* Invalid NSID 4 */ 745 cmd.nsid = 4; 746 memset(&nsdata, 0, sizeof(nsdata)); 747 memset(&rsp, 0, sizeof(rsp)); 748 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&subsystem, &cmd, &rsp, 749 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 750 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 751 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 752 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 753 754 /* Invalid NSID 0xFFFFFFFF (NS management not supported) */ 755 cmd.nsid = 0xFFFFFFFF; 756 memset(&nsdata, 0, sizeof(nsdata)); 757 memset(&rsp, 0, sizeof(rsp)); 758 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&subsystem, &cmd, &rsp, 759 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 760 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 761 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 762 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 763 } 764 765 int main(int argc, char **argv) 766 { 767 CU_pSuite suite = NULL; 768 unsigned int num_failures; 769 770 if (CU_initialize_registry() != CUE_SUCCESS) { 771 return CU_get_error(); 772 } 773 774 suite = CU_add_suite("nvmf", NULL, NULL); 775 if (suite == NULL) { 776 CU_cleanup_registry(); 777 return CU_get_error(); 778 } 779 780 if ( 781 CU_add_test(suite, "get_log_page", test_get_log_page) == NULL || 782 CU_add_test(suite, "process_fabrics_cmd", test_process_fabrics_cmd) == NULL || 783 CU_add_test(suite, "connect", test_connect) == NULL || 784 CU_add_test(suite, "get_ns_id_desc_list", test_get_ns_id_desc_list) == NULL || 785 CU_add_test(suite, "identify_ns", test_identify_ns) == NULL 786 ) { 787 CU_cleanup_registry(); 788 return CU_get_error(); 789 } 790 791 CU_basic_set_mode(CU_BRM_VERBOSE); 792 CU_basic_run_tests(); 793 num_failures = CU_get_number_of_failures(); 794 CU_cleanup_registry(); 795 return num_failures; 796 } 797